From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C516465C2 for ; Fri, 18 Apr 2025 15:24:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 371C3402D2; Fri, 18 Apr 2025 15:24:51 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 2059F40263 for ; Fri, 18 Apr 2025 15:24:50 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id C568F123FA7; Fri, 18 Apr 2025 15:24:27 +0200 (CEST) Subject: |WARNING| pw153039 [PATCH 1/3] rust: RFC/demo of safe API for Dpdk Eal, Eth and Rxq In-Reply-To: <20250418132324.4085336-1-harry.van.haaren@intel.com> References: <20250418132324.4085336-1-harry.van.haaren@intel.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Harry van Haaren Message-Id: <20250418132427.C568F123FA7@dpdk.org> Date: Fri, 18 Apr 2025 15:24:27 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/153039 _coding style issues_ WARNING:TYPO_SPELLING: 'crate' may be misspelled - perhaps 'create'? #128: FILE: rust_api_example/src/main.rs:20: + pub(crate) fn new(port: u16, queue: u16) -> Self { WARNING:TYPO_SPELLING: 'recieve' may be misspelled - perhaps 'receive'? #138: FILE: rust_api_example/src/main.rs:30: + // and the Rxq has the rx_burst() function: this allows the application to recieve packets. WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #159: FILE: rust_api_example/src/main.rs:51: + pub fn rx_burst(&mut self, _mbufs: &mut [u8]) -> Result { WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #159: FILE: rust_api_example/src/main.rs:51: + pub fn rx_burst(&mut self, _mbufs: &mut [u8]) -> Result { WARNING:TYPO_SPELLING: 'crate' may be misspelled - perhaps 'create'? #161: FILE: rust_api_example/src/main.rs:53: + // e.g.: investigate "ArrayVec" crate for safe & fixed sized, stack allocated arrays WARNING:TYPO_SPELLING: 'crate' may be misspelled - perhaps 'create'? #185: FILE: rust_api_example/src/main.rs:77: + // pub(crate) here ensures outside this crate users cannot call this function WARNING:TYPO_SPELLING: 'crate' may be misspelled - perhaps 'create'? #185: FILE: rust_api_example/src/main.rs:77: + // pub(crate) here ensures outside this crate users cannot call this function WARNING:TYPO_SPELLING: 'crate' may be misspelled - perhaps 'create'? #186: FILE: rust_api_example/src/main.rs:78: + pub(crate) fn from_u16(id: u16) -> Self { WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #194: FILE: rust_api_example/src/main.rs:86: + pub fn rxqs(&mut self, rxq_count: u16, _mempool: Mempool) -> Result<(), String> { WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #202: FILE: rust_api_example/src/main.rs:94: + pub fn start(&mut self) -> (Vec, Vec) { WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #205: FILE: rust_api_example/src/main.rs:97: + std::mem::take(&mut self.rxqs), WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #206: FILE: rust_api_example/src/main.rs:98: + std::mem::take(&mut self.txqs), WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #244: FILE: rust_api_example/src/main.rs:136: + pub fn take_eth_ports(&mut self) -> Option> { WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #250: FILE: rust_api_example/src/main.rs:142: + fn drop(&mut self) { WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #257: FILE: rust_api_example/src/main.rs:149: + let mut dpdk = dpdk::Eal::init().expect("dpdk must init ok"); WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #260: FILE: rust_api_example/src/main.rs:152: + let mut ports = dpdk.take_eth_ports().expect("take eth ports ok"); WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #261: FILE: rust_api_example/src/main.rs:153: + let mut p = ports.pop().unwrap(); WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #266: FILE: rust_api_example/src/main.rs:158: + let (mut rxqs, _txqs) = p.start(); WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #280: FILE: rust_api_example/src/main.rs:172: + // let mut rxq = rxq2.enable_polling(); WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #284: FILE: rust_api_example/src/main.rs:176: + let mut rxq = rxq1.enable_polling(); WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #286: FILE: rust_api_example/src/main.rs:178: + let _nb_mbufs = rxq.rx_burst(&mut [0; 32]); WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #292: FILE: rust_api_example/src/main.rs:184: + let mut rxq = rxq2.enable_polling(); WARNING:TYPO_SPELLING: 'mut' may be misspelled - perhaps 'must'? #294: FILE: rust_api_example/src/main.rs:186: + let _nb_mbufs = rxq.rx_burst(&mut [0; 32]); total: 0 errors, 23 warnings, 195 lines checked