From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 636EC46629 for ; Fri, 25 Apr 2025 12:03:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5EB4240263; Fri, 25 Apr 2025 12:03:15 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 07643400D5 for ; Fri, 25 Apr 2025 12:03:14 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id C2E031251C3; Fri, 25 Apr 2025 12:03:13 +0200 (CEST) Subject: |WARNING| pw153150 [PATCH 04/13] net/sxe: add link, flow ctrl, mac ops, mtu ops function In-Reply-To: <20250425023652.37368-4-liujie5@linkdatatechnology.com> References: <20250425023652.37368-4-liujie5@linkdatatechnology.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Jie Liu Message-Id: <20250425100313.C2E031251C3@dpdk.org> Date: Fri, 25 Apr 2025 12:03:13 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/153150 _coding style issues_ WARNING:TYPO_SPELLING: 'unsupport' may be misspelled - perhaps 'unsupported'? #328: FILE: drivers/net/sxe/pf/sxe_ethdev.c:273: + PMD_LOG_ERR(INIT, "unsupport loopback mode:%u.", CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects? #616: FILE: drivers/net/sxe/pf/sxe_filter.c:28: +#define SXE_STRIP_BITMAP_SET(h, q) \ + do { \ + u32 idx = (q) / (sizeof((h)->strip_bitmap[0]) * BYTE_BIT_NUM); \ + u32 bit = (q) % (sizeof((h)->strip_bitmap[0]) * BYTE_BIT_NUM); \ + (h)->strip_bitmap[idx] |= 1 << bit;\ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects? #623: FILE: drivers/net/sxe/pf/sxe_filter.c:35: +#define SXE_STRIP_BITMAP_CLEAR(h, q) \ + do {\ + u32 idx = (q) / (sizeof((h)->strip_bitmap[0]) * BYTE_BIT_NUM); \ + u32 bit = (q) % (sizeof((h)->strip_bitmap[0]) * BYTE_BIT_NUM); \ + (h)->strip_bitmap[idx] &= ~(1 << bit);\ + } while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects? #630: FILE: drivers/net/sxe/pf/sxe_filter.c:42: +#define SXE_STRIP_BITMAP_GET(h, q, r) \ + do {\ + u32 idx = (q) / (sizeof((h)->strip_bitmap[0]) * BYTE_BIT_NUM); \ + u32 bit = (q) % (sizeof((h)->strip_bitmap[0]) * BYTE_BIT_NUM); \ + (r) = (h)->strip_bitmap[idx] >> bit & 1;\ + } while (0) WARNING:TYPO_SPELLING: 'exsit' may be misspelled - perhaps 'exist'? #1406: FILE: drivers/net/sxe/pf/sxe_phy.c:181: + PMD_LOG_INFO(INIT, "other link config thread exsit"); WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'? #2023: FILE: drivers/net/sxe/pf/sxe_phy.c:798: + PMD_LOG_INFO(INIT, "link down, dont fc autoneg"); WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'? #2029: FILE: drivers/net/sxe/pf/sxe_phy.c:804: + "dont fc autoneg", link_speed); WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name mismatch: 'From: JieLiu ' != 'Signed-off-by: Jie Liu ' total: 0 errors, 5 warnings, 3 checks, 2186 lines checked Warning in drivers/net/sxe/pf/sxe_ethdev.c: Warning in drivers/net/sxe/pf/sxe_irq.c: Warning in drivers/net/sxe/pf/sxe_phy.c: Using rte_atomicNN_xxx Warning in drivers/net/sxe/pf/sxe_ethdev.c: Warning in drivers/net/sxe/pf/sxe_irq.c: Warning in drivers/net/sxe/pf/sxe_phy.c: Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer rte_atomic_xxx/rte_memory_order_xxx Warning in drivers/net/sxe/pf/sxe_phy.c: Using pthread functions, prefer rte_thread