|WARNING| pw153307 [PATCH v2 1/2] cmdline: add floating point support

[checkpatch@dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/153307

_coding style issues_


ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#99: FILE: app/test/test_cmdline_num.c:29:
+	const char * str;

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#294: FILE: app/test/test_cmdline_num.c:548:
+			ret = cmdline_parse_num((cmdline_parse_token_hdr_t*)&token,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#295: FILE: app/test/test_cmdline_num.c:549:
+					float_invalid_strs[i], (void*)&result, sizeof(result));

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#298: FILE: app/test/test_cmdline_num.c:552:
+				cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#340: FILE: app/test/test_cmdline_num.c:664:
+			cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#343: FILE: app/test/test_cmdline_num.c:667:
+			ret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#345: FILE: app/test/test_cmdline_num.c:669:
+				(void*)&result, sizeof(result));

WARNING:LONG_LINE_COMMENT: line length of 105 exceeds 100 columns
#347: FILE: app/test/test_cmdline_num.c:671:
+			/* if it should have passed but didn't, or if it should have failed but didn't */

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#348: FILE: app/test/test_cmdline_num.c:672:
+			if ((ret < 0) == (can_parse_float(num_valid_float_strs[i].result, type) > 0)) {

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#354: FILE: app/test/test_cmdline_num.c:678:
+			if (ret > 0 && float_cmp(num_valid_float_strs[i].result, &result, type) != 0) {

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#460: FILE: lib/cmdline/cmdline_parse_num.c:121:
+		if (res) *(float *)res = flt;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#462: FILE: lib/cmdline/cmdline_parse_num.c:123:
+		if (res) *(double *)res = result;

WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'?
#477: FILE: lib/cmdline/cmdline_parse_num.c:155:
+		if (ressize < sizeof(float))

WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'?
#481: FILE: lib/cmdline/cmdline_parse_num.c:159:
+		if (ressize < sizeof(double))

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#499: FILE: lib/cmdline/cmdline_parse_num.c:232:
 			}
+			else if (c == '.') {

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#519: FILE: lib/cmdline/cmdline_parse_num.c:262:
+			}
+			else {

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#533: FILE: lib/cmdline/cmdline_parse_num.c:276:
+			}
+			else {

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#545: FILE: lib/cmdline/cmdline_parse_num.c:288:
+			}
+			else if (c == '-') {

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#549: FILE: lib/cmdline/cmdline_parse_num.c:292:
+			}
+			else {

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#559: FILE: lib/cmdline/cmdline_parse_num.c:302:
 			}
+			else if (c == '.') {

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#579: FILE: lib/cmdline/cmdline_parse_num.c:325:
 			}
+			else if (c == '.') {

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#585: FILE: lib/cmdline/cmdline_parse_num.c:331:
+			}
+			else if (c == 'e' || c == 'E') {

total: 17 errors, 5 warnings, 628 lines checked