From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0191D466E8 for ; Wed, 7 May 2025 11:52:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F16324025D; Wed, 7 May 2025 11:52:02 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 8DF0C4025A for ; Wed, 7 May 2025 11:51:59 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 195E8123FAA; Wed, 7 May 2025 11:51:45 +0200 (CEST) Subject: |WARNING| pw153338 [PATCH v3 1/2] cmdline: add floating point support In-Reply-To: References: To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Anatoly Burakov Message-Id: <20250507095145.195E8123FAA@dpdk.org> Date: Wed, 7 May 2025 11:51:45 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/153338 _coding style issues_ ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar" #103: FILE: app/test/test_cmdline_num.c:29: + const char * str; ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #300: FILE: app/test/test_cmdline_num.c:550: + ret = cmdline_parse_num((cmdline_parse_token_hdr_t*)&token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #301: FILE: app/test/test_cmdline_num.c:551: + float_invalid_strs[i], (void*)&result, sizeof(result)); ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #304: FILE: app/test/test_cmdline_num.c:554: + cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #346: FILE: app/test/test_cmdline_num.c:666: + cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #349: FILE: app/test/test_cmdline_num.c:669: + ret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #351: FILE: app/test/test_cmdline_num.c:671: + (void*)&result, sizeof(result)); WARNING:LONG_LINE_COMMENT: line length of 105 exceeds 100 columns #353: FILE: app/test/test_cmdline_num.c:673: + /* if it should have passed but didn't, or if it should have failed but didn't */ WARNING:LONG_LINE: line length of 103 exceeds 100 columns #354: FILE: app/test/test_cmdline_num.c:674: + if ((ret < 0) == (can_parse_float(num_valid_float_strs[i].result, type) > 0)) { WARNING:LONG_LINE: line length of 103 exceeds 100 columns #360: FILE: app/test/test_cmdline_num.c:680: + if (ret > 0 && float_cmp(num_valid_float_strs[i].result, &result, type) != 0) { ERROR:TRAILING_STATEMENTS: trailing statements should be on next line #546: FILE: lib/cmdline/cmdline_parse_num.c:122: + if (res) *(float *)res = flt; ERROR:TRAILING_STATEMENTS: trailing statements should be on next line #548: FILE: lib/cmdline/cmdline_parse_num.c:124: + if (res) *(double *)res = result; WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'? #563: FILE: lib/cmdline/cmdline_parse_num.c:156: + if (ressize < sizeof(float)) WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'? #567: FILE: lib/cmdline/cmdline_parse_num.c:160: + if (ressize < sizeof(double)) ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #585: FILE: lib/cmdline/cmdline_parse_num.c:233: } + else if (c == '.') { ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #605: FILE: lib/cmdline/cmdline_parse_num.c:263: + } + else { ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #619: FILE: lib/cmdline/cmdline_parse_num.c:277: + } + else { ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #631: FILE: lib/cmdline/cmdline_parse_num.c:289: + } + else if (c == '-') { ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #635: FILE: lib/cmdline/cmdline_parse_num.c:293: + } + else { ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #647: FILE: lib/cmdline/cmdline_parse_num.c:305: + } + else { ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #657: FILE: lib/cmdline/cmdline_parse_num.c:315: } + else if (c == '.') { ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #677: FILE: lib/cmdline/cmdline_parse_num.c:338: } + else if (c == '.') { ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #683: FILE: lib/cmdline/cmdline_parse_num.c:344: + } + else if (c == 'e' || c == 'E') { total: 18 errors, 5 warnings, 705 lines checked