|WARNING| pw153340 [PATCH v4 1/2] cmdline: add floating point support

[checkpatch@dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/153340

_coding style issues_


ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#115: FILE: app/test/test_cmdline_num.c:29:
+	const char * str;

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#312: FILE: app/test/test_cmdline_num.c:550:
+			ret = cmdline_parse_num((cmdline_parse_token_hdr_t*)&token,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#313: FILE: app/test/test_cmdline_num.c:551:
+					float_invalid_strs[i], (void*)&result, sizeof(result));

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#316: FILE: app/test/test_cmdline_num.c:554:
+				cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#358: FILE: app/test/test_cmdline_num.c:666:
+			cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#361: FILE: app/test/test_cmdline_num.c:669:
+			ret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#363: FILE: app/test/test_cmdline_num.c:671:
+				(void*)&result, sizeof(result));

WARNING:LONG_LINE_COMMENT: line length of 105 exceeds 100 columns
#365: FILE: app/test/test_cmdline_num.c:673:
+			/* if it should have passed but didn't, or if it should have failed but didn't */

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#366: FILE: app/test/test_cmdline_num.c:674:
+			if ((ret < 0) == (can_parse_float(num_valid_float_strs[i].result, type) > 0)) {

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#372: FILE: app/test/test_cmdline_num.c:680:
+			if (ret > 0 && float_cmp(num_valid_float_strs[i].result, &result, type) != 0) {

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#558: FILE: lib/cmdline/cmdline_parse_num.c:122:
+		if (res) *(float *)res = flt;

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#560: FILE: lib/cmdline/cmdline_parse_num.c:124:
+		if (res) *(double *)res = result;

WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'?
#575: FILE: lib/cmdline/cmdline_parse_num.c:156:
+		if (ressize < sizeof(float))

WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'?
#579: FILE: lib/cmdline/cmdline_parse_num.c:160:
+		if (ressize < sizeof(double))

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#597: FILE: lib/cmdline/cmdline_parse_num.c:233:
 			}
+			else if (c == '.') {

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#617: FILE: lib/cmdline/cmdline_parse_num.c:263:
+			}
+			else {

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#631: FILE: lib/cmdline/cmdline_parse_num.c:277:
+			}
+			else {

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#643: FILE: lib/cmdline/cmdline_parse_num.c:289:
+			}
+			else if (c == '-') {

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#647: FILE: lib/cmdline/cmdline_parse_num.c:293:
+			}
+			else {

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#659: FILE: lib/cmdline/cmdline_parse_num.c:305:
+			}
+			else {

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#669: FILE: lib/cmdline/cmdline_parse_num.c:315:
 			}
+			else if (c == '.') {

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#689: FILE: lib/cmdline/cmdline_parse_num.c:338:
 			}
+			else if (c == '.') {

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#695: FILE: lib/cmdline/cmdline_parse_num.c:344:
+			}
+			else if (c == 'e' || c == 'E') {

total: 18 errors, 5 warnings, 704 lines checked