From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DF29466DD for ; Wed, 7 May 2025 17:23:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 57FB64025D; Wed, 7 May 2025 17:23:49 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id D0B8F4025A for ; Wed, 7 May 2025 17:23:47 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 19E20123FBC; Wed, 7 May 2025 17:23:33 +0200 (CEST) Subject: |WARNING| pw153344 [PATCH v5 2/3] cmdline: add floating point support In-Reply-To: References: To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Anatoly Burakov Message-Id: <20250507152333.19E20123FBC@dpdk.org> Date: Wed, 7 May 2025 17:23:33 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/153344 _coding style issues_ ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar" #118: FILE: app/test/test_cmdline_num.c:29: + const char * str; ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #311: FILE: app/test/test_cmdline_num.c:545: + ret = cmdline_parse_num((cmdline_parse_token_hdr_t*)&token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #312: FILE: app/test/test_cmdline_num.c:546: + float_invalid_strs[i], (void*)&result, sizeof(result)); ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #315: FILE: app/test/test_cmdline_num.c:549: + cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token, ERROR:CODE_INDENT: code indent should use tabs where possible #348: FILE: app/test/test_cmdline_num.c:614: + ^I^I^Iret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #348: FILE: app/test/test_cmdline_num.c:614: + ^I^I^Iret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #348: FILE: app/test/test_cmdline_num.c:614: + ^I^I^Iret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,$ ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #348: FILE: app/test/test_cmdline_num.c:614: + ret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #367: FILE: app/test/test_cmdline_num.c:661: + cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #370: FILE: app/test/test_cmdline_num.c:664: + ret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #372: FILE: app/test/test_cmdline_num.c:666: + (void*)&result, sizeof(result)); WARNING:LONG_LINE_COMMENT: line length of 105 exceeds 100 columns #374: FILE: app/test/test_cmdline_num.c:668: + /* if it should have passed but didn't, or if it should have failed but didn't */ WARNING:LONG_LINE: line length of 103 exceeds 100 columns #375: FILE: app/test/test_cmdline_num.c:669: + if ((ret < 0) == (can_parse_float(num_valid_float_strs[i].result, type) > 0)) { WARNING:LONG_LINE: line length of 103 exceeds 100 columns #381: FILE: app/test/test_cmdline_num.c:675: + if (ret > 0 && float_cmp(num_valid_float_strs[i].result, &result, type) != 0) { WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'? #503: FILE: lib/cmdline/cmdline_parse_num.c:78: + if (ressize < sizeof(float)) WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'? #507: FILE: lib/cmdline/cmdline_parse_num.c:82: + if (ressize < sizeof(double)) ERROR:TRAILING_STATEMENTS: trailing statements should be on next line #548: FILE: lib/cmdline/cmdline_parse_num.c:318: + if (res) *(float *)res = flt; ERROR:TRAILING_STATEMENTS: trailing statements should be on next line #551: FILE: lib/cmdline/cmdline_parse_num.c:321: + if (res) *(double *)res = dres; total: 11 errors, 7 warnings, 425 lines checked