From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71E67466DD for ; Wed, 7 May 2025 17:23:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6830E4025D; Wed, 7 May 2025 17:23:54 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id E1C614025A for ; Wed, 7 May 2025 17:23:52 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 2CEA9123FBE; Wed, 7 May 2025 17:23:38 +0200 (CEST) Subject: |WARNING| pw153343 [PATCH v5 1/3] cmdline: use C standard library as number parser In-Reply-To: References: To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Anatoly Burakov Message-Id: <20250507152338.2CEA9123FBE@dpdk.org> Date: Wed, 7 May 2025 17:23:38 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/153343 _coding style issues_ WARNING:BRACES: braces {} are not necessary for any arm of this statement #277: FILE: lib/cmdline/cmdline_parse_num.c:168: + if (c == '0') { [...] - else if (c >= '1' && c <= '9') { [...] ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #287: FILE: lib/cmdline/cmdline_parse_num.c:171: } + else { WARNING:BRACES: braces {} are not necessary for single statement blocks #287: FILE: lib/cmdline/cmdline_parse_num.c:171: + else { st = ERROR; } WARNING:BRACES: braces {} are not necessary for any arm of this statement #297: FILE: lib/cmdline/cmdline_parse_num.c:177: + if (c == 'b') { [...] - else if (c >= '0' && c <= '7') { [...] WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'? #441: FILE: lib/cmdline/cmdline_parse_num.c:223: + unsigned ressize) WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #441: FILE: lib/cmdline/cmdline_parse_num.c:223: + unsigned ressize) WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'? #455: FILE: lib/cmdline/cmdline_parse_num.c:237: + if (check_res_size(&nd, ressize) < 0) ERROR:TRAILING_STATEMENTS: trailing statements should be on next line #505: FILE: lib/cmdline/cmdline_parse_num.c:267: + if (res) *(uint8_t *)res = (uint8_t)uintres; ERROR:TRAILING_STATEMENTS: trailing statements should be on next line #508: FILE: lib/cmdline/cmdline_parse_num.c:270: + if (res) *(uint16_t *)res = (uint16_t)uintres; ERROR:TRAILING_STATEMENTS: trailing statements should be on next line #511: FILE: lib/cmdline/cmdline_parse_num.c:273: + if (res) *(uint32_t *)res = (uint32_t)uintres; ERROR:TRAILING_STATEMENTS: trailing statements should be on next line #514: FILE: lib/cmdline/cmdline_parse_num.c:276: + if (res) *(uint64_t *)res = uintres; ERROR:TRAILING_STATEMENTS: trailing statements should be on next line #517: FILE: lib/cmdline/cmdline_parse_num.c:279: + if (res) *(int8_t *)res = (int8_t)uintres; ERROR:TRAILING_STATEMENTS: trailing statements should be on next line #520: FILE: lib/cmdline/cmdline_parse_num.c:282: + if (res) *(int16_t *)res = (int16_t)uintres; ERROR:TRAILING_STATEMENTS: trailing statements should be on next line #523: FILE: lib/cmdline/cmdline_parse_num.c:285: + if (res) *(int32_t *)res = (int32_t)uintres; ERROR:TRAILING_STATEMENTS: trailing statements should be on next line #526: FILE: lib/cmdline/cmdline_parse_num.c:288: + if (res) *(int64_t *)res = (int64_t)uintres; total: 9 errors, 6 warnings, 432 lines checked