From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Anatoly Burakov <anatoly.burakov@intel.com>
Subject: |WARNING| pw153354 [PATCH v6 2/3] cmdline: add floating point support
Date: Thu, 8 May 2025 11:54:52 +0200 (CEST) [thread overview]
Message-ID: <20250508095452.902AC123FBC@dpdk.org> (raw)
In-Reply-To: <390f20f37216cfbb94f25f03e0f6d03cefa059f8.1746698010.git.anatoly.burakov@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/153354
_coding style issues_
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#123: FILE: app/test/test_cmdline_num.c:29:
+ const char * str;
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#361: FILE: app/test/test_cmdline_num.c:606:
+ ret = cmdline_parse_num((cmdline_parse_token_hdr_t*)&token,
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#362: FILE: app/test/test_cmdline_num.c:607:
+ float_invalid_strs[i], (void*)&result, sizeof(result));
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#365: FILE: app/test/test_cmdline_num.c:610:
+ cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token,
ERROR:CODE_INDENT: code indent should use tabs where possible
#398: FILE: app/test/test_cmdline_num.c:675:
+ ^I^I^Iret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#398: FILE: app/test/test_cmdline_num.c:675:
+ ^I^I^Iret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#398: FILE: app/test/test_cmdline_num.c:675:
+ ^I^I^Iret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,$
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#398: FILE: app/test/test_cmdline_num.c:675:
+ ret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#417: FILE: app/test/test_cmdline_num.c:722:
+ cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token,
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#420: FILE: app/test/test_cmdline_num.c:725:
+ ret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#422: FILE: app/test/test_cmdline_num.c:727:
+ (void*)&result, sizeof(result));
WARNING:LONG_LINE_COMMENT: line length of 105 exceeds 100 columns
#424: FILE: app/test/test_cmdline_num.c:729:
+ /* if it should have passed but didn't, or if it should have failed but didn't */
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#462: FILE: app/test/test_cmdline_num.c:836:
+ cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token,
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#465: FILE: app/test/test_cmdline_num.c:839:
+ ret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#467: FILE: app/test/test_cmdline_num.c:841:
+ (void*)&result, sizeof(result));
WARNING:LONG_LINE_COMMENT: line length of 105 exceeds 100 columns
#469: FILE: app/test/test_cmdline_num.c:843:
+ /* if it should have passed but didn't, or if it should have failed but didn't */
WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#470: FILE: app/test/test_cmdline_num.c:844:
+ if ((ret < 0) == (can_parse_float(float_garbage_strs[i].result, type) > 0)) {
WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#476: FILE: app/test/test_cmdline_num.c:850:
+ if (ret > 0 && float_cmp(float_garbage_strs[i].result, &result, type) != 0) {
WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'?
#592: FILE: lib/cmdline/cmdline_parse_num.c:78:
+ if (ressize < sizeof(float))
WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'?
#596: FILE: lib/cmdline/cmdline_parse_num.c:82:
+ if (ressize < sizeof(double))
total: 12 errors, 8 warnings, 547 lines checked
parent reply other threads:[~2025-05-08 9:55 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <390f20f37216cfbb94f25f03e0f6d03cefa059f8.1746698010.git.anatoly.burakov@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250508095452.902AC123FBC@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=anatoly.burakov@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).