From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1555466F4 for ; Thu, 8 May 2025 11:55:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA88D402E7; Thu, 8 May 2025 11:55:09 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 3B6384026B for ; Thu, 8 May 2025 11:55:08 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 902AC123FBC; Thu, 8 May 2025 11:54:52 +0200 (CEST) Subject: |WARNING| pw153354 [PATCH v6 2/3] cmdline: add floating point support In-Reply-To: <390f20f37216cfbb94f25f03e0f6d03cefa059f8.1746698010.git.anatoly.burakov@intel.com> References: <390f20f37216cfbb94f25f03e0f6d03cefa059f8.1746698010.git.anatoly.burakov@intel.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Anatoly Burakov Message-Id: <20250508095452.902AC123FBC@dpdk.org> Date: Thu, 8 May 2025 11:54:52 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/153354 _coding style issues_ ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar" #123: FILE: app/test/test_cmdline_num.c:29: + const char * str; ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #361: FILE: app/test/test_cmdline_num.c:606: + ret = cmdline_parse_num((cmdline_parse_token_hdr_t*)&token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #362: FILE: app/test/test_cmdline_num.c:607: + float_invalid_strs[i], (void*)&result, sizeof(result)); ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #365: FILE: app/test/test_cmdline_num.c:610: + cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token, ERROR:CODE_INDENT: code indent should use tabs where possible #398: FILE: app/test/test_cmdline_num.c:675: + ^I^I^Iret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #398: FILE: app/test/test_cmdline_num.c:675: + ^I^I^Iret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #398: FILE: app/test/test_cmdline_num.c:675: + ^I^I^Iret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,$ ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #398: FILE: app/test/test_cmdline_num.c:675: + ret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #417: FILE: app/test/test_cmdline_num.c:722: + cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #420: FILE: app/test/test_cmdline_num.c:725: + ret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #422: FILE: app/test/test_cmdline_num.c:727: + (void*)&result, sizeof(result)); WARNING:LONG_LINE_COMMENT: line length of 105 exceeds 100 columns #424: FILE: app/test/test_cmdline_num.c:729: + /* if it should have passed but didn't, or if it should have failed but didn't */ ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #462: FILE: app/test/test_cmdline_num.c:836: + cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #465: FILE: app/test/test_cmdline_num.c:839: + ret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #467: FILE: app/test/test_cmdline_num.c:841: + (void*)&result, sizeof(result)); WARNING:LONG_LINE_COMMENT: line length of 105 exceeds 100 columns #469: FILE: app/test/test_cmdline_num.c:843: + /* if it should have passed but didn't, or if it should have failed but didn't */ WARNING:LONG_LINE: line length of 101 exceeds 100 columns #470: FILE: app/test/test_cmdline_num.c:844: + if ((ret < 0) == (can_parse_float(float_garbage_strs[i].result, type) > 0)) { WARNING:LONG_LINE: line length of 101 exceeds 100 columns #476: FILE: app/test/test_cmdline_num.c:850: + if (ret > 0 && float_cmp(float_garbage_strs[i].result, &result, type) != 0) { WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'? #592: FILE: lib/cmdline/cmdline_parse_num.c:78: + if (ressize < sizeof(float)) WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'? #596: FILE: lib/cmdline/cmdline_parse_num.c:82: + if (ressize < sizeof(double)) total: 12 errors, 8 warnings, 547 lines checked