From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Anatoly Burakov <anatoly.burakov@intel.com>
Subject: |WARNING| pw153353 [PATCH v6 1/3] cmdline: use C standard library as number parser
Date: Thu, 8 May 2025 11:54:57 +0200 (CEST) [thread overview]
Message-ID: <20250508095457.F16B9123FBC@dpdk.org> (raw)
In-Reply-To: <19ac627a40341b3095e9148a5254683b73fcc20e.1746698010.git.anatoly.burakov@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/153353
_coding style issues_
WARNING:BRACES: braces {} are not necessary for any arm of this statement
#343: FILE: lib/cmdline/cmdline_parse_num.c:176:
+ if (c == '0') {
[...]
- else if (c >= '1' && c <= '9') {
[...]
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#353: FILE: lib/cmdline/cmdline_parse_num.c:179:
}
+ else {
WARNING:BRACES: braces {} are not necessary for single statement blocks
#353: FILE: lib/cmdline/cmdline_parse_num.c:179:
+ else {
st = ERROR;
}
WARNING:BRACES: braces {} are not necessary for any arm of this statement
#363: FILE: lib/cmdline/cmdline_parse_num.c:185:
+ if (c == 'b') {
[...]
- else if (c >= '0' && c <= '7') {
[...]
WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'?
#567: FILE: lib/cmdline/cmdline_parse_num.c:267:
+ unsigned ressize)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#567: FILE: lib/cmdline/cmdline_parse_num.c:267:
+ unsigned ressize)
WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'?
#580: FILE: lib/cmdline/cmdline_parse_num.c:280:
+ if (res && check_res_size(&nd, ressize) < 0)
total: 1 errors, 6 warnings, 490 lines checked
parent reply other threads:[~2025-05-08 9:55 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <19ac627a40341b3095e9148a5254683b73fcc20e.1746698010.git.anatoly.burakov@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250508095457.F16B9123FBC@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=anatoly.burakov@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).