From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Anatoly Burakov <anatoly.burakov@intel.com>
Subject: |WARNING| pw153357 [PATCH v7 2/3] cmdline: add floating point support
Date: Thu, 8 May 2025 12:01:48 +0200 (CEST) [thread overview]
Message-ID: <20250508100148.90B86123FBC@dpdk.org> (raw)
In-Reply-To: <e80092cfd3ce9f28a3c720a0f0ffca0c511ec0e2.1746698489.git.anatoly.burakov@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/153357
_coding style issues_
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#122: FILE: app/test/test_cmdline_num.c:29:
+ const char * str;
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#362: FILE: app/test/test_cmdline_num.c:608:
+ ret = cmdline_parse_num((cmdline_parse_token_hdr_t*)&token,
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#363: FILE: app/test/test_cmdline_num.c:609:
+ float_invalid_strs[i], (void*)&result, sizeof(result));
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#366: FILE: app/test/test_cmdline_num.c:612:
+ cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token,
ERROR:CODE_INDENT: code indent should use tabs where possible
#399: FILE: app/test/test_cmdline_num.c:677:
+ ^I^I^Iret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,$
WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#399: FILE: app/test/test_cmdline_num.c:677:
+ ^I^I^Iret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#399: FILE: app/test/test_cmdline_num.c:677:
+ ^I^I^Iret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,$
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#399: FILE: app/test/test_cmdline_num.c:677:
+ ret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#418: FILE: app/test/test_cmdline_num.c:724:
+ cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token,
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#421: FILE: app/test/test_cmdline_num.c:727:
+ ret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#423: FILE: app/test/test_cmdline_num.c:729:
+ (void*)&result, sizeof(result));
WARNING:LONG_LINE_COMMENT: line length of 105 exceeds 100 columns
#425: FILE: app/test/test_cmdline_num.c:731:
+ /* if it should have passed but didn't, or if it should have failed but didn't */
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#463: FILE: app/test/test_cmdline_num.c:838:
+ cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token,
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#466: FILE: app/test/test_cmdline_num.c:841:
+ ret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#468: FILE: app/test/test_cmdline_num.c:843:
+ (void*)&result, sizeof(result));
WARNING:LONG_LINE_COMMENT: line length of 105 exceeds 100 columns
#470: FILE: app/test/test_cmdline_num.c:845:
+ /* if it should have passed but didn't, or if it should have failed but didn't */
WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#471: FILE: app/test/test_cmdline_num.c:846:
+ if ((ret < 0) == (can_parse_float(float_garbage_strs[i].result, type) > 0)) {
WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#477: FILE: app/test/test_cmdline_num.c:852:
+ if (ret > 0 && float_cmp(float_garbage_strs[i].result, &result, type) != 0) {
WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'?
#593: FILE: lib/cmdline/cmdline_parse_num.c:78:
+ if (ressize < sizeof(float))
WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'?
#597: FILE: lib/cmdline/cmdline_parse_num.c:82:
+ if (ressize < sizeof(double))
total: 12 errors, 8 warnings, 549 lines checked
parent reply other threads:[~2025-05-08 10:02 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <e80092cfd3ce9f28a3c720a0f0ffca0c511ec0e2.1746698489.git.anatoly.burakov@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250508100148.90B86123FBC@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=anatoly.burakov@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).