From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E3E7F466F4
	for <public@inbox.dpdk.org>; Thu,  8 May 2025 12:02:11 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E04BA40658;
	Thu,  8 May 2025 12:02:11 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id C8C694026B
 for <test-report@dpdk.org>; Thu,  8 May 2025 12:02:10 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 25D87123FBC; Thu,  8 May 2025 12:01:55 +0200 (CEST)
Subject: |WARNING| pw153356 [PATCH v7 1/3] cmdline: use C standard library as
 number parser
In-Reply-To: <19ac627a40341b3095e9148a5254683b73fcc20e.1746698489.git.anatoly.burakov@intel.com>
References: <19ac627a40341b3095e9148a5254683b73fcc20e.1746698489.git.anatoly.burakov@intel.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Anatoly Burakov <anatoly.burakov@intel.com>
Message-Id: <20250508100155.25D87123FBC@dpdk.org>
Date: Thu,  8 May 2025 12:01:55 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/153356

_coding style issues_


WARNING:BRACES: braces {} are not necessary for any arm of this statement
#342: FILE: lib/cmdline/cmdline_parse_num.c:176:
+			if (c == '0') {
[...]
-			else if (c >= '1' && c <= '9') {
[...]

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#352: FILE: lib/cmdline/cmdline_parse_num.c:179:
 			}
+			else {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#352: FILE: lib/cmdline/cmdline_parse_num.c:179:
+			else {
 				st = ERROR;
 			}

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#362: FILE: lib/cmdline/cmdline_parse_num.c:185:
+			if (c == 'b') {
[...]
-			else if (c >= '0' && c <= '7') {
[...]

WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'?
#566: FILE: lib/cmdline/cmdline_parse_num.c:267:
+	unsigned ressize)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#566: FILE: lib/cmdline/cmdline_parse_num.c:267:
+	unsigned ressize)

WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'?
#579: FILE: lib/cmdline/cmdline_parse_num.c:280:
+	if (res && check_res_size(&nd, ressize) < 0)

total: 1 errors, 6 warnings, 490 lines checked