From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56456466F6 for ; Thu, 8 May 2025 15:18:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 520D74026C; Thu, 8 May 2025 15:18:04 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 9C5D64026B for ; Thu, 8 May 2025 15:18:02 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id C5341123FBC; Thu, 8 May 2025 15:17:46 +0200 (CEST) Subject: |WARNING| pw153360 [PATCH v8 2/3] cmdline: add floating point support In-Reply-To: References: To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Anatoly Burakov Message-Id: <20250508131746.C5341123FBC@dpdk.org> Date: Thu, 8 May 2025 15:17:46 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/153360 _coding style issues_ ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar" #132: FILE: app/test/test_cmdline_num.c:29: + const char * str; ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #371: FILE: app/test/test_cmdline_num.c:607: + ret = cmdline_parse_num((cmdline_parse_token_hdr_t*)&token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #372: FILE: app/test/test_cmdline_num.c:608: + float_invalid_strs[i], (void*)&result, sizeof(result)); ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #375: FILE: app/test/test_cmdline_num.c:611: + cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token, ERROR:CODE_INDENT: code indent should use tabs where possible #408: FILE: app/test/test_cmdline_num.c:676: + ^I^I^Iret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #408: FILE: app/test/test_cmdline_num.c:676: + ^I^I^Iret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #408: FILE: app/test/test_cmdline_num.c:676: + ^I^I^Iret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,$ ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #408: FILE: app/test/test_cmdline_num.c:676: + ret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #427: FILE: app/test/test_cmdline_num.c:723: + cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #430: FILE: app/test/test_cmdline_num.c:726: + ret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #432: FILE: app/test/test_cmdline_num.c:728: + (void*)&result, sizeof(result)); WARNING:LONG_LINE_COMMENT: line length of 105 exceeds 100 columns #434: FILE: app/test/test_cmdline_num.c:730: + /* if it should have passed but didn't, or if it should have failed but didn't */ ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #472: FILE: app/test/test_cmdline_num.c:837: + cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #475: FILE: app/test/test_cmdline_num.c:840: + ret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #477: FILE: app/test/test_cmdline_num.c:842: + (void*)&result, sizeof(result)); WARNING:LONG_LINE_COMMENT: line length of 105 exceeds 100 columns #479: FILE: app/test/test_cmdline_num.c:844: + /* if it should have passed but didn't, or if it should have failed but didn't */ WARNING:LONG_LINE: line length of 101 exceeds 100 columns #480: FILE: app/test/test_cmdline_num.c:845: + if ((ret < 0) == (can_parse_float(float_garbage_strs[i].result, type) > 0)) { WARNING:LONG_LINE: line length of 101 exceeds 100 columns #486: FILE: app/test/test_cmdline_num.c:851: + if (ret > 0 && float_cmp(float_garbage_strs[i].result, &result, type) != 0) { WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'? #602: FILE: lib/cmdline/cmdline_parse_num.c:78: + if (ressize < sizeof(float)) WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'? #606: FILE: lib/cmdline/cmdline_parse_num.c:82: + if (ressize < sizeof(double)) total: 12 errors, 8 warnings, 547 lines checked