From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7B4C246700
	for <public@inbox.dpdk.org>; Fri,  9 May 2025 15:41:17 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 76E154025D;
	Fri,  9 May 2025 15:41:17 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 5B5714025A
 for <test-report@dpdk.org>; Fri,  9 May 2025 15:41:16 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 56C35123FBC; Fri,  9 May 2025 15:40:59 +0200 (CEST)
Subject: |WARNING| pw153383 [PATCH v9 1/3] cmdline: use C standard library as
 number parser
In-Reply-To: <9ea91fbec73396343179143e9c3b058148f05c5b.1746797960.git.anatoly.burakov@intel.com>
References: <9ea91fbec73396343179143e9c3b058148f05c5b.1746797960.git.anatoly.burakov@intel.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Anatoly Burakov <anatoly.burakov@intel.com>
Message-Id: <20250509134059.56C35123FBC@dpdk.org>
Date: Fri,  9 May 2025 15:40:59 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/153383

_coding style issues_


ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#373: FILE: lib/cmdline/cmdline_parse_num.c:182:
+			}
+			else {

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#384: FILE: lib/cmdline/cmdline_parse_num.c:188:
+			if (c == '0') {
[...]
-			else  {
[...]

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#388: FILE: lib/cmdline/cmdline_parse_num.c:191:
 			}
+			else {

WARNING:BRACES: braces {} are not necessary for single statement blocks
#388: FILE: lib/cmdline/cmdline_parse_num.c:191:
+			else {
 				st = ERROR;
 			}

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#398: FILE: lib/cmdline/cmdline_parse_num.c:197:
+			if (c == 'b') {
[...]
-			else if (c >= '0' && c <= '7') {
[...]

WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'?
#605: FILE: lib/cmdline/cmdline_parse_num.c:282:
+	unsigned ressize)

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#605: FILE: lib/cmdline/cmdline_parse_num.c:282:
+	unsigned ressize)

WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'?
#618: FILE: lib/cmdline/cmdline_parse_num.c:295:
+	if (res && check_res_size(&nd, ressize) < 0)

total: 2 errors, 6 warnings, 532 lines checked