From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64B3546701 for ; Fri, 9 May 2025 16:43:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 605334025D; Fri, 9 May 2025 16:43:22 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 769CA4025A for ; Fri, 9 May 2025 16:43:20 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 67619123FBC; Fri, 9 May 2025 16:43:03 +0200 (CEST) Subject: |WARNING| pw153387 [PATCH v10 2/3] cmdline: add floating point support In-Reply-To: <677fe4ea84de555b322f34cde26660b07e8faf4c.1746801711.git.anatoly.burakov@intel.com> References: <677fe4ea84de555b322f34cde26660b07e8faf4c.1746801711.git.anatoly.burakov@intel.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Anatoly Burakov Message-Id: <20250509144303.67619123FBC@dpdk.org> Date: Fri, 9 May 2025 16:43:03 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/153387 _coding style issues_ ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar" #131: FILE: app/test/test_cmdline_num.c:29: + const char * str; ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #370: FILE: app/test/test_cmdline_num.c:620: + ret = cmdline_parse_num((cmdline_parse_token_hdr_t*)&token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #371: FILE: app/test/test_cmdline_num.c:621: + float_invalid_strs[i], (void*)&result, sizeof(result)); ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #374: FILE: app/test/test_cmdline_num.c:624: + cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token, ERROR:CODE_INDENT: code indent should use tabs where possible #407: FILE: app/test/test_cmdline_num.c:689: + ^I^I^Iret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #407: FILE: app/test/test_cmdline_num.c:689: + ^I^I^Iret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #407: FILE: app/test/test_cmdline_num.c:689: + ^I^I^Iret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token,$ ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #407: FILE: app/test/test_cmdline_num.c:689: + ret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #426: FILE: app/test/test_cmdline_num.c:736: + cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #429: FILE: app/test/test_cmdline_num.c:739: + ret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #431: FILE: app/test/test_cmdline_num.c:741: + (void*)&result, sizeof(result)); WARNING:LONG_LINE_COMMENT: line length of 105 exceeds 100 columns #433: FILE: app/test/test_cmdline_num.c:743: + /* if it should have passed but didn't, or if it should have failed but didn't */ ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #471: FILE: app/test/test_cmdline_num.c:850: + cmdline_get_help_num((cmdline_parse_token_hdr_t*)&token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #474: FILE: app/test/test_cmdline_num.c:853: + ret = cmdline_parse_num((cmdline_parse_token_hdr_t*) &token, ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)" #476: FILE: app/test/test_cmdline_num.c:855: + (void*)&result, sizeof(result)); WARNING:LONG_LINE_COMMENT: line length of 105 exceeds 100 columns #478: FILE: app/test/test_cmdline_num.c:857: + /* if it should have passed but didn't, or if it should have failed but didn't */ WARNING:LONG_LINE: line length of 101 exceeds 100 columns #479: FILE: app/test/test_cmdline_num.c:858: + if ((ret < 0) == (can_parse_float(float_garbage_strs[i].result, type) > 0)) { WARNING:LONG_LINE: line length of 101 exceeds 100 columns #485: FILE: app/test/test_cmdline_num.c:864: + if (ret > 0 && float_cmp(float_garbage_strs[i].result, &result, type) != 0) { WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'? #601: FILE: lib/cmdline/cmdline_parse_num.c:78: + if (ressize < sizeof(float)) WARNING:TYPO_SPELLING: 'ressize' may be misspelled - perhaps 'resize'? #605: FILE: lib/cmdline/cmdline_parse_num.c:82: + if (ressize < sizeof(double)) total: 12 errors, 8 warnings, 555 lines checked