|WARNING| pw153744 [PATCH 3/3] argparse: use enums to remove max-value defines in lists

[checkpatch@dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/153744

_coding style issues_


WARNING:LONG_LINE: line length of 129 exceeds 100 columns
#107: FILE: app/test/test_argparse.c:82:
+		{ "--abc", "-a", "abc argument", (void *)1, (void *)1, RTE_ARGPARSE_VALUE_NONE, RTE_ARGPARSE_VALUE_TYPE_NONE }, \

WARNING:LONG_LINE: line length of 129 exceeds 100 columns
#108: FILE: app/test/test_argparse.c:83:
+		{ "--xyz", "-x", "xyz argument", (void *)1, (void *)2, RTE_ARGPARSE_VALUE_NONE, RTE_ARGPARSE_VALUE_TYPE_NONE }, \

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#606: FILE: app/test/test_argparse.c:845:
+	ret = rte_argparse_parse_type(bool_numeric_invalid, RTE_ARGPARSE_VALUE_TYPE_BOOL, &val_bool);

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#753: FILE: lib/argparse/rte_argparse.c:36:
+	switch (arg->value_required) {
+		case RTE_ARGPARSE_VALUE_NONE:
+		case RTE_ARGPARSE_VALUE_OPTIONAL:
+		case RTE_ARGPARSE_VALUE_REQUIRED:

ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#770: FILE: lib/argparse/rte_argparse.c:49:
+	switch (arg->value_type) {
+		case RTE_ARGPARSE_VALUE_TYPE_NONE:
+		case RTE_ARGPARSE_VALUE_TYPE_INT:
+		case RTE_ARGPARSE_VALUE_TYPE_U8:
+		case RTE_ARGPARSE_VALUE_TYPE_U16:
+		case RTE_ARGPARSE_VALUE_TYPE_U32:
+		case RTE_ARGPARSE_VALUE_TYPE_U64:
+		case RTE_ARGPARSE_VALUE_TYPE_STR:
+		case RTE_ARGPARSE_VALUE_TYPE_BOOL:

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#965: FILE: lib/argparse/rte_argparse.c:670:
+					ARGPARSE_LOG(ERR, "argument %s doesn't have value!", arg_name);

total: 2 errors, 4 warnings, 954 lines checked