From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: |WARNING| pw159068 [PATCH v3 01/31] eal: add more min/max helpers
Date: Mon, 1 Dec 2025 12:45:32 +0100 (CET) [thread overview]
Message-ID: <20251201114532.B8ED21223DB@dpdk.org> (raw)
In-Reply-To: <20251201114448.1441377-2-bruce.richardson@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/159068
_coding style issues_
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#96: FILE: lib/eal/include/rte_common.h:805:
+#define RTE_MIN3(a, b, c) \
+ __extension__ ({ \
+ typeof (a) _a = (a); \
+ typeof (b) _b = (b); \
+ typeof (c) _c = (c); \
+ _a < _b ? (_a < _c ? _a : _c) \
+ : (_b < _c ? _b : _c); \
+ })
BUT SEE:
do {} while (0) advice is over-stated in a few situations:
The more obvious case is macros, like MODULE_PARM_DESC, invoked at
file-scope, where C disallows code (it must be in functions). See
$exceptions if you have one to add by name.
More troublesome is declarative macros used at top of new scope,
like DECLARE_PER_CPU. These might just compile with a do-while-0
wrapper, but would be incorrect. Most of these are handled by
detecting struct,union,etc declaration primitives in $exceptions.
Theres also macros called inside an if (block), which "return" an
expression. These cannot do-while, and need a ({}) wrapper.
Enjoy this qualification while we work to improve our heuristics.
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#98: FILE: lib/eal/include/rte_common.h:807:
+ typeof (a) _a = (a); \
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#99: FILE: lib/eal/include/rte_common.h:808:
+ typeof (b) _b = (b); \
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#100: FILE: lib/eal/include/rte_common.h:809:
+ typeof (c) _c = (c); \
ERROR:CODE_INDENT: code indent should use tabs where possible
#102: FILE: lib/eal/include/rte_common.h:811:
+^I^I : (_b < _c ? _b : _c); \$
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#116: FILE: lib/eal/include/rte_common.h:830:
+ typeof (a) _ax = (a); \
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#117: FILE: lib/eal/include/rte_common.h:831:
+ typeof (b) _bx = (b); \
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#124: FILE: lib/eal/include/rte_common.h:838:
+#define RTE_MAX3(a, b, c) \
+ __extension__ ({ \
+ typeof (a) _a = (a); \
+ typeof (b) _b = (b); \
+ typeof (c) _c = (c); \
+ _a > _b ? (_a > _c ? _a : _c) \
+ : (_b > _c ? _b : _c); \
})
BUT SEE:
do {} while (0) advice is over-stated in a few situations:
The more obvious case is macros, like MODULE_PARM_DESC, invoked at
file-scope, where C disallows code (it must be in functions). See
$exceptions if you have one to add by name.
More troublesome is declarative macros used at top of new scope,
like DECLARE_PER_CPU. These might just compile with a do-while-0
wrapper, but would be incorrect. Most of these are handled by
detecting struct,union,etc declaration primitives in $exceptions.
Theres also macros called inside an if (block), which "return" an
expression. These cannot do-while, and need a ({}) wrapper.
Enjoy this qualification while we work to improve our heuristics.
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#126: FILE: lib/eal/include/rte_common.h:840:
+ typeof (a) _a = (a); \
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#127: FILE: lib/eal/include/rte_common.h:841:
+ typeof (b) _b = (b); \
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#128: FILE: lib/eal/include/rte_common.h:842:
+ typeof (c) _c = (c); \
ERROR:CODE_INDENT: code indent should use tabs where possible
#130: FILE: lib/eal/include/rte_common.h:844:
+^I^I : (_b > _c ? _b : _c); \$
total: 4 errors, 8 warnings, 43 lines checked
parent reply other threads:[~2025-12-01 11:46 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20251201114448.1441377-2-bruce.richardson@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251201114532.B8ED21223DB@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=bruce.richardson@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).