From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8C714705A for ; Tue, 16 Dec 2025 17:12:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E4B00402DE; Tue, 16 Dec 2025 17:12:11 +0100 (CET) Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) by mails.dpdk.org (Postfix) with ESMTP id D13EE4026D for ; Tue, 16 Dec 2025 17:12:10 +0100 (CET) Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-88a26ce6619so34772496d6.3 for ; Tue, 16 Dec 2025 08:12:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytheb-org.20230601.gappssmtp.com; s=20230601; t=1765901530; x=1766506330; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Ehu658y/Ze0U7XjvMYVr/3/fUHqjc3wS+y9SMKFXTEw=; b=F8GcfCBUuHLpyIr3rWG20d+YCg+hye+H+0YVifa6m/UeyWAZmt61bNMy/YdcdoyBMI Hhpeq2vXeMTcGb0ClJImohkjtIr8gCFRtrlZahbYTBfetHUU+rw7H8fKzgIg3TIwcHUN t/Id62HNJAAaXd+R7dpl1ycHYPtsZZdl0DjeQYuaQ6Kll4jED0Z7IbXS7ubAfXrqEKk7 vbAqZuR0O5ZifQenZ2JZjj6rwDqNdJahgFDrRblkcmn164rFG7u6/aSsImwv+VXiPyIJ TGDoLVTfknjS2fAIblhPP16zxLZDBWr0VlxW2h0nN09e1DGcjs5afwio50rXbi9V/iKL cfKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765901530; x=1766506330; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Ehu658y/Ze0U7XjvMYVr/3/fUHqjc3wS+y9SMKFXTEw=; b=tuMbpyI3UHxFGTjl3pYzqEZMiYRTaDHAO+P3jIhBHomva+l8ieFkhZYi4orcMbkHbx SmKw2ZFaCpXpSELzeOiojUpeni7OCZcRp39C/db6UMerjgmlpNUV2JauI2dT6+F3j3dm XUu/oL3HoVNDP69o6EiQKV8QYNMTm9MyjvhnNlczlQmO/yRYJAH5ENkmk+9oKi7Q487H o7FXrICTqFgb0EzvXTKPTZ9zHXkbVOoBapF3WcT54p4xs+PYoelo209QOsF+cAFtez+I UM5KYb02Wu64VxI75cnddHiqKxv3L9JlMMhgaRKYIes2iZYx9wG9AH917tRVxy3Qe/HL Uc8w== X-Gm-Message-State: AOJu0Yxq+dq8hOjSm2Enn2Yxntauw/PHa90ujn0EYYyi0J5JQ6UkqDPM AFt19rrr0vPN27jtICuHSf0JtuWZH4KV9iJlO7aSy1bBLfBP6S+mVRkNja2/Qe0E5colDTN+7uf xIaUe X-Gm-Gg: AY/fxX7mScIVqpVpPte0Xygima2GNBq4Z/xUlaZvNRSD0PGd5x2qDK1/81Z9NGIX3Xp SJ5Hnw81HAM+1+UOkjdUdHdCYtP98rA77G3YItPyi8QEie0QVdLjLUAJZtJTp4Er7xWsn6YAu0m 76ViI9ivJ2SJF5L3Zm0jHjW7NBWfxuGqqzWAPNCK1dPSynK1sCoRqv3V1jNRwOkwsW35RqJvH3J 2KSB+GU0kPlb7osYKOfHUekJHmyXkchZxoXk8dyiipIOGtbnx2yIvN1ualS6DFvBja4zrqeAhGH 3ZgvcXvxiuP4k4323b4U4kzPhe9YcqkLvmfc+P5qMC+bfqLmiml1BKChw8qnbxD93YwSU1u1nya RFpXgF+7cU+KfgIlq80TBsH8uxIkh+vp3UJVcYWKr6rJp2OVjXaxPiaHlgN191DKANDehUJeEHN iq1bOAT6aQm5eLjbSY4g== X-Google-Smtp-Source: AGHT+IG2PQbKs7JP7znm15vHuq4pQ36wx3edvblNYSY+MoOOKlyRnEudjlS9DuWWJPpYkuw7suEVpw== X-Received: by 2002:a05:6214:5548:b0:888:60c4:29cf with SMTP id 6a1803df08f44-8887e19d672mr242421766d6.68.1765901529884; Tue, 16 Dec 2025 08:12:09 -0800 (PST) Received: from RHTRH0061144.redhat.com ([47.14.5.10]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8899eb2a469sm77071576d6.29.2025.12.16.08.12.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 08:12:08 -0800 (PST) From: 0-day Robot To: test-report@dpdk.org, Stephen Hemminger Subject: |SUCCESS| pw159216 [PATCH v5 05/17] latencystats: add check for string overflow Date: Tue, 16 Dec 2025 11:12:07 -0500 Message-ID: <20251216161207.762498-1-robot@bytheb.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251207191242.165619-6-stephen@networkplumber.org> References: <20251205022948.327743-1-stephen@networkplumber.org> <20251207191242.165619-1-stephen@networkplumber.org> <20251207191242.165619-6-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: 0day Robot - Claude SONNET Test-Status: SUCCESS http://dpdk.org/patch/159216 _AI Review Comments Available_ Git SHA: 20251207191242.165619-6-stephen@networkplumber.org Author: Stephen Hemminger Subject: latencystats: add check for string overflow This patch adds a check to detect if latency statistic names are too long to fit in the metric name buffer, logging a warning if truncation occurs. > diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c > index f61d5a273f..0861d00c6b 100644 > --- a/lib/latencystats/rte_latencystats.c > +++ b/lib/latencystats/rte_latencystats.c > @@ -405,9 +405,12 @@ rte_latencystats_get_names(struct rte_metric_name *names, uint16_t size) > if (names == NULL || size < NUM_LATENCY_STATS) > return NUM_LATENCY_STATS; > > - for (i = 0; i < NUM_LATENCY_STATS; i++) > - strlcpy(names[i].name, lat_stats_strings[i].name, > - sizeof(names[i].name)); > + for (i = 0; i < NUM_LATENCY_STATS; i++) { > + if (strlcpy(names[i].name, lat_stats_strings[i].name, sizeof(names[0].name)) > + >= sizeof(names[0].name)) > + LATENCY_STATS_LOG(NOTICE, "Latency metric '%s' too long", > + lat_stats_strings[i].name); > + } Why does this code use sizeof(names[0].name) instead of sizeof(names[i].name)? The logic accesses names[i] but sizes using names[0]. Does the array contain differently sized name fields? The coding style guidelines indicate that wrapped function arguments should be aligned. Can the strlcpy call follow DPDK alignment rules? > > return NUM_LATENCY_STATS; > }