From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DE6C4705A for ; Tue, 16 Dec 2025 17:12:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 139E2402DE; Tue, 16 Dec 2025 17:12:20 +0100 (CET) Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by mails.dpdk.org (Postfix) with ESMTP id B7B214026D for ; Tue, 16 Dec 2025 17:12:15 +0100 (CET) Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-8b2627269d5so486602985a.2 for ; Tue, 16 Dec 2025 08:12:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytheb-org.20230601.gappssmtp.com; s=20230601; t=1765901535; x=1766506335; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=l8hgMVbF1SjC25UcbYUK+nybIwpPbAyh6Uz8DhxrExU=; b=xtKmPV643D9iv3jtbTn2ecRWPS0QItIuHTiLYseZxiJeFJzLjVLp88NjzyjufnBTR3 haBKeNp3dlbSx0uC1pdRw4vKKIhT7iNw0pZfYTFwJubBsDZ7ul+kZwc/yc20mWUzeePW J0+CPINlPrFM/3lDOebikgayYIQlcl1MMEv8LEAxpz3h+jlxcGlfGyBTwlWY6K7FCECY Ug+Di+YHvHrgEhOtEgWV0dDzGkY+SfaGAoq2vaDrWJbx5VDtjx0TavkL2GQa41PmzMiw TG06ytuVDj8eVqNdqUFYMMkYGCzEDe4wwbG7r6++IYB8+KLwlM61U/XJehH+ngy9QKvT xTIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765901535; x=1766506335; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=l8hgMVbF1SjC25UcbYUK+nybIwpPbAyh6Uz8DhxrExU=; b=UIIafkfn6lcqSTyhbMKhjNBKzBsmxjNtUiu9bl2ROBL76SUO59TPj9BbN3JkNqXEMy /K5DC0jsHvTMX2+4SvLpoKAAz77fSxHWRc0zxGDAbEKxPnR5Ye5juobuLk5jpdfC0ZDc KKZjIh4eHDTJabe1spGfjLe9UHnsxTpOSZq58IFL7zwHWiEGUGXj6FeXV6J5E2BAkj5z K86kV4gtRGKGRZzLzktnbjL3sW0IV87x4nS7yhn4B0gd4DTbSpaqechK4CBnUxlXouhf 6Jn4k2S+oJzeh0Jq/MNF8fSfHMPaRH4bZGlyYSuTF+vG56M/ctKtKkdUJNFZNSCCNFQ/ i/vw== X-Gm-Message-State: AOJu0Yx0EwoMJbqkh4L/4enC0DFu0uQOtDkArkEJ+khHAqKTz2VbKgGJ O3dtNtc1qXRX8dc20+CVD/oLigHg66MD7XB99+2xCqZ30V7z5w6xRQ8fky6ApUFXYfi5rc4XMSi xiT4R X-Gm-Gg: AY/fxX4gGrqggWnE/+LqauTn9yhizEU2SnuCiv5DBVwKonws7aAyjo9yq3ZpvDMc/6f ziKHQ6HJ7E07pkaJmIs17eXTpUXELskuAN79l/ovBfFXqexfbcM3v7OY17U1KqkR6ePBWZMCprz KyRB16yatf426V8XAJA84uq9sz+VlONnTspXSeROZJnveD2NP0jBYk7bjcRucl4QDPTJUbezFdZ dskmJ+6FNah8jT4rgl/EH/9FcH3FMh0kQhTEfFhmflw9Cc7eH4Mv3zrmWdHYYkxoKi8E6JhKnTM 0WToDrG2ARpGueujqtfp2WZAgUElA/rtXzXfzxWxehi4vpCjg/wgFM01UuiCU5rbhVGTqYiAx5X 89ohNtTNsRBdZ2Zy3fGeNnuG5fHpsZ64aqHCowXbxQssPF4motiXj0ARQiJ7i4X87gbrvGwqGRT vtwiFI+5W+jKeUZn02KTnTfKx9/jEx X-Google-Smtp-Source: AGHT+IEoTkbxvkSCnNOryG1Utle4DtKqodLbc8Qr2R3oKjfC6Y0CjwkRXFvM9YHBkWYW4LoLVs0xRA== X-Received: by 2002:a05:620a:46a2:b0:8a2:45ba:1b5e with SMTP id af79cd13be357-8bb39faf6bbmr2136567685a.28.1765901534479; Tue, 16 Dec 2025 08:12:14 -0800 (PST) Received: from RHTRH0061144.redhat.com ([47.14.5.10]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8be303e7dd8sm218166685a.9.2025.12.16.08.12.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 08:12:13 -0800 (PST) From: 0-day Robot To: test-report@dpdk.org, Stephen Hemminger Subject: |SUCCESS| pw159218 [PATCH v5 07/17] efd: handle possible name truncation Date: Tue, 16 Dec 2025 11:12:12 -0500 Message-ID: <20251216161212.762520-1-robot@bytheb.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251207191242.165619-8-stephen@networkplumber.org> References: <20251205022948.327743-1-stephen@networkplumber.org> <20251207191242.165619-1-stephen@networkplumber.org> <20251207191242.165619-8-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: 0day Robot - Claude SONNET Test-Status: SUCCESS http://dpdk.org/patch/159218 _AI Review Comments Available_ git sha: [Cannot determine from patch format] Author: Stephen Hemminger efd: handle possible name truncation This commit adds checking for name truncation when converting EFD names to ring names and improves error logging when ring creation fails. > diff --git a/lib/efd/rte_efd.c b/lib/efd/rte_efd.c > index ebf1e0655f..ed2c509938 100644 > --- a/lib/efd/rte_efd.c > +++ b/lib/efd/rte_efd.c > @@ -698,12 +698,15 @@ rte_efd_create(const char *name, uint32_t max_num_rules, uint32_t key_len, > TAILQ_INSERT_TAIL(efd_list, te, next); > rte_mcfg_tailq_write_unlock(); > > - snprintf(ring_name, sizeof(ring_name), "HT_%s", table->name); > + if (snprintf(ring_name, sizeof(ring_name), "HT_%s", table->name) > + >= (int)sizeof(ring_name)) > + EFD_LOG(NOTICE, "EFD ring name truncated to '%s'", ring_name); Can this truncation lead to ring name collisions? If two EFD tables have very long names that differ only in their endings, they might result in identical truncated ring names after adding the "HT_" prefix. The code checks for truncation in rte_efd_create() but continues execution even when truncation occurs, which could cause rte_ring_create() to fail with EEXIST if another ring with the same truncated name already exists. > + > /* Create ring (Dummy slot index is not enqueued) */ > r = rte_ring_create(ring_name, rte_align32pow2(table->max_num_rules), > offline_cpu_socket, 0); > if (r == NULL) { > - EFD_LOG(ERR, "memory allocation failed"); > + EFD_LOG(ERR, "ring creation failed: %s", rte_strerror(rte_errno)); > rte_efd_free(table); > return NULL; > }