From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 353284705A for ; Tue, 16 Dec 2025 17:12:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 259A6402EB; Tue, 16 Dec 2025 17:12:20 +0100 (CET) Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) by mails.dpdk.org (Postfix) with ESMTP id CF4FF4026D for ; Tue, 16 Dec 2025 17:12:17 +0100 (CET) Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-8888546d570so22658286d6.2 for ; Tue, 16 Dec 2025 08:12:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytheb-org.20230601.gappssmtp.com; s=20230601; t=1765901537; x=1766506337; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=j0etA7eggeRV6eIYGJydPkdhM8lEQhv9I6GLJqErVWA=; b=AYPtWOi6r3BjNsQDiKj+rCYI1MtclY+1XFNvYpI6SFvhPkS4XVu8XmwECwCoVT0NRR fUvw6FcSU53gDvlwcM/FSXFC2aHmNpBIYVVgfaXDOvhTHV26hziLyjaMLMW0T6npQOf1 Q+GKfQtv15JoRdphq+zePYVsQTZOOX5bZNDw2uunipKW06sIBM862RP7EbGOtipiEyEC OSvSBrGvuPhH4bRr74j8MqeytO/GT0NYZobz0LLNfiWS90sTgCl7t/PpTvSHGoE9rhWa cXgrO+iPDDsqkCftjyWaWQW2Y5gWwgYsduicVrydUKGU6rBlK9xLDghRnO1MZVSxgiJK iZuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765901537; x=1766506337; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=j0etA7eggeRV6eIYGJydPkdhM8lEQhv9I6GLJqErVWA=; b=MFfZ4P7IbGuUYq9IVlkaEaRHoqlJ1UlaVCR1nkgfDxqVcGNSwzqMkqzKpCIBZlgTK4 iYVYbmQU7C9umHfQTWejF2O6z+IuJrEnSoedBv+0gbycgAGWhmsbZWY+ojTeueE5VkF/ BG6CEAurQvOFGI75UrLgicx5OJ6EJ8x//zAvh3doXgHlogan+pq4EbK4REWVWqvfRQNB cvLueYzgirKEXU7FGg+LwRCDKh9bozx2Q0DkpcqdkkEhh1x2Isa4YgxTnumcwG3ZsaiA JlFqvJGoCoAHRNQ8heJjRKtq5xfogdzm8sj+ehK5c+SQzi1KuD49TIRuoOWg3blEoev9 7OuQ== X-Gm-Message-State: AOJu0YzcA5qftQX2wYauqLFGzPtTyihIndlitaNcm3Fl7TtmckYefuHc 92nM1QmV8AI0NV2qJSPVteE+OoKcsJoDT38kykaAkEnoWquQ2xT4eB7gDVpEFt4aRUGd5T4PNAd rCjty X-Gm-Gg: AY/fxX7OP2bxjqi75reU176XxAbVBdif8BurbcFkJfKWhMxOBKEgQm/wr94/5oyGRQu DOMCUKdFQ+S7AEHlrq2cXkgrjPvWAyfmlevnaaLwa+61mMoHhnkJ3YAVqTicCOjqn+h0wgGpCUi vXPmna5Mq6NqIW8QQBZbhjYVw46fWir+fbEfIlHGnQGjb0w5z1FR/BtlfdngwbbbHjt4/NYoqna 5bBmFz5N3yxOvVPySU2Po0KlFSKKwpLfbIR+zimfMhhyJUKO/0C71qtU7sZC+5ukWCcnQd/FZ35 MWRJoJGkHmJgcWxwsb+DTO7dxXZa0mfoLrIcZkqj/+4vEj1OP7dMqBnYWeic/9A2iOZvhl+KlnN A8WUZ5bXypzjxhc9zABy7B+UKwBOXm1TBtc4MSjTHzijPvrFGN/kP6pl1ypjPVIUu0P0lTtGzPg KtAsEncyhI2t9w2A9MRQ== X-Google-Smtp-Source: AGHT+IFfHyF/724ejh4U62dwUKA25+0ujTVV8pQXRzl/jBv60szICOCjh8R5Q5JGj0QuGTEKaSbhOg== X-Received: by 2002:a05:6214:1309:b0:888:1f18:7a0a with SMTP id 6a1803df08f44-8887e01e6cfmr250125366d6.23.1765901536625; Tue, 16 Dec 2025 08:12:16 -0800 (PST) Received: from RHTRH0061144.redhat.com ([47.14.5.10]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-889a85ebf01sm76888066d6.47.2025.12.16.08.12.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 08:12:16 -0800 (PST) From: 0-day Robot To: test-report@dpdk.org, Stephen Hemminger Subject: |SUCCESS| pw169219 [PATCH v5 08/17] eal: warn if thread name is truncated Date: Tue, 16 Dec 2025 11:12:14 -0500 Message-ID: <20251216161214.762541-1-robot@bytheb.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251207191242.165619-9-stephen@networkplumber.org> References: <20251205022948.327743-1-stephen@networkplumber.org> <20251207191242.165619-1-stephen@networkplumber.org> <20251207191242.165619-9-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: 0day Robot - Claude SONNET Test-Status: SUCCESS http://dpdk.org/patch/159219 _AI Review Comments Available_ Looking at this patch, I have a few questions about the consistency and implementation of the thread name truncation handling. Git SHA: 20251207191242.165619-9-stephen@networkplumber.org Author: Stephen Hemminger Subject: eal: warn if thread name is truncated This patch adds warning messages when thread names get truncated due to length limits, specifically for the dpdk-worker-%d pattern that can overflow with more than 9999 worker cores. > diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c > index 6215245ad5..beda7e0c5c 100644 > --- a/lib/eal/freebsd/eal.c > +++ b/lib/eal/freebsd/eal.c > @@ -690,8 +690,10 @@ rte_eal_init(int argc, char **argv) > rte_panic("Cannot create thread\n"); > > /* Set thread_name for aid in debugging. */ > - snprintf(thread_name, sizeof(thread_name), > - "dpdk-worker%d", i); > + ret = snprintf(thread_name, sizeof(thread_name), "dpdk-worker%d", i); > + if (ret >= (int)sizeof(thread_name)) > + EAL_LOG(INFO, "Worker thread name %s truncated", thread_name); > + > rte_thread_set_name(lcore_config[i].thread_id, thread_name); [ ... ] > diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c > index b12f325ddd..d848de03d8 100644 > --- a/lib/eal/linux/eal.c > +++ b/lib/eal/linux/eal.c > @@ -863,8 +863,10 @@ rte_eal_init(int argc, char **argv) > rte_panic("Cannot create thread\n"); > > /* Set thread_name for aid in debugging. */ > - snprintf(thread_name, sizeof(thread_name), > - "dpdk-worker%d", i); > + ret = snprintf(thread_name, sizeof(thread_name), "dpdk-worker%d", i); > + if (ret >= RTE_THREAD_NAME_SIZE) > + EAL_LOG(INFO, "Worker thread name %s truncated", thread_name); > + > rte_thread_set_name(lcore_config[i].thread_id, thread_name); [ ... ] > diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c > index 21fe7cb1d9..8b539f8601 100644 > --- a/lib/eal/windows/eal.c > +++ b/lib/eal/windows/eal.c > @@ -378,8 +378,10 @@ rte_eal_init(int argc, char **argv) > rte_panic("Cannot create thread\n"); > > /* Set thread name for aid in debugging. */ > - snprintf(thread_name, sizeof(thread_name), > - "dpdk-worker%d", i); > + ret = snprintf(thread_name, sizeof(thread_name), "dpdk-worker%d", i); > + if (ret >= (int)sizeof(thread_name)) > + EAL_LOG(INFO, "Worker thread name %s truncated", thread_name); > + > rte_thread_set_name(lcore_config[i].thread_id, thread_name); Why does the Linux implementation check against RTE_THREAD_NAME_SIZE while FreeBSD and Windows use sizeof(thread_name)? Should all platforms use the same constant for consistency? Does the logic make sense to log thread_name after truncation? The logged name will already be truncated, so it won't show what the intended full name was supposed to be. Could this create confusion in debugging since you're logging the truncated name rather than the original intended name?