From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3842A4705A for ; Tue, 16 Dec 2025 17:12:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3241D4026D; Tue, 16 Dec 2025 17:12:29 +0100 (CET) Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) by mails.dpdk.org (Postfix) with ESMTP id CC9E34026D for ; Tue, 16 Dec 2025 17:12:21 +0100 (CET) Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-8b2d32b9777so704423885a.2 for ; Tue, 16 Dec 2025 08:12:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytheb-org.20230601.gappssmtp.com; s=20230601; t=1765901541; x=1766506341; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=5emY50cpMQIy1q6PPg2Ad1Hb4RTL7rkUGUTRHxHWXKY=; b=HcMoSbSTW60cePEm1VMA3av/+wQ3sLCfSlsBpvE/xInHfh5ObrUI1MmNwSQ9jDSFIW QyJrgHYqXlKADYilx9duoLCI0qffrXuWYbUNgRXHwQQTji/wjruViXI8Al8Bmno9RrBe ZEBh3L0BDqO+Yv/xq1tNAT3OA6YT0lPKj3BQq/fFPogXRGMR+lcxLdKxL7jz0MYSD1rc vix67ojYJaaRuDHbBVCJW50ziuJWnEYJs+4YO4pKvTWc9M2TaH7VAmPYSIZcNxMJlXMu 6PYbjiSQS03vYpThUVdYVrU3u48izp9c22hoC3miTZ6vU7AjBIQ5X2s/Xgh4BVTw6PRS AeLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765901541; x=1766506341; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=5emY50cpMQIy1q6PPg2Ad1Hb4RTL7rkUGUTRHxHWXKY=; b=Uy5SStgcmnsDyhjaaMm/QuO+2XckZShBHMs4HANNHE8+1d9vobEtCVt2EGPPRhKEo8 WQQANLehGqMLYvTkldxub1HQ4S16angWqZrCYcGZotCso8FVJOzmAsTaLwXeuWmLtAe9 HHkJYlKyMH6U75C8z5ps42pKnytCOWRLBVkeJ8xyxDvNuBtZF6u/cSC2tjBHQvbvgln9 lvrI7Z319HlkP4dRMNH2D5ifzVoEWldJA6lLm53pXPsU0wP1NUtgHWc1JWtTGaMxyoHx sUJ8ovhsmwxy8zFDWw5jrReQ6X2R5VTRk3LgFg3Om8/okWzJEJEGooQNILAWvcQcD58q 7qWw== X-Gm-Message-State: AOJu0Yz1f/ORlbUnzuFVTFaIawyR6/hPSuF31o7ftdvdMBcLEWx0UR+w pdx4gvlj8ldkfEmD/mermNqHg1rB8LrIDy225HOmHYxxQxDLgLXSiJlUCmnncvBbFDsX5MJJIK7 gUxJe X-Gm-Gg: AY/fxX64qQDKPviuKNpeNwb8s63KFqwi9nynwobnAbQ0HBzvjNuDiJjHIyh01tULaV8 Ih6VmAK+hnKNrWY10n53kAhqoFoSKL0z9e87WYpdkzt2Kfi5d9uXN59QZBDUY16virje4D25/lq 1DxyMdhWXFClGDqtQ/HwcjSwjs+UM/X3/3hVZaaXHBDY+/f1OPFxr1KEPJ+UslknV8uI+1FRrYd ZKF4coYpv3YJAqD9vFvUPS9Rs/7BvWnrDFQGJa9bweaxb2LeFzqtN/6xiEtnsduiJ759P937F1m yzBhEHYQ0XOfq40BV7pipwjCKalEmoLmtqZG2k8qsVg6Pc4F1FNJeEb1bndCBVXK8urtqPTNFSJ NdkTWq1Hfv6STjOsdOsW98eJxkWpyUpC4rU1+Uo9Z9shFW9TnhJvgo4JUD53PzRQAWSjNfCU6p3 FpZ2pNv3WhHCSgMB41jg== X-Google-Smtp-Source: AGHT+IHMsfjm/DkRwZx+2+kQm7QqtL5hztMOB3qD+EZXyjpOIpIo54XFPeT3TjO1Dxv1CCakIrJpXg== X-Received: by 2002:a05:620a:2a04:b0:8b2:9b48:6052 with SMTP id af79cd13be357-8bb3a3903d0mr1891155085a.84.1765901539066; Tue, 16 Dec 2025 08:12:19 -0800 (PST) Received: from RHTRH0061144.redhat.com ([47.14.5.10]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8be31b52abbsm213753885a.35.2025.12.16.08.12.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 08:12:18 -0800 (PST) From: 0-day Robot To: test-report@dpdk.org, Stephen Hemminger Subject: |SUCCESS| pw159220 [PATCH v5 09/17] eal: avoid format overflow when handling addresses Date: Tue, 16 Dec 2025 11:12:17 -0500 Message-ID: <20251216161217.762552-1-robot@bytheb.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251207191242.165619-10-stephen@networkplumber.org> References: <20251205022948.327743-1-stephen@networkplumber.org> <20251207191242.165619-1-stephen@networkplumber.org> <20251207191242.165619-10-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: 0day Robot - Claude SONNET Test-Status: SUCCESS http://dpdk.org/patch/159220 _AI Review Comments Available_ I need to generate the complete unified diff for this commit. Let me call the commit function to get the full diff. ```bash git show --no-merges --format=fuller c62edf5e55..HEAD -- lib/eal/common/eal_common_memory.c ``` Let me get the proper git sha and commit details for this patch: ```bash git log --oneline -1 --grep="eal: avoid format overflow when handling addresses" ``` Since I need to review the patch as provided, let me analyze what's available: **Git SHA:** Not provided in patch (needs to be obtained) **Author:** Stephen Hemminger **Subject:** eal: avoid format overflow when handling addresses **Summary:** This commit increases the ADDR_STR buffer size from 15 to 20 characters to prevent overflow when formatting 64-bit addresses as hex strings, noting that the largest possible value 0xFFFFFFFFFFFFFFFF would overflow the original 15-character buffer. > diff --git a/lib/eal/common/eal_common_memory.c b/lib/eal/common/eal_common_memory.c > index c62edf5e55..2633857db5 100644 > --- a/lib/eal/common/eal_common_memory.c > +++ b/lib/eal/common/eal_common_memory.c > @@ -1153,7 +1153,7 @@ rte_eal_memory_init(void) > #define EAL_MEMSEG_INFO_REQ "/eal/memseg_info" > #define EAL_ELEMENT_LIST_REQ "/eal/mem_element_list" > #define EAL_ELEMENT_INFO_REQ "/eal/mem_element_info" > -#define ADDR_STR 15 > +#define ADDR_STR 20 /* 16 bytes 64 bit + 0x */ Does the comment accurately describe the buffer requirements? A 64-bit value formatted as hex with "0x" prefix requires exactly 18 characters (2 for "0x" + 16 for hex digits), plus 1 for null terminator equals 19 characters minimum. While 20 provides a small safety margin, would it be clearer to size this as exactly what's needed or document why the extra byte is included?