From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 443284705A for ; Tue, 16 Dec 2025 17:12:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E56A402DE; Tue, 16 Dec 2025 17:12:29 +0100 (CET) Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) by mails.dpdk.org (Postfix) with ESMTP id 8151E4026D for ; Tue, 16 Dec 2025 17:12:22 +0100 (CET) Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-88a22eb38edso22368796d6.2 for ; Tue, 16 Dec 2025 08:12:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytheb-org.20230601.gappssmtp.com; s=20230601; t=1765901541; x=1766506341; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=r0/8G+ZcWTO+kenV7LPyPJmReW0DRv9RwtxhB8rfOeA=; b=ExaSqK5VjB5IxHW9cUKs++m5ipvjp+94+6vQ8tuwHotAwme9NvEiT0bXyCyeJKEsVV uvC8M6f1xtAufsS4mRxMEohSPDYSnPoI3YkWA+51aMQAYAasr8ZiJgZBorSBHO0fxWPt o3UpX+CovX/AlABvXPA4rqjZ2+KDuaUY8D7mxxtOPWQIWEqjDrCWOSycru4QQGaqbQ/Y S4zSypriwiEKM2weeohVmhXBDTrfUqcz8alY3gQCOMiVdqgeh4tIKL1tjmEfe+6NMFl0 ujtvPhlpKhRUFErq7y3kIvvvioqu3BL0MA5cZJJbXWsC6DHkuP6MUzHJfwBXejRYM77a meuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765901541; x=1766506341; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=r0/8G+ZcWTO+kenV7LPyPJmReW0DRv9RwtxhB8rfOeA=; b=mHb5XkXI7uKFYb3woMNgOCSauNa6HJyAOwDbSKjmkqWvWym2cdeSM0c2r30Xq7o6o1 w1Df/lHsM6WB9gbkq/ArrMBc7zD+ex8zA4LI4ucG8vtHapUJBeGULVV+XVnVg54nT5U3 l36FYvhXYmLcF+bS+yBMQ5sJWdZMb1vTJoakHMSg0cCrmUcpfG/UDLDqfNXulxkTeHG8 J3xIVQR6+3AgxEFfdFOSvJz9h9Oje0+6xiIDqPlcPc/qxbIeinU+Z7b78K4bFgHIY7yO 3qU9wPCAZ1VEmk5nh4HdXBzrZLLheA58Dxg+FgsXmXEw7OUyUZUfQneThIRyNrx4BT69 fwIg== X-Gm-Message-State: AOJu0Yx24jyNq4/BSVvappuPRFIJ1JlwXOu1zmBXl+sPGCAVRxSaySHE IMNJtyYbsD1eKKFS+e13QKyhl7dp0XTQ8sY506q8DVrqI9G66JQFT1IBRux7BGTdL+RJID6N2JZ tL0t6 X-Gm-Gg: AY/fxX7dtbfKDo8xfuua4RY0cs/4sc1xq6qbtIz9gqVCMtUREdFdSA0XGBofQxwsqW6 TUUTbkS8U4Ht6D94w/mkwTiGDR/l09K7o4lMzWoaBEXzdlVGY6BvAFhI/Cf8XbLN+kTxXhRUjNM OuVWM9TKXvO8pnTELIImrVcCGS+DqqlsIRIM0d3FAtBBMRKbxeNiKoB6eCV65ebul3Sv/4/TwHM G4b0gmIXGWsN6ot7U9q1k89rU3kkonfyrYGQFXk9e/4xmbKMPS3ceCtRkpmDdDhvv/wM+RtDX4u hhZ/Bcqom6/yjfEGFB6/or0TMa2s/sz0MMAA7uWgbJQ63Oh1Hy6QAjt99v5DVFVeSNZZ6JyWJxr /qRRGbZEAQRfb70ovN85OpI3k6BwqZLk2EjhgnkdnEHj2KLKN+htaEi+qOnrDWxCYbTZV7MDcZ8 ZBfzuGCuQJ7eLqvnF7qg== X-Google-Smtp-Source: AGHT+IFkuBORiak5WKezx1FJWSegFGa/mZfAiWK7VdZf9MLei7BQX3J5G7u4ujl1MwokShlcmQRHRA== X-Received: by 2002:a05:6214:5b0a:b0:88a:3113:3abf with SMTP id 6a1803df08f44-88a31139931mr122861806d6.52.1765901541225; Tue, 16 Dec 2025 08:12:21 -0800 (PST) Received: from RHTRH0061144.redhat.com ([47.14.5.10]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-889a85eea1asm76301336d6.44.2025.12.16.08.12.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 08:12:20 -0800 (PST) From: 0-day Robot To: test-report@dpdk.org, Stephen Hemminger Subject: |SUCCESS| pw159221 eal: add check for sysfs path overflow Date: Tue, 16 Dec 2025 11:12:19 -0500 Message-ID: <20251216161219.762563-1-robot@bytheb.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251207191242.165619-11-stephen@networkplumber.org> References: <20251205022948.327743-1-stephen@networkplumber.org> <20251207191242.165619-1-stephen@networkplumber.org> <20251207191242.165619-11-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: 0day Robot - Claude SONNET Test-Status: SUCCESS http://dpdk.org/patch/159221 _AI Review Comments Available_ git sha: [not available from patch] Author: Stephen Hemminger Subject: eal: add check for sysfs path overflow This patch adds a check for potential buffer overflow when constructing sysfs paths in get_num_hugepages_on_node() function. > diff --git a/lib/eal/linux/eal_hugepage_info.c b/lib/eal/linux/eal_hugepage_info.c > index 7161b1a2fb..fe3351259e 100644 > --- a/lib/eal/linux/eal_hugepage_info.c > +++ b/lib/eal/linux/eal_hugepage_info.c > @@ -150,8 +150,12 @@ get_num_hugepages_on_node(const char *subdir, unsigned int socket, size_t sz) > return 0; > } > > - snprintf(path, sizeof(path), "%s/%s/%s", > + if (snprintf(path, sizeof(path), "%s/%s/%s", socketpath, subdir, nr_hp_file) >= PATH_MAX) { > + EAL_LOG(NOTICE, "Socket path %s/%s/%s is truncated", > socketpath, subdir, nr_hp_file); > + return 0; > + } > + Does this comparison use the correct buffer size? The code compares snprintf return value against PATH_MAX, but the actual buffer size is sizeof(path). If the path variable is not PATH_MAX bytes, this could either miss truncation or incorrectly flag valid paths.