From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF8F34705A for ; Tue, 16 Dec 2025 17:12:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A6B1940609; Tue, 16 Dec 2025 17:12:43 +0100 (CET) Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) by mails.dpdk.org (Postfix) with ESMTP id 6A2694026D for ; Tue, 16 Dec 2025 17:12:39 +0100 (CET) Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-8b9f73728e8so451931585a.0 for ; Tue, 16 Dec 2025 08:12:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytheb-org.20230601.gappssmtp.com; s=20230601; t=1765901558; x=1766506358; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=hA6n8nAwb7Afgzd8r9h6E4wJ2nsTYX0atZ8nR0cKfDA=; b=1n9PPeHPGWk2mUbULmDktGe+ZuTZcDyQTb31y3Kj4Y2iYH317sFH+/rQ80CuaWfKCQ eOYQERojf/ANY3xrZLAvV6KdTIel2MFxu5jRivryidYAuJmXPXJgKKiw5JNKe+FNyo5P HwC0Mlw2JLNOul1BLEtmBgxo7gDf4MTgFIGCCC6EbJdWS9CxNOGcuMMD3WKwOKQ+CcC7 CR3cjToRzYd7zxvYTy+9gPqvJ9GK5hSlXLEOMX8Bkzr9HQJNRpMYNoMCfj6EgCkVf2Me siOijQFrtfFPysm94Ru8NGE+p2GWY8i9GblBVYRG3WklXrWfUeQBOm/boviBibygDqQ7 TbQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765901558; x=1766506358; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=hA6n8nAwb7Afgzd8r9h6E4wJ2nsTYX0atZ8nR0cKfDA=; b=UC59/aEk/SiRgC4+uGxgZboxlewFJ4ets0/i8du7KwJsKnMbo4uCLxhXoY/jfw9nlf aVec8A8slrnCyVKInbc4rB94ClogtjNAQ/IAWvkc2zWcPszvOg7vvBeEf+65jQJqi/M0 1MjLjugn0d1vkVOKJiNO6bfW0IkL55yTYJEN/SzK8vpRbujheG459m6cgWAyDTrsl03M p5nHfk6h5eyGD4NC9vFSS6jAA6gFfNKLFHpvySwtwTy6gfFUpmGnz1uYb2gRpuSiNBzU FFRCjsax6nikjkDieJ2qtrDglHtIWHT/4QnDgTJ58EQ2efKCdm4GS1eC91QwT5izTY5B mK0g== X-Gm-Message-State: AOJu0YxrlksZmcx7N+fgAf4uyJRZAO6wKeHPMNHDtQQdScHArZVHHHWa tVnkhkYTG2+hMNZM8eOcOErDc1bb5Ov9fFrm3Ob46X8uV59bDjfHKId2C+24H3fl8dcbQBD9SFW yHM9G X-Gm-Gg: AY/fxX556lPK+dpzu1B9Wi3/ecjW85N87XkBBeRr5lHXi3L0zbYNqKmYR2i5xVg4k7e G+3ZLe/w+KwzBropWPihua4tFjydgnzEVi1Xy9WaqFlXaSmLYDEYvMot0THvuX8FCSPhaX0dGPR ygFvzRpSRIsSTdSOWuTP4doeamdNyOLVmGWDs4qtnxAT873yMa0r5w+HahvQj6F6wBMhKUu1r2Y 1c3d9VwY8i0PPB59oUOpPuYQjtaMAlpH5lCSx4bJ9vX/j6tjKhiNt4sgxlZiJ7abUhQr1zRsNLu E4ctP50HUJL11z9ykVSgV+e9dnYx2ZfjRbDRwOIA+XQ9mYuYSdhYIp7AdAWhOAHSlMQXEBOCvQ2 o0fkEqDag3xaZYSnnC5Fz61BKhvysLou4f4KY22CVMgQHAbMXSAw+5PBmG5/9U2o8gR1aHOhAbA PPEabZxLXzy5K9itjaxA== X-Google-Smtp-Source: AGHT+IGa1yhqgxjloWbMjSvw0gTj/nAuWWDB8znNZ98KhlWzb9OY6wjy7UC4dP8vIyfBtZczgAI3Kw== X-Received: by 2002:a05:620a:45a2:b0:8b2:eb83:b8d with SMTP id af79cd13be357-8bb399dc2e7mr1665072585a.9.1765901557997; Tue, 16 Dec 2025 08:12:37 -0800 (PST) Received: from RHTRH0061144.redhat.com ([47.14.5.10]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8be30d8a158sm212458285a.21.2025.12.16.08.12.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Dec 2025 08:12:37 -0800 (PST) From: 0-day Robot To: test-report@dpdk.org, Stephen Hemminger Subject: |SUCCESS| pw159228 [PATCH v5 17/17] lib: enable format overflow warnings Date: Tue, 16 Dec 2025 11:12:36 -0500 Message-ID: <20251216161236.762659-1-robot@bytheb.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251207191242.165619-18-stephen@networkplumber.org> References: <20251205022948.327743-1-stephen@networkplumber.org> <20251207191242.165619-1-stephen@networkplumber.org> <20251207191242.165619-18-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: 0day Robot - Claude SONNET Test-Status: SUCCESS http://dpdk.org/patch/159228 _AI Review Comments Available_ Looking at this commit, I have a concern about enabling format overflow warnings without addressing the underlying issues that these warnings were suppressing. git sha: [Need to call commit function to get exact sha] Author: Stephen Hemminger lib: enable format overflow warnings Enable compiler checking of format overflow > diff --git a/lib/meson.build b/lib/meson.build > index c8f4270868..8f5cfd28a5 100644 > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -113,10 +113,6 @@ default_cflags = machine_args > default_cflags += ['-DALLOW_EXPERIMENTAL_API'] > default_cflags += ['-DALLOW_INTERNAL_API'] > > -if cc.has_argument('-Wno-format-truncation') > - default_cflags += '-Wno-format-truncation' > -endif > - Will this change introduce build failures on existing code? The original warning suppression was likely added because there were legitimate format truncation cases in the codebase that would cause compilation errors when treated as warnings or errors. Has all existing code been audited to ensure no format truncation warnings exist? Without seeing the fixes to address the underlying issues that this warning flag was suppressing, this change could break builds for developers and CI systems. Should this change be part of a series that first fixes all format truncation issues, then removes the warning suppression? The commit message suggests this enables "format overflow" checking, but the code removes suppression for "format-truncation" warnings.