From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2BAA547132
	for <public@inbox.dpdk.org>; Mon, 29 Dec 2025 22:38:27 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 271DD402B3;
	Mon, 29 Dec 2025 22:38:27 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 2E4A3402B3
 for <test-report@dpdk.org>; Mon, 29 Dec 2025 22:38:26 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id E85B0124270; Mon, 29 Dec 2025 22:36:36 +0100 (CET)
Subject: |WARNING| pw159530 [PATCH 7/9] net/sfc: rework the capability check
 that is done on FEC set
In-Reply-To: <20251229213527.37907-8-ivan.malov@arknetworks.am>
References: <20251229213527.37907-8-ivan.malov@arknetworks.am>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Ivan Malov <ivan.malov@arknetworks.am>
Message-Id: <20251229213636.E85B0124270@dpdk.org>
Date: Mon, 29 Dec 2025 22:36:36 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/159530

_coding style issues_


WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#155: FILE: drivers/net/sfc/sfc_ethdev.c:2750:
+			return 0;
+		} else {

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#167: FILE: drivers/net/sfc/sfc_ethdev.c:2762:
+		return EINVAL;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#215: FILE: drivers/net/sfc/sfc_ethdev.c:2790:
+			return ENOTSUP;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP)
#225: FILE: drivers/net/sfc/sfc_ethdev.c:2796:
+			return ENOTSUP;

total: 0 errors, 4 warnings, 0 checks, 137 lines checked