[dpdk-test-report] [PatchWork]|ERROR|pw12305-12319 vfio: fix include of eal_private.h to be local

[dpdk-test-report] [PatchWork]|ERROR|pw12305-12319 vfio: fix include of eal_private.h to be local

[sys_stv]

[-- Attachment #1: Type: text/plain, Size: 5468 bytes --]


Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 12305-12319
http://www.dpdk.org/dev/patchwork/patch/12319/
Submitter: Jan Viktorin <viktorin@rehivetech.com>
Date: Fri, 29 Apr 2016 15:44:02 +0200
DPDK git baseline: 351637731a0e1589d48b0d9972a006c414378c8d

Check patch error:
12314: 
WARNING: line over 80 characters
#148: FILE: lib/librte_eal/linuxapp/eal/eal_pci_vfio.c:549:
+struct mapped_pci_res_list *vfio_res_list = 
+RTE_TAILQ_CAST(rte_vfio_tailq.head, mapped_pci_res_list);

ERROR: do not use assignment in if condition
#162: FILE: lib/librte_eal/linuxapp/eal/eal_pci_vfio.c:563:
+if ((ret = pci_vfio_setup_device(pci_addr, &vfio_dev_fd, 
+&device_info)))

total: 1 errors, 1 warnings, 132 lines checked

/home/patchWorkOrg/patches/dpdk-dev-10-15-vfio-extract-setup-logic-out-of-pci_vfio_map_resource.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

12315: 
ERROR: do not use assignment in if condition
#326: FILE: lib/librte_eal/linuxapp/eal/eal_pci_vfio.c:326:
+if ((ret = vfio_setup_device(SYSFS_PCI_DEVICES, pci_addr,

WARNING: line over 80 characters
#434: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:71:
+RTE_LOG(ERR, EAL, "Cannot open %s: %s
", filename,

WARNING: line over 80 characters
#445: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:82:
+RTE_LOG(ERR, EAL, "Cannot open %s: %s
", filename,

WARNING: line over 80 characters
#456: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:93:
+RTE_LOG(ERR, EAL, "Maximum number of VFIO groups reached!
");

WARNING: line over 80 characters
#460: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:97:
+vfio_cfg.vfio_groups[vfio_cfg.vfio_group_idx].group_no = 
+iommu_group_no;

WARNING: line over 80 characters
#461: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:98:
+vfio_cfg.vfio_groups[vfio_cfg.vfio_group_idx].fd = vfio_group_fd;

WARNING: line over 80 characters
#473: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:110:
+RTE_LOG(ERR, EAL, "  cannot connect to primary process!
");

WARNING: line over 80 characters
#476: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:113:
+if (vfio_mp_sync_send_request(socket_fd, SOCKET_REQ_GROUP) < 0) {

WARNING: line over 80 characters
#528: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:165:
+RTE_LOG(WARNING, EAL, "  %s not managed by VFIO driver, skipping
",

WARNING: line over 80 characters
#548: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:185:
+RTE_LOG(WARNING, EAL, "  %s not managed by VFIO driver, skipping
",

WARNING: line over 80 characters
#558: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:195:
+ * at this point, we know that this group is viable (meaning, all 
+devices

WARNING: line over 80 characters
#569: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:206:
+RTE_LOG(ERR, EAL, "  %s cannot add VFIO group to container, "

WARNING: line over 80 characters
#570: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:207:
+"error %i (%s)
", dev_addr, errno, strerror(errno));

WARNING: quoted string split across lines
#570: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:207:
+RTE_LOG(ERR, EAL, "  %s cannot add VFIO group to container, "
+"error %i (%s)
", dev_addr, errno, strerror(errno));

WARNING: line over 80 characters
#577: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:214:
+ * initialized, so we increment vfio_group_idx to indicate that we 
+can

WARNING: line over 80 characters
#586: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:223:
+ * needs to be done only once, only when at least one group is 
+assigned to

WARNING: line over 80 characters
#595: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:232:
+RTE_LOG(ERR, EAL, "  %s failed to select IOMMU type
", dev_addr);

WARNING: line over 80 characters
#601: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:238:
+"error %i (%s)
", dev_addr, errno, strerror(errno));

WARNING: quoted string split across lines
#601: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:238:
+RTE_LOG(ERR, EAL, "  %s DMA remapping failed, "
+"error %i (%s)
", dev_addr, errno, strerror(errno));

WARNING: line over 80 characters
#613: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:250:
+RTE_LOG(WARNING, EAL, "  %s not managed by VFIO driver, skipping
",

WARNING: line over 80 characters
#622: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:259:
+"error %i (%s)
", dev_addr, errno, strerror(errno));

WARNING: quoted string split across lines
#622: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:259:
+RTE_LOG(ERR, EAL, "  %s cannot get device info, "
+"error %i (%s)
", dev_addr, errno, strerror(errno));

WARNING: quoted string split across lines
#657: FILE: lib/librte_eal/linuxapp/eal/eal_vfio.c:294:
+RTE_LOG(DEBUG, EAL, "VFIO modules not loaded, "
+"skipping VFIO support...
");

total: 1 errors, 22 warnings, 630 lines checked

/home/patchWorkOrg/patches/dpdk-dev-11-15-vfio-move-global-vfio_cfg-to-eal_vfio.c.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.


Compilation:
OS: fedora
Nic: niantic
GCC: gcc_x86-64, 4.8.3
ICC:16.0.2
i686-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-combined: compile pass
i686-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-debug: compile pass
x86_64-native-linuxapp-gcc-shared: compile pass
x86_64-native-linuxapp-clang: compile pass



DPDK STV team