[dpdk-test-report] [PatchWork]|ERROR| pw12415-12416 mempool: add stack (fifo) mempool handler

[dpdk-test-report] [PatchWork]|ERROR| pw12415-12416 mempool: add stack (fifo) mempool handler

[sys_stv]

[-- Attachment #1: Type: text/plain, Size: 2869 bytes --]


Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 12415-12416
http://www.dpdk.org/dev/patchwork/patch/12416/
Submitter: David Hunt <david.hunt@intel.com>
Date: Thu,  5 May 2016 19:29:41 +0100
DPDK git baseline: 84c9b5a9fe926f1aa033dc5352be8d4a5e0b789d

Check patch error:
12415: 
ERROR: open brace '{' following struct go on the same line
#87: FILE: lib/librte_mempool/rte_mempool_stack.c:40:
+struct rte_mempool_common_stack
+{

ERROR: "(foo*)" should be "(foo *)"
#105: FILE: lib/librte_mempool/rte_mempool_stack.c:58:
+	int size = sizeof(*s) + (n+16)*sizeof(void*);

WARNING: line over 80 characters
#131: FILE: lib/librte_mempool/rte_mempool_stack.c:84:
+	struct rte_mempool_common_stack * s = (struct rte_mempool_common_stack 
+*)p;

ERROR: "foo * bar" should be "foo *bar"
#131: FILE: lib/librte_mempool/rte_mempool_stack.c:84:
+	struct rte_mempool_common_stack * s = (struct rte_mempool_common_stack 
+*)p;

ERROR: space required before the open parenthesis '('
#140: FILE: lib/librte_mempool/rte_mempool_stack.c:93:
+	if((s->len + n) > s->size) {

WARNING: line over 80 characters
#158: FILE: lib/librte_mempool/rte_mempool_stack.c:111:
+	struct rte_mempool_common_stack * s = (struct rte_mempool_common_stack 
+*)p;

ERROR: "foo * bar" should be "foo *bar"
#158: FILE: lib/librte_mempool/rte_mempool_stack.c:111:
+	struct rte_mempool_common_stack * s = (struct rte_mempool_common_stack 
+*)p;

ERROR: space required before the open parenthesis '('
#165: FILE: lib/librte_mempool/rte_mempool_stack.c:118:
+	if(unlikely(n > s->len)) {

WARNING: line over 80 characters
#172: FILE: lib/librte_mempool/rte_mempool_stack.c:125:
+	for (index = 0, len = s->len - 1; index < n; ++index, len--, 
+obj_table++)

WARNING: line over 80 characters
#182: FILE: lib/librte_mempool/rte_mempool_stack.c:135:
+	struct rte_mempool_common_stack * s = (struct rte_mempool_common_stack 
+*)p;

ERROR: "foo * bar" should be "foo *bar"
#182: FILE: lib/librte_mempool/rte_mempool_stack.c:135:
+	struct rte_mempool_common_stack * s = (struct rte_mempool_common_stack 
+*)p;

total: 7 errors, 4 warnings, 161 lines checked

/home/patchWorkOrg/patches/dpdk-dev-1-2-mempool-add-stack-fifo-mempool-handler.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.


patch file error:
12416: 
patching file app/test/test_mempool.c
Hunk #1 FAILED at 570.
Hunk #2 succeeded at 481 with fuzz 2 (offset -138 lines).
Hunk #3 succeeded at 537 with fuzz 2 (offset -136 lines).
1 out of 3 hunks FAILED -- saving rejects to file app/test/test_mempool.c.rej

12415: 
patching file lib/librte_mempool/Makefile Hunk #1 FAILED at 44.
1 out of 1 hunk FAILED -- saving rejects to file lib/librte_mempool/Makefile.rej patching file lib/librte_mempool/rte_mempool_stack.c


DPDK STV team