Test-Label: Intel Niantic on Fedora Test-Status: ERROR Patchwork ID: 12609-12628 http://www.dpdk.org/dev/patchwork/patch/12628/ Submitter: Jerin Jacob Date: Sat, 7 May 2016 20:46:19 +0530 DPDK git baseline: 84c9b5a9fe926f1aa033dc5352be8d4a5e0b789d Check patch error: 12609: WARNING: networking block comments don't use an empty /* line, use /* Comment... #53: FILE: drivers/net/thunderx/base/nicvf_hw.c:2: +/* + * BSD LICENSE ERROR: return is not a function, parentheses are not required #320: FILE: drivers/net/thunderx/base/nicvf_hw.c:269: + return (*(const uint32_t *)a - *(const uint32_t *)b); WARNING: networking block comments don't use an empty /* line, use /* Comment... #394: FILE: drivers/net/thunderx/base/nicvf_hw.c:343: +/* + * Handle poll mode driver interested "mbox" and "queue-set error" interrupts. WARNING: networking block comments don't use an empty /* line, use /* Comment... #970: FILE: drivers/net/thunderx/base/nicvf_hw.h:2: +/* + * BSD LICENSE WARNING: networking block comments don't use an empty /* line, use /* Comment... #1216: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:2: +/* + * BSD LICENSE WARNING: do not add new typedefs #1754: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:540: +typedef uint64_t nicvf_phys_addr_t; WARNING: do not add new typedefs #1765: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:551: +typedef union { WARNING: do not add new typedefs #1810: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:596: +typedef union { WARNING: do not add new typedefs #1835: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:621: +typedef union { WARNING: do not add new typedefs #1852: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:638: +typedef union { WARNING: do not add new typedefs #1869: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:655: +typedef union { WARNING: do not add new typedefs #1886: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:672: +typedef union { WARNING: do not add new typedefs #1903: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:689: +typedef union { ERROR: spaces prohibited around that ':' (ctx:VxW) #2340: FILE: drivers/net/thunderx/base/nicvf_hw_defs.h:1126: + uint64_t ena: 1; ^ WARNING: networking block comments don't use an empty /* line, use /* Comment... #2439: FILE: drivers/net/thunderx/base/nicvf_mbox.c:2: +/* + * BSD LICENSE WARNING: networking block comments don't use an empty /* line, use /* Comment... #2632: FILE: drivers/net/thunderx/base/nicvf_mbox.c:195: +/* + * Checks if VF is able to communicate with PF WARNING: networking block comments don't use an empty /* line, use /* Comment... #2861: FILE: drivers/net/thunderx/base/nicvf_mbox.h:2: +/* + * BSD LICENSE WARNING: networking block comments don't use an empty /* line, use /* Comment... #3099: FILE: drivers/net/thunderx/base/nicvf_plat.h:2: +/* + * BSD LICENSE ERROR: space prohibited before open square bracket '[' #3180: FILE: drivers/net/thunderx/base/nicvf_plat.h:83: + : [val] "r" (val), [addr] "r" (addr)); ERROR: space prohibited before open square bracket '[' #3190: FILE: drivers/net/thunderx/base/nicvf_plat.h:93: + : [val] "=r" (val) ERROR: space prohibited before open square bracket '[' #3191: FILE: drivers/net/thunderx/base/nicvf_plat.h:94: + : [addr] "r" (addr)); ERROR: space prohibited before open square bracket '[' #3198: FILE: drivers/net/thunderx/base/nicvf_plat.h:101: + : [x1]"=r"(reg1), [x0]"=r"(reg2) ERROR: space prohibited before open square bracket '[' #3199: FILE: drivers/net/thunderx/base/nicvf_plat.h:102: + : [p1]"r"(addr) WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #3209: FILE: drivers/net/thunderx/base/nicvf_plat.h:112: + *(volatile uint64_t *)addr = val; WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt #3215: FILE: drivers/net/thunderx/base/nicvf_plat.h:118: + return *(volatile uint64_t *)addr; total: 7 errors, 18 warnings, 3148 lines checked /home/patchWorkOrg/patches/dpdk-dev-01-20-thunderx-nicvf-base-add-hardware-API-for-ThunderX-nicvf-inbuilt-NIC.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12620: WARNING: networking block comments don't use an empty /* line, use /* Comment... #59: FILE: drivers/net/thunderx/nicvf_rxtx.c:2: +/* + * BSD LICENSE ERROR: return is not a function, parentheses are not required #217: FILE: drivers/net/thunderx/nicvf_rxtx.c:160: + return ((sq->head - sq->tail - 1) & sq->qlen_mask); WARNING: networking block comments don't use an empty /* line, use /* Comment... #344: FILE: drivers/net/thunderx/nicvf_rxtx.h:2: +/* + * BSD LICENSE total: 1 errors, 2 warnings, 339 lines checked /home/patchWorkOrg/patches/dpdk-dev-12-20-thunderx-nicvf-add-single-and-multi-segment-tx-functions.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Compilation: OS: fedora Nic: niantic GCC: gcc_x86-64, 4.8.3 ICC:16.0.2 i686-native-linuxapp-icc: compile pass x86_64-native-linuxapp-gcc-combined: compile pass i686-native-linuxapp-gcc: compile pass x86_64-native-linuxapp-gcc: compile pass x86_64-native-linuxapp-icc: compile pass x86_64-native-linuxapp-gcc-debug: compile pass x86_64-native-linuxapp-gcc-shared: compile pass x86_64-native-linuxapp-clang: compile pass DPDK STV team