[dpdk-test-report] [PatchWork]|ERROR| pw15356-15377 net/pcap: convert config option to a macro

[dpdk-test-report] [PatchWork]|ERROR| pw15356-15377 net/pcap: convert config option to a macro

[sys_stv]

[-- Attachment #1: Type: text/plain, Size: 2894 bytes --]


Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 15356-15377
http://www.dpdk.org/dev/patchwork/patch/15377/
Submitter: Ferruh Yigit <ferruh.yigit@intel.com>
Date: Fri, 26 Aug 2016 12:17:38 +0100
DPDK git baseline: e22856313fff2db12d8e132dad446bbf74cf29a5

Check patch error:
15369: 
ERROR: do not use assignment in if condition
#77: FILE: drivers/net/pcap/rte_eth_pcap.c:407:
+	if ((tx_pcap = pcap_open_dead(DLT_EN10MB, RTE_ETH_PCAP_SNAPSHOT_LEN))

ERROR: do not use assignment in if condition
#84: FILE: drivers/net/pcap/rte_eth_pcap.c:414:
+	if ((*dumper = pcap_dump_open(tx_pcap, pcap_filename)) == NULL) {

ERROR: do not use assignment in if condition
#96: FILE: drivers/net/pcap/rte_eth_pcap.c:426:
+	if ((*pcap = pcap_open_offline(pcap_filename, errbuf)) == NULL) {

WARNING: line over 80 characters
#97: FILE: drivers/net/pcap/rte_eth_pcap.c:427:
+		RTE_LOG(ERR, PMD, "Couldn't open %s: %s
", pcap_filename, errbuf);

total: 3 errors, 1 warnings, 159 lines checked

/home/patchWorkOrg/patches/dpdk-dev-14-22-net-pcap-reorder-functions.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

15359: 
WARNING: line over 80 characters
#267: FILE: drivers/net/pcap/rte_eth_pcap.c:1015:
+	if ((pcaps.num_of_queue = rte_kvargs_count(kvlist, 
+ETH_PCAP_RX_PCAP_ARG))) {

ERROR: do not use assignment in if condition
#267: FILE: drivers/net/pcap/rte_eth_pcap.c:1015:
+	if ((pcaps.num_of_queue = rte_kvargs_count(kvlist, 
+ETH_PCAP_RX_PCAP_ARG))) {

ERROR: do not use assignment in if condition
#281: FILE: drivers/net/pcap/rte_eth_pcap.c:1032:
+	if ((dumpers.num_of_queue = rte_kvargs_count(kvlist,

WARNING: line over 80 characters
#298: FILE: drivers/net/pcap/rte_eth_pcap.c:1048:
+		ret = rte_eth_from_pcaps_n_dumpers(name, &pcaps, pcaps.num_of_queue,

WARNING: line over 80 characters
#299: FILE: drivers/net/pcap/rte_eth_pcap.c:1049:
+				&dumpers, dumpers.num_of_queue, numa_node, kvlist);

WARNING: line over 80 characters
#303: FILE: drivers/net/pcap/rte_eth_pcap.c:1051:
+		ret = rte_eth_from_pcaps(name, &pcaps, pcaps.num_of_queue, &dumpers,

total: 2 errors, 4 warnings, 263 lines checked

/home/patchWorkOrg/patches/dpdk-dev-03-22-net-pcap-reorganize-private-structs.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.


Compilation:
OS: fedora
Nic: niantic
GCC: gcc_x86-64, 4.8.3
ICC:16.0.2
i686-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-combined: compile pass
i686-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-debug: compile pass
x86_64-native-linuxapp-gcc-shared: compile pass
x86_64-native-linuxapp-clang: compile pass



DPDK STV team