Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 15414-15416
http://www.dpdk.org/dev/patchwork/patch/15416/
Submitter: Pankaj Chauhan <pankaj.chauhan@nxp.com>
Date: Sat, 27 Aug 2016 21:56:24 +0530
DPDK git baseline: e22856313fff2db12d8e132dad446bbf74cf29a5

Check patch error:
15416: 
ERROR: do not initialise statics to 0 or NULL
#85: FILE: examples/vhost/main.c:114:
+static uint32_t jumbo_frame_en = 0;

ERROR: trailing statements should be on next line
#215: FILE: examples/vhost/main.c:199:
+	if (port >= rte_eth_dev_count()) return -1;

WARNING: space prohibited between function name and open parenthesis '('
#226: FILE: examples/vhost/main.c:209:
+	rte_eth_dev_info_get (vs_port->port_id, &dev_info);

WARNING: suspect code indent for conditional statements (8, 12)
#557: FILE: examples/vhost/main.c:713:
+	if (unlikely(!tx_port))
+	    goto out;

WARNING: suspect code indent for conditional statements (8, 12)
#686: FILE: examples/vhost/main.c:763:
+	if (unlikely(!rx_port))
+	    goto out;

ERROR: space prohibited after that open square bracket '['
#1085: FILE: examples/vhost/vmdq.c:153:
+		conf.pool_map[i].vlan_id = vlan_tags[ i ];

ERROR: space prohibited before that close square bracket ']'
#1085: FILE: examples/vhost/vmdq.c:153:
+		conf.pool_map[i].vlan_id = vlan_tags[ i ];

WARNING: space prohibited between function name and open parenthesis '('
#1110: FILE: examples/vhost/vmdq.c:178:
+	rte_eth_dev_info_get (vs_port->port_id, &dev_info);

WARNING: braces {} are not necessary for single statement blocks
#1132: FILE: examples/vhost/vmdq.c:200:
+	if (rc < 0) {
+		goto out;
+	}

WARNING: line over 80 characters
#1142: FILE: examples/vhost/vmdq.c:210:
+	printf("pf queue num: %u, configured vmdq pool num: %u, each vmdq pool 
+has %u queues
",

WARNING: braces {} are not necessary for single statement blocks
#1148: FILE: examples/vhost/vmdq.c:216:
+	if (rc) {
+		priv->phys_port_count--;
+	}

ERROR: space required before the open parenthesis '('
#1170: FILE: examples/vhost/vmdq.c:238:
+	switch(port->type) {

ERROR: space required before the open parenthesis '('
#1190: FILE: examples/vhost/vmdq.c:258:
+	switch(port->type) {

WARNING: line over 80 characters
#1215: FILE: examples/vhost/vmdq.c:283:
+ * This function learns the MAC address of the device and registers 
+ this along with a

WARNING: line over 80 characters
#1250: FILE: examples/vhost/vmdq.c:318:
+		vdev->mac_address.addr_bytes[0], vdev->mac_address.addr_bytes[1],

WARNING: line over 80 characters
#1251: FILE: examples/vhost/vmdq.c:319:
+		vdev->mac_address.addr_bytes[2], vdev->mac_address.addr_bytes[3],

WARNING: line over 80 characters
#1252: FILE: examples/vhost/vmdq.c:320:
+		vdev->mac_address.addr_bytes[4], vdev->mac_address.addr_bytes[5],

WARNING: space prohibited between function name and open parenthesis '('
#1274: FILE: examples/vhost/vmdq.c:342:
+static int vmdq_learn_port (struct vswitch_port *vs_port,

WARNING: line over 80 characters
#1287: FILE: examples/vhost/vmdq.c:355:
+ * Removes MAC address and vlan tag from VMDQ. Ensures that nothing is 
+ adding buffers to the RX

WARNING: space prohibited between function name and open parenthesis '('
#1328: FILE: examples/vhost/vmdq.c:396:
+static int vmdq_unlearn_port (struct vswitch_port *vs_port)

ERROR: space required before the open brace '{'
#1464: FILE: examples/vhost/vmdq.c:532:
+		if (unlikely((vs_dev->conf_flags & VS_CNF_FLG_VM2VM_HARDWARE))){

ERROR: space required before the open parenthesis '('
#1531: FILE: examples/vhost/vmdq.c:599:
+	switch(vs_port->type) {

WARNING: line over 80 characters
#1574: FILE: examples/vhost/vmdq.c:642:
+		RTE_LOG(DEBUG, VHOST_CONFIG, "VMDQ switch registration failure
");

total: 8 errors, 15 warnings, 1549 lines checked

/home/patchWorkOrg/patches/dpdk-dev-RFC-3-3-examples-vhost-Add-VMDQ-vswitch-device.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

15414: 
WARNING: space prohibited between function name and open parenthesis '('
#149: FILE: examples/vhost/vswitch_common.c:78:
+static uint16_t vs_do_rx_phys_port (struct vswitch_port *port, uint16_t 
+rx_q,

WARNING: space prohibited between function name and open parenthesis '('
#156: FILE: examples/vhost/vswitch_common.c:85:
+static uint16_t vs_do_rx_virtio_port (struct vswitch_port *port, 
+uint16_t rx_q,

WARNING: Avoid line continuations in quoted strings
#251: FILE: examples/vhost/vswitch_common.c:180:
+		RTE_LOG(DEBUG, VHOST_CONFIG, "Failed get free port in 
WARNING: Avoid line continuations in quoted strings
#294: FILE: examples/vhost/vswitch_common.c:223:
+	RTE_LOG(DEBUG, VHOST_CONFIG, "Added port [%d, type %d] to 
ERROR: space required before the open brace '{'
#297: FILE: examples/vhost/vswitch_common.c:226:
+	if (rc){

WARNING: line over 80 characters
#298: FILE: examples/vhost/vswitch_common.c:227:
+		RTE_LOG(INFO, VHOST_CONFIG, "Failed to Add port [%d, type %d] to 
WARNING: Avoid line continuations in quoted strings
#298: FILE: examples/vhost/vswitch_common.c:227:
+		RTE_LOG(INFO, VHOST_CONFIG, "Failed to Add port [%d, type %d] to 
WARNING: Avoid line continuations in quoted strings
#325: FILE: examples/vhost/vswitch_common.c:254:
+	RTE_LOG(DEBUG, VHOST_CONFIG, "Removed port [%d, type %d] from 
ERROR: that open brace { should be on the previous line
#445: FILE: examples/vhost/vswitch_common.c:374:
+	for (i = 0; i < max_ports; i++)
+	{

ERROR: space required before the open brace '{'
#480: FILE: examples/vhost/vswitch_common.c:409:
+		if (!strncmp(temp->name, vs_dev->name, VSWITCH_NAME_SIZE)){

ERROR: that open brace { should be on the previous line
#523: FILE: examples/vhost/vswitch_common.c:452:
+	if (!vs_mdata_g)
+	{

WARNING: space prohibited between function name and open parenthesis '('
#621: FILE: examples/vhost/vswitch_common.h:77:
+	LIST_ENTRY (vswitch_dev) list;

ERROR: need consistent spacing around '*' (ctx:WxO)
#638: FILE: examples/vhost/vswitch_common.h:94:
+			   rte_mbuf **tx_pkts,	uint16_t pkt_count);
 			            ^

ERROR: need consistent spacing around '*' (ctx:WxO)
#641: FILE: examples/vhost/vswitch_common.h:97:
+			   rte_mbuf **rx_pkts,	uint16_t pkt_count);
 			            ^

total: 6 errors, 8 warnings, 650 lines checked

/home/patchWorkOrg/patches/dpdk-dev-RFC-1-3-examples-vhost-Add-vswitch-generic-switch-framework.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

15415: 
ERROR: "(foo*)" should be "(foo *)"
#62: FILE: examples/vhost/main.c:425:
+		snprintf((char*)&switch_dev, MAX_BASENAME_SZ, "%s", q_arg);

WARNING: line over 80 characters
#85: FILE: examples/vhost/main.c:681:
+			if (!strncmp(long_option[option_index].name, "switch", 
+MAX_LONG_OPT_SZ)) {

WARNING: line over 80 characters
#87: FILE: examples/vhost/main.c:683:
+					RTE_LOG(INFO, VHOST_CONFIG, "Invalid argument for character switch 
+dev (Max %d characters)
", MAX_BASENAME_SZ);

WARNING: line over 80 characters
#94: FILE: examples/vhost/main.c:690:
+			if (!strncmp(long_option[option_index].name, "max-ports", 
+MAX_LONG_OPT_SZ)) {

WARNING: line over 80 characters
#97: FILE: examples/vhost/main.c:693:
+					RTE_LOG(INFO, VHOST_CONFIG, "Invalid argument for switch max ports 
+[0-N]
");

total: 1 errors, 4 warnings, 67 lines checked

/home/patchWorkOrg/patches/dpdk-dev-RFC-2-3-examples-vhost-Add-vswitch-command-line-options.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.


Compilation:
OS: fedora
Nic: niantic
GCC: gcc_x86-64, 4.8.3
ICC:16.0.2
i686-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-combined: compile pass
i686-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-debug: compile pass
x86_64-native-linuxapp-gcc-shared: compile pass
x86_64-native-linuxapp-clang: compile pass



DPDK STV team