Test-Label: Intel Niantic on Fedora Test-Status: ERROR Patchwork ID: 15437-15438 http://www.dpdk.org/dev/patchwork/patch/15438/ Submitter: Jasvinder Singh Date: Fri, 26 Aug 2016 22:21:44 +0100 DPDK git baseline: e22856313fff2db12d8e132dad446bbf74cf29a5 Check patch error: 15437: WARNING: line over 80 characters #130: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:228: + /* Read(field0, field1), compute(field0, field1), write(field0, +field1) */ WARNING: line over 80 characters #154: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:252: + /* Read(field0, field1), compute(field0, field1), write(field0, +field1) */ WARNING: line over 80 characters #156: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:254: + uint64_t *pkt0_field0_ptr = RTE_MBUF_METADATA_UINT64_PTR(pkts[0], WARNING: line over 80 characters #158: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:256: + uint64_t *pkt1_field0_ptr = RTE_MBUF_METADATA_UINT64_PTR(pkts[1], WARNING: line over 80 characters #160: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:258: + uint64_t *pkt2_field0_ptr = RTE_MBUF_METADATA_UINT64_PTR(pkts[2], WARNING: line over 80 characters #162: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:260: + uint64_t *pkt3_field0_ptr = RTE_MBUF_METADATA_UINT64_PTR(pkts[3], WARNING: line over 80 characters #165: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:263: + uint64_t *pkt0_field1_ptr = RTE_MBUF_METADATA_UINT64_PTR(pkts[0], WARNING: line over 80 characters #167: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:265: + uint64_t *pkt1_field1_ptr = RTE_MBUF_METADATA_UINT64_PTR(pkts[1], WARNING: line over 80 characters #169: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:267: + uint64_t *pkt2_field1_ptr = RTE_MBUF_METADATA_UINT64_PTR(pkts[2], WARNING: line over 80 characters #171: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:269: + uint64_t *pkt3_field1_ptr = RTE_MBUF_METADATA_UINT64_PTR(pkts[3], WARNING: line over 80 characters #186: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:284: + *pkt0_field0_ptr = (pkt0_field0 & (~mask)) + (pkt0_field1 & mask); WARNING: line over 80 characters #187: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:285: + *pkt1_field0_ptr = (pkt1_field0 & (~mask)) + (pkt1_field1 & mask); WARNING: line over 80 characters #188: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:286: + *pkt2_field0_ptr = (pkt2_field0 & (~mask)) + (pkt2_field1 & mask); WARNING: line over 80 characters #189: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:287: + *pkt3_field0_ptr = (pkt3_field0 & (~mask)) + (pkt3_field1 & mask); WARNING: line over 80 characters #191: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:289: + *pkt0_field1_ptr = (pkt0_field0 & mask) + (pkt0_field1 & (~mask)); WARNING: line over 80 characters #192: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:290: + *pkt1_field1_ptr = (pkt1_field0 & mask) + (pkt1_field1 & (~mask)); WARNING: line over 80 characters #193: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:291: + *pkt2_field1_ptr = (pkt2_field0 & mask) + (pkt2_field1 & (~mask)); WARNING: line over 80 characters #194: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:292: + *pkt3_field1_ptr = (pkt3_field0 & mask) + (pkt3_field1 & (~mask)); WARNING: line over 80 characters #207: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:303: + pkt_work_dma(pkt, arg, dma_size, hash_enabled, lb_hash, port_pow2); ERROR: Macros with complex values should be enclosed in parenthesis #227: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:316: +#define port_in_ah_dma(dma_size, hash_enabled, lb_hash, port_pow2) +PKT_WORK_DMA(dma_size, hash_enabled, lb_hash, port_pow2) +PKT4_WORK_DMA(dma_size, hash_enabled, lb_hash, port_pow2) +PIPELINE_PORT_IN_AH(port_in_ah_dma_size##dma_size##_hash ##hash_enabled##_lb##lb_hash##_pw##port_pow2, + pkt_work_dma_size##dma_size##_hash##hash_enabled ##_lb##lb_hash##_pw##port_pow2, + pkt4_work_dma_size##dma_size##_hash##hash_enabled ##_lb##lb_hash##_pw##port_pow2) WARNING: line over 80 characters #228: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:317: +PKT_WORK_DMA(dma_size, hash_enabled, lb_hash, port_pow2) WARNING: line over 80 characters #229: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:318: +PKT4_WORK_DMA(dma_size, hash_enabled, lb_hash, port_pow2) WARNING: line over 80 characters #343: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:398: + case 8: return port_in_ah_lb_size8_hash1_lb1_pw1; WARNING: line over 80 characters #344: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:399: + case 16: return port_in_ah_lb_size16_hash1_lb1_pw1; WARNING: line over 80 characters #345: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:400: + case 24: return port_in_ah_lb_size24_hash1_lb1_pw1; WARNING: line over 80 characters #346: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:401: + case 32: return port_in_ah_lb_size32_hash1_lb1_pw1; WARNING: line over 80 characters #347: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:402: + case 40: return port_in_ah_lb_size40_hash1_lb1_pw1; WARNING: line over 80 characters #348: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:403: + case 48: return port_in_ah_lb_size48_hash1_lb1_pw1; WARNING: line over 80 characters #349: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:404: + case 56: return port_in_ah_lb_size56_hash1_lb1_pw1; WARNING: line over 80 characters #350: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:405: + case 64: return port_in_ah_lb_size64_hash1_lb1_pw1; WARNING: line over 80 characters #364: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:411: + case 8: return port_in_ah_lb_size8_hash1_lb1_pw0; WARNING: line over 80 characters #365: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:412: + case 16: return port_in_ah_lb_size16_hash1_lb1_pw0; WARNING: line over 80 characters #366: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:413: + case 24: return port_in_ah_lb_size24_hash1_lb1_pw0; WARNING: line over 80 characters #367: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:414: + case 32: return port_in_ah_lb_size32_hash1_lb1_pw0; WARNING: line over 80 characters #368: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:415: + case 40: return port_in_ah_lb_size40_hash1_lb1_pw0; WARNING: line over 80 characters #369: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:416: + case 48: return port_in_ah_lb_size48_hash1_lb1_pw0; WARNING: line over 80 characters #370: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:417: + case 56: return port_in_ah_lb_size56_hash1_lb1_pw0; WARNING: line over 80 characters #371: FILE: examples/ip_pipeline/pipeline/pipeline_passthrough_be.c:418: + case 64: return port_in_ah_lb_size64_hash1_lb1_pw0; total: 1 errors, 37 warnings, 554 lines checked /home/patchWorkOrg/patches/dpdk-dev-1-2-ip_pipeline-add-packet-fields-swap-action-to-pass-through-pipeline.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Compilation: OS: fedora Nic: niantic GCC: gcc_x86-64, 4.8.3 ICC:16.0.2 i686-native-linuxapp-icc: compile pass x86_64-native-linuxapp-gcc-combined: compile pass i686-native-linuxapp-gcc: compile pass x86_64-native-linuxapp-gcc: compile pass x86_64-native-linuxapp-icc: compile pass x86_64-native-linuxapp-gcc-debug: compile pass x86_64-native-linuxapp-gcc-shared: compile pass x86_64-native-linuxapp-clang: compile pass DPDK STV team