Test-Label: Intel Niantic on Fedora Test-Status: ERROR Patchwork ID: 15537 http://www.dpdk.org/dev/patchwork/patch/15537/ Submitter: souvikdey33 Date: Mon, 29 Aug 2016 19:02:40 -0400 DPDK git baseline: e22856313fff2db12d8e132dad446bbf74cf29a5 Check patch error: 15537: ERROR: trailing whitespace #43: FILE: drivers/net/virtio/virtio_ethdev.c:656: +static int $ ERROR: trailing whitespace #44: FILE: drivers/net/virtio/virtio_ethdev.c:657: +virtio_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) $ WARNING: please, no spaces at the start of a line #46: FILE: drivers/net/virtio/virtio_ethdev.c:659: + struct virtio_hw *hw = dev->data->dev_private;$ WARNING: please, no spaces at the start of a line #47: FILE: drivers/net/virtio/virtio_ethdev.c:660: + if (mtu < VIRTIO_MIN_RX_BUFSIZE || mtu > VIRTIO_MAX_RX_PKTLEN) {$ WARNING: suspect code indent for conditional statements (3, 11) #47: FILE: drivers/net/virtio/virtio_ethdev.c:660: + if (mtu < VIRTIO_MIN_RX_BUFSIZE || mtu > VIRTIO_MAX_RX_PKTLEN) { + PMD_INIT_LOG(ERR,"Mtu should be between 64 and 9728." ERROR: space required after that ',' (ctx:VxV) #48: FILE: drivers/net/virtio/virtio_ethdev.c:661: + PMD_INIT_LOG(ERR,"Mtu should be between 64 and 9728." ^ ERROR: code indent should use tabs where possible #49: FILE: drivers/net/virtio/virtio_ethdev.c:662: + return -EINVAL;$ WARNING: please, no spaces at the start of a line #49: FILE: drivers/net/virtio/virtio_ethdev.c:662: + return -EINVAL;$ WARNING: please, no spaces at the start of a line #50: FILE: drivers/net/virtio/virtio_ethdev.c:663: + }$ WARNING: please, no spaces at the start of a line #51: FILE: drivers/net/virtio/virtio_ethdev.c:664: + return 0;$ total: 4 errors, 6 warnings, 30 lines checked NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or scripts/cleanfile /home/patchWorkOrg/patches/dpdk-dev-v2-add-mtu-set-in-virtio.patch has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Compilation: OS: fedora Nic: niantic GCC: gcc_x86-64, 4.8.3 ICC:16.0.2 i686-native-linuxapp-icc: compile pass x86_64-native-linuxapp-gcc-combined: compile pass i686-native-linuxapp-gcc: compile pass x86_64-native-linuxapp-gcc: compile pass x86_64-native-linuxapp-icc: compile pass x86_64-native-linuxapp-gcc-debug: compile pass x86_64-native-linuxapp-gcc-shared: compile pass x86_64-native-linuxapp-clang: compile pass DPDK STV team