[dpdk-test-report] [PatchWork]|ERROR| pw15538 add mtu set in virtio

[sys_stv@intel.com]

[-- Attachment #1: Type: text/plain, Size: 2633 bytes --]


Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 15538
http://www.dpdk.org/dev/patchwork/patch/15538/
Submitter: souvikdey33 <sodey@sonusnet.com>
Date: Mon, 29 Aug 2016 22:49:47 +0000Fri, 26 Aug 2016 20:46:21 -0400 DPDK git baseline: e22856313fff2db12d8e132dad446bbf74cf29a5

Check patch error:
15538: 
ERROR: trailing whitespace
#50: FILE: drivers/net/virtio/virtio_ethdev.c:656:
+static int $

ERROR: trailing whitespace
#51: FILE: drivers/net/virtio/virtio_ethdev.c:657:
+virtio_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) $

WARNING: please, no spaces at the start of a line
#53: FILE: drivers/net/virtio/virtio_ethdev.c:659:
+   struct virtio_hw *hw = dev->data->dev_private;$

WARNING: please, no spaces at the start of a line
#54: FILE: drivers/net/virtio/virtio_ethdev.c:660:
+   if (mtu < VIRTIO_MIN_RX_BUFSIZE || mtu > VIRTIO_MAX_RX_PKTLEN) {$

WARNING: suspect code indent for conditional statements (3, 11)
#54: FILE: drivers/net/virtio/virtio_ethdev.c:660:
+   if (mtu < VIRTIO_MIN_RX_BUFSIZE || mtu > VIRTIO_MAX_RX_PKTLEN) {
+	   PMD_INIT_LOG(ERR,"Mtu should be between 64 and 9728."

ERROR: space required after that ',' (ctx:VxV)
#55: FILE: drivers/net/virtio/virtio_ethdev.c:661:
+	   PMD_INIT_LOG(ERR,"Mtu should be between 64 and 9728."
 	                   ^

ERROR: code indent should use tabs where possible
#56: FILE: drivers/net/virtio/virtio_ethdev.c:662:
+          return -EINVAL;$

WARNING: please, no spaces at the start of a line
#56: FILE: drivers/net/virtio/virtio_ethdev.c:662:
+          return -EINVAL;$

WARNING: please, no spaces at the start of a line
#57: FILE: drivers/net/virtio/virtio_ethdev.c:663:
+   }$

WARNING: please, no spaces at the start of a line
#58: FILE: drivers/net/virtio/virtio_ethdev.c:664:
+   return 0;$

ERROR: Missing Signed-off-by: line(s)

total: 5 errors, 6 warnings, 30 lines checked

NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
      scripts/cleanfile

/home/patchWorkOrg/patches/dpdk-dev-v1-add-mtu-set-in-virtio.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.


Compilation:
OS: fedora
Nic: niantic
GCC: gcc_x86-64, 4.8.3
ICC:16.0.2
i686-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-combined: compile pass
i686-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-debug: compile pass
x86_64-native-linuxapp-gcc-shared: compile pass
x86_64-native-linuxapp-clang: compile pass



DPDK STV team