[dpdk-test-report] [PatchWork]|ERROR| pw15146-15148 lib/librte_port: enable file descriptor port support

[dpdk-test-report] [PatchWork]|ERROR| pw15146-15148 lib/librte_port: enable file descriptor port support

[sys_stv]

[-- Attachment #1: Type: text/plain, Size: 2788 bytes --]


Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 15146-15148
http://www.dpdk.org/dev/patchwork/patch/15146/
Submitter: Jasvinder Singh <jasvinder.singh@intel.com>
Date: Fri,  5 Aug 2016 22:21:04 +0100
DPDK git baseline: 0b50aa7c079ccefaef70b8e406c4e7a09eddfa63

Check patch error:
15146: 
ERROR: Macros with complex values should be enclosed in parenthesis
#104: FILE: lib/librte_port/rte_port_fd.c:47:
+#define RTE_PORT_FD_READER_STATS_PKTS_IN_ADD(port, val) +	port->stats.n_pkts_in += val

ERROR: Macros with complex values should be enclosed in parenthesis
#106: FILE: lib/librte_port/rte_port_fd.c:49:
+#define RTE_PORT_FD_READER_STATS_PKTS_DROP_ADD(port, val) +	port->stats.n_pkts_drop += val

WARNING: space prohibited before semicolon
#190: FILE: lib/librte_port/rte_port_fd.c:133:
+	for ( ; i < n_pkts; i++)

ERROR: Macros with complex values should be enclosed in parenthesis
#231: FILE: lib/librte_port/rte_port_fd.c:174:
+#define RTE_PORT_FD_WRITER_STATS_PKTS_IN_ADD(port, val) +	port->stats.n_pkts_in += val

ERROR: Macros with complex values should be enclosed in parenthesis
#233: FILE: lib/librte_port/rte_port_fd.c:176:
+#define RTE_PORT_FD_WRITER_STATS_PKTS_DROP_ADD(port, val) +	port->stats.n_pkts_drop += val

WARNING: space prohibited before semicolon
#338: FILE: lib/librte_port/rte_port_fd.c:281:
+		for ( ; pkts_mask; ) {

ERROR: Macros with complex values should be enclosed in parenthesis
#401: FILE: lib/librte_port/rte_port_fd.c:344:
+#define RTE_PORT_FD_WRITER_NODROP_STATS_PKTS_IN_ADD(port, val) +	port->stats.n_pkts_in += val

ERROR: Macros with complex values should be enclosed in parenthesis
#403: FILE: lib/librte_port/rte_port_fd.c:346:
+#define RTE_PORT_FD_WRITER_NODROP_STATS_PKTS_DROP_ADD(port, val) +	port->stats.n_pkts_drop += val

WARNING: space prohibited before semicolon
#475: FILE: lib/librte_port/rte_port_fd.c:418:
+		for ( ; n_retries < p->n_retries; n_retries++) {

WARNING: space prohibited before semicolon
#521: FILE: lib/librte_port/rte_port_fd.c:464:
+		for ( ; pkts_mask; ) {

total: 6 errors, 4 warnings, 677 lines checked

/home/patchWorkOrg/patches/dpdk-dev-1-3-lib-librte_port-enable-file-descriptor-port-support.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.


Compilation:
OS: fedora
Nic: niantic
GCC: gcc_x86-64, 4.8.3
ICC:16.0.2
i686-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-combined: compile pass
i686-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-debug: compile pass
x86_64-native-linuxapp-gcc-shared: compile pass
x86_64-native-linuxapp-clang: compile pass



DPDK STV team