From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88D1A42B6F for ; Mon, 22 May 2023 10:20:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 60B76410D1; Mon, 22 May 2023 10:20:29 +0200 (CEST) Received: from mail-yb1-f226.google.com (mail-yb1-f226.google.com [209.85.219.226]) by mails.dpdk.org (Postfix) with ESMTP id 462C3410D1 for ; Mon, 22 May 2023 10:20:28 +0200 (CEST) Received: by mail-yb1-f226.google.com with SMTP id 3f1490d57ef6-b9e6ec482b3so8337960276.3 for ; Mon, 22 May 2023 01:20:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1684743627; x=1687335627; h=cc:to:from:subject:message-id:date:from:to:cc:subject:date :message-id:reply-to; bh=un0rUomNqTjQ/MLy1plJD6vpUxmNq8AQrjFMwph9dqQ=; b=SgaVBhG7idMtXpa41PZyJOt6/uedWtrxaVRO03Sr/tuuZVuf4QJwNLb+D9lqq8Y4yu 4C1LdTL/Z3kPVrf+9GrtpTP9nJQwkfAgyMrI80xh9dVhiW1Pise3UPl/0z9qoC45kVl5 qebFGp0uF0uWbDCPUuA9KFACZe+b5cyRuHzBw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684743627; x=1687335627; h=cc:to:from:subject:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=un0rUomNqTjQ/MLy1plJD6vpUxmNq8AQrjFMwph9dqQ=; b=akmYgxwej+XLA73VYQDzBOPEKT01yM0No9VjrK8shijmZLHv41cbmhlFlaRYhbB7Wm ctLwlNiEre6Yf+GKdwKCdpcF4y2VwG1D36Qioz527sGlZq7zAfLDlSZoBnx562gYrxns kqSj2QVRvY0GwiAUVXqz/DHgWiaVfw86b16IZeEV0fRD6S/wZOdYhqOprXFrssxKf8O4 DyNYbPaU7tgdXogPwxlHVwV7ESWBnPexD2dqSA1TbLRsrzf6jMWMjAbitfk7NEuRTLh/ tvbeP4QAfkkTsXu1z1r9qOUZ+gTHaVzvTMCTbj15HHVhq6hwpM1/fAZezdhnPP6g+fJ9 +KPA== X-Gm-Message-State: AC+VfDyW6XGU/Ja1TJvoYh3Z+/FM0ajiDSXDqE2hwu9KAJWPmsaJq9dq o3YtUjxHvCtvOuOQJayHJTCGf0+0/XBLRzmTDbeR3a1jZPgODXtddGP2IUnqVQba1Veogld7UA= = X-Google-Smtp-Source: ACHHUZ406u6FNhpDEW6cKHc1M8o9SVU2jHr4mP+SAy1+0CcfB3BQkmKicE/hw+BQUG0UqNGhsGlnG+WLubNb X-Received: by 2002:a25:cc3:0:b0:ba8:aaef:bc53 with SMTP id 186-20020a250cc3000000b00ba8aaefbc53mr10928961ybm.6.1684743627640; Mon, 22 May 2023 01:20:27 -0700 (PDT) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [2606:4100:3880:1234::84]) by smtp-relay.gmail.com with ESMTPS id j124-20020a253c82000000b00b9e8b4c8126sm1163926yba.11.2023.05.22.01.20.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 May 2023 01:20:27 -0700 (PDT) X-Relaying-Domain: iol.unh.edu Date: Mon, 22 May 2023 01:20:27 -0700 (PDT) Message-ID: <646b25cb.250a0220.cde05.1840SMTPIN_ADDED_MISSING@mx.google.com> Received: from [172.17.0.2] (unknown [172.18.0.34]) by postal.iol.unh.edu (Postfix) with ESMTP id 3A84E605246B; Mon, 22 May 2023 04:20:27 -0400 (EDT) Subject: |WARNING| pw127140-127144 [PATCH] [5/5] net/nfp: report packet type by Rx descriptor From: dpdklab@iol.unh.edu To: test-report@dpdk.org Cc: dpdk-test-reports@iol.unh.edu Content-Type: text/plain X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: iol-testing Test-Status: WARNING http://dpdk.org/patch/127140 _apply patch failure_ Submitter: Chaoyong He Date: Monday, May 22 2023 08:05:00 Applied on: CommitID:a399d7b5a994e335c446d4b15d7622d71dd8848c Apply patch set 127140-127144 failed: Checking patch drivers/net/nfp/flower/nfp_flower.c... Hunk #1 succeeded at 427 (offset -1 lines). Checking patch drivers/net/nfp/nfp_rxtx.c... Hunk #1 succeeded at 252 (offset 7 lines). Checking patch drivers/net/nfp/nfp_rxtx.h... error: while searching for: struct nfp_net_rx_desc { union { /* Freelist descriptor */ struct { uint16_t dma_addr_hi; uint8_t spare; uint8_t dd; uint32_t dma_addr_lo; } __rte_packed fld; /* RX descriptor */ struct { uint16_t data_len; uint8_t reserved; uint8_t meta_len_dd; uint16_t flags; uint16_t vlan; } __rte_packed rxd; uint32_t vals[2]; }; }; error: patch failed: drivers/net/nfp/nfp_rxtx.h:172 Applied patch drivers/net/nfp/flower/nfp_flower.c cleanly. Applied patch drivers/net/nfp/nfp_rxtx.c cleanly. Applying patch drivers/net/nfp/nfp_rxtx.h with 1 reject... Rejected hunk #1. hint: Use 'git am --show-current-patch' to see the failed patch diff a/drivers/net/nfp/nfp_rxtx.h b/drivers/net/nfp/nfp_rxtx.h (rejected hunks) @@ -172,25 +172,25 @@ struct nfp_net_txq { struct nfp_net_rx_desc { union { - /* Freelist descriptor */ + /** Freelist descriptor. */ struct { - uint16_t dma_addr_hi; - uint8_t spare; - uint8_t dd; - - uint32_t dma_addr_lo; + uint16_t dma_addr_hi; /**< High bits of buffer address. */ + uint8_t spare; /**< Reserved, must be zero. */ + uint8_t dd; /**< Whether descriptor available. */ + uint32_t dma_addr_lo; /**< Low bits of buffer address. */ } __rte_packed fld; - /* RX descriptor */ + /** RX descriptor. */ struct { - uint16_t data_len; - uint8_t reserved; - uint8_t meta_len_dd; + uint16_t data_len; /**< Length of frame + metadata. */ + uint8_t reserved; /**< Reserved, must be zero. */ + uint8_t meta_len_dd; /**< Length of metadata + done flag. */ - uint16_t flags; - uint16_t vlan; + uint16_t flags; /**< RX flags. */ + uint16_t offload_info; /**< Offloading info. */ } __rte_packed rxd; + /** Reserved. */ uint32_t vals[2]; }; }; Checking patch drivers/net/nfp/nfp_rxtx.c... error: drivers/net/nfp/nfp_rxtx.c: does not match index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch drivers/net/nfp/nfp_common.c... Hunk #1 succeeded at 191 (offset -110 lines). Checking patch drivers/net/nfp/nfp_common.h... Hunk #1 succeeded at 427 (offset 4 lines). Checking patch drivers/net/nfp/nfp_ctrl.h... Hunk #1 succeeded at 224 (offset 10 lines). Checking patch drivers/net/nfp/nfp_ethdev.c... Hunk #1 succeeded at 64 (offset 7 lines). Hunk #2 succeeded at 156 (offset 7 lines). Checking patch drivers/net/nfp/nfp_rxtx.c... error: drivers/net/nfp/nfp_rxtx.c: does not match index Checking patch drivers/net/nfp/nfp_rxtx.h... error: while searching for: #define PCIE_DESC_RX_L4_CSUM_OK (PCIE_DESC_RX_TCP_CSUM_OK | \ PCIE_DESC_RX_UDP_CSUM_OK) struct nfp_net_rx_desc { union { /** Freelist descriptor. */ error: patch failed: drivers/net/nfp/nfp_rxtx.h:170 Applied patch drivers/net/nfp/nfp_common.c cleanly. Applied patch drivers/net/nfp/nfp_common.h cleanly. Applied patch drivers/net/nfp/nfp_ctrl.h cleanly. Applied patch drivers/net/nfp/nfp_ethdev.c cleanly. Applying patch drivers/net/nfp/nfp_rxtx.h with 1 reject... Rejected hunk #1. hint: Use 'git am --show-current-patch' to see the failed patch diff a/drivers/net/nfp/nfp_rxtx.h b/drivers/net/nfp/nfp_rxtx.h (rejected hunks) @@ -170,6 +170,89 @@ struct nfp_net_txq { #define PCIE_DESC_RX_L4_CSUM_OK (PCIE_DESC_RX_TCP_CSUM_OK | \ PCIE_DESC_RX_UDP_CSUM_OK) +/* + * The bit format and map of nfp packet type for rxd.offload_info in Rx descriptor. + * + * Bit format about nfp packet type refers to the following: + * --------------------------------- + * 1 0 + * 5 4 3 2 1 0 9 8 7 6 5 4 3 2 1 0 + * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ + * | |tunnel | l3 | l4 | + * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ + * + * Bit map about nfp packet type refers to the following: + * + * L4: bit 0~2, used for layer 4 or inner layer 4. + * 000: NFP_NET_PTYPE_L4_NONE + * 001: NFP_NET_PTYPE_L4_TCP + * 010: NFP_NET_PTYPE_L4_UDP + * 011: NFP_NET_PTYPE_L4_FRAG + * 100: NFP_NET_PTYPE_L4_NONFRAG + * 101: NFP_NET_PTYPE_L4_ICMP + * 110: NFP_NET_PTYPE_L4_SCTP + * 111: reserved + * + * L3: bit 3~5, used for layer 3 or inner layer 3. + * 000: NFP_NET_PTYPE_L3_NONE + * 001: NFP_NET_PTYPE_L3_IPV6 + * 010: NFP_NET_PTYPE_L3_IPV4 + * 011: NFP_NET_PTYPE_L3_IPV4_EXT + * 100: NFP_NET_PTYPE_L3_IPV6_EXT + * 101: NFP_NET_PTYPE_L3_IPV4_EXT_UNKNOWN + * 110: NFP_NET_PTYPE_L3_IPV6_EXT_UNKNOWN + * 111: reserved + * + * Tunnel: bit 6~9, used for tunnel. + * 0000: NFP_NET_PTYPE_TUNNEL_NONE + * 0001: NFP_NET_PTYPE_TUNNEL_VXLAN + * 0100: NFP_NET_PTYPE_TUNNEL_NVGRE + * 0101: NFP_NET_PTYPE_TUNNEL_GENEVE + * 0010, 0011, 0110~1111: reserved + * + * Reserved: bit 10~15, used for extension. + */ + +/* Mask and offset about nfp packet type based on the bit map above. */ +#define NFP_NET_PTYPE_L4_MASK 0x0007 +#define NFP_NET_PTYPE_L3_MASK 0x0038 +#define NFP_NET_PTYPE_TUNNEL_MASK 0x03c0 + +#define NFP_NET_PTYPE_L4_OFFSET 0 +#define NFP_NET_PTYPE_L3_OFFSET 3 +#define NFP_NET_PTYPE_TUNNEL_OFFSET 6 + +/* Case about nfp packet type based on the bit map above. */ +#define NFP_NET_PTYPE_L4_NONE 0 +#define NFP_NET_PTYPE_L4_TCP 1 +#define NFP_NET_PTYPE_L4_UDP 2 +#define NFP_NET_PTYPE_L4_FRAG 3 +#define NFP_NET_PTYPE_L4_NONFRAG 4 +#define NFP_NET_PTYPE_L4_ICMP 5 +#define NFP_NET_PTYPE_L4_SCTP 6 + +#define NFP_NET_PTYPE_L3_NONE 0 +#define NFP_NET_PTYPE_L3_IPV6 1 +#define NFP_NET_PTYPE_L3_IPV4 2 +#define NFP_NET_PTYPE_L3_IPV4_EXT 3 +#define NFP_NET_PTYPE_L3_IPV6_EXT 4 +#define NFP_NET_PTYPE_L3_IPV4_EXT_UNKNOWN 5 +#define NFP_NET_PTYPE_L3_IPV6_EXT_UNKNOWN 6 + +#define NFP_NET_PTYPE_TUNNEL_NONE 0 +#define NFP_NET_PTYPE_TUNNEL_VXLAN 1 +#define NFP_NET_PTYPE_TUNNEL_NVGRE 4 +#define NFP_NET_PTYPE_TUNNEL_GENEVE 5 + +#define NFP_PTYPE2RTE(tunnel, type) ((tunnel) ? RTE_PTYPE_INNER_##type : RTE_PTYPE_##type) + +/* Record NFP packet type parsed from rxd.offload_info. */ +struct nfp_ptype_parsed { + uint8_t l4_ptype; /**< Packet type of layer 4, or inner layer 4. */ + uint8_t l3_ptype; /**< Packet type of layer 3, or inner layer 3. */ + uint8_t tunnel_ptype; /**< Packet type of tunnel. */ +}; + struct nfp_net_rx_desc { union { /** Freelist descriptor. */ https://lab.dpdk.org/results/dashboard/patchsets/26322/ UNH-IOL DPDK Community Lab