From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BB3742BA7 for ; Fri, 26 May 2023 09:40:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9799440A89; Fri, 26 May 2023 09:40:34 +0200 (CEST) Received: from mail-qv1-f98.google.com (mail-qv1-f98.google.com [209.85.219.98]) by mails.dpdk.org (Postfix) with ESMTP id 1A4CC40A89 for ; Fri, 26 May 2023 09:40:33 +0200 (CEST) Received: by mail-qv1-f98.google.com with SMTP id 6a1803df08f44-623a6c15aacso6978266d6.0 for ; Fri, 26 May 2023 00:40:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1685086832; x=1687678832; h=cc:to:from:subject:message-id:date:from:to:cc:subject:date :message-id:reply-to; bh=UYxLqx2lWsxxis8o7dxXAsAqBGL6YHjpz3BBaoUuU7o=; b=UMOKXVejCy/gEh5BoIoJgbaUZP2ybseT7koI39/8fogla6HnXae5En2+hW9IXqxbMR abHnTsIGhrgxrwdETnXaR8j3eNTEjU0ZMKy5aq8nnjrPaDL0uKTUM329rnvfG8r9ABvK D5A4T6TT93g1HWvWTqqmNSRhD/b2Labyd7Mw0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685086832; x=1687678832; h=cc:to:from:subject:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UYxLqx2lWsxxis8o7dxXAsAqBGL6YHjpz3BBaoUuU7o=; b=NeLptQ23bu3Hpe1D02sC1rdamzUtWFso4YnvLgjpowQ6FRD5Ld28fv+1tJey4FfS6j I/KdvKR3c2fLpV6pCGceX1msHKP3IViEs1CQlkGvg5AcSgnfh+SeePDe0pVqYhFRpfpm Y+m0sPfhUt0qjvTJrm8vHkxx4cSJQ8WaLGNvFZmT/vNpQ20bg0B+JwQL8b/DlkJVus7U pQi1TlK+CrgNFQ2PG9u0fOQxMNnwsWMsGrPuWSweBxdHOS6bg6VfyK1vpHipdqBAhBtj ucK7PyLOv02eKp9y7Qe7xdlvirZOoqXA5WzHOPxkA76IubzJrGgsaV2OWxtPRVjYSPfP uDFw== X-Gm-Message-State: AC+VfDytF9qAvWuxjB4Q7TB0tM9itONBItaa3PUWBiVlQrKwyR3IsDm7 MVnupmjWFvHz5tAfPrLE1Cj++iH4OQFa6yXf0x4/SVTQb64EbEqQoknQr7SboVbz8+TXTeIn0A= = X-Google-Smtp-Source: ACHHUZ4C5BKC+G/g1bBopbHcRNftRmeDeGahSVECvEpmdH5nc0ipgoayIdC8RIkO01Nzs5gxSpuPcj66rDrS X-Received: by 2002:a05:6214:d8a:b0:616:5a74:4577 with SMTP id e10-20020a0562140d8a00b006165a744577mr808280qve.11.1685086832577; Fri, 26 May 2023 00:40:32 -0700 (PDT) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [2606:4100:3880:1234::84]) by smtp-relay.gmail.com with ESMTPS id p15-20020a0ccb8f000000b0061acfeb8a7asm120120qvk.69.2023.05.26.00.40.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 May 2023 00:40:32 -0700 (PDT) X-Relaying-Domain: iol.unh.edu Date: Fri, 26 May 2023 00:40:32 -0700 (PDT) Message-ID: <64706270.0c0a0220.4aabd.448dSMTPIN_ADDED_MISSING@mx.google.com> Received: from [172.17.0.2] (unknown [172.18.0.34]) by postal.iol.unh.edu (Postfix) with ESMTP id 48960605246B; Fri, 26 May 2023 03:40:32 -0400 (EDT) Subject: |WARNING| pw127534 [PATCH] [v4] crypto/qat: support to enable insecure algorithms From: dpdklab@iol.unh.edu To: test-report@dpdk.org Cc: dpdk-test-reports@iol.unh.edu Content-Type: text/plain X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: iol-testing Test-Status: WARNING http://dpdk.org/patch/127534 _apply patch failure_ Submitter: Vikash Poddar Date: Friday, May 26 2023 06:48:32 Applied on: CommitID:c9df59bcc9bec67783de98486879594e52bdc418 Apply patch set 127534 failed: Checking patch app/test/test_cryptodev_asym.c... Checking patch doc/guides/cryptodevs/qat.rst... error: while searching for: To use this feature the user must set the devarg on process start as a device additional devarg:: -a 03:01.1,qat_sym_cipher_crc_enable=1 Running QAT PMD with Intel IPSEC MB library for symmetric precomputes function error: patch failed: doc/guides/cryptodevs/qat.rst:314 Checking patch drivers/common/qat/qat_device.c... Hunk #1 succeeded at 365 (offset -6 lines). Checking patch drivers/common/qat/qat_device.h... error: while searching for: #define QAT_DEV_NAME_MAX_LEN 64 #define QAT_IPSEC_MB_LIB "qat_ipsec_mb_lib" #define SYM_ENQ_THRESHOLD_NAME "qat_sym_enq_threshold" #define ASYM_ENQ_THRESHOLD_NAME "qat_asym_enq_threshold" #define COMP_ENQ_THRESHOLD_NAME "qat_comp_enq_threshold" #define SYM_CIPHER_CRC_ENABLE_NAME "qat_sym_cipher_crc_enable" #define QAT_CMD_SLICE_MAP "qat_cmd_slice_disable" #define QAT_CMD_SLICE_MAP_POS 5 #define MAX_QP_THRESHOLD_SIZE 32 /** error: patch failed: drivers/common/qat/qat_device.h:17 Checking patch drivers/crypto/qat/dev/qat_crypto_pmd_gen2.c... Checking patch drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c... Checking patch drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c... Checking patch drivers/crypto/qat/dev/qat_sym_pmd_gen1.c... Checking patch drivers/crypto/qat/qat_asym.c... Checking patch drivers/crypto/qat/qat_crypto.h... Checking patch drivers/crypto/qat/qat_sym.c... Hunk #2 succeeded at 282 (offset -4 lines). Applied patch app/test/test_cryptodev_asym.c cleanly. Applying patch doc/guides/cryptodevs/qat.rst with 1 reject... Rejected hunk #1. Applied patch drivers/common/qat/qat_device.c cleanly. Applying patch drivers/common/qat/qat_device.h with 1 reject... Rejected hunk #1. Applied patch drivers/crypto/qat/dev/qat_crypto_pmd_gen2.c cleanly. Applied patch drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c cleanly. Applied patch drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c cleanly. Applied patch drivers/crypto/qat/dev/qat_sym_pmd_gen1.c cleanly. Applied patch drivers/crypto/qat/qat_asym.c cleanly. Applied patch drivers/crypto/qat/qat_crypto.h cleanly. Applied patch drivers/crypto/qat/qat_sym.c cleanly. hint: Use 'git am --show-current-patch' to see the failed patch diff a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst (rejected hunks) @@ -314,7 +314,21 @@ If not supported, the CRC is calculated by the QAT PMD using the NET CRC API. To use this feature the user must set the devarg on process start as a device additional devarg:: - -a 03:01.1,qat_sym_cipher_crc_enable=1 + -a 03:01.1,qat_sym_cipher_crc_enable=1 + + +Running QAT PMD with insecure crypto algorithms +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +A few insecure crypto algorithms are deprecated from QAT drivers. This needs to be reflected in DPDK QAT PMD. +DPDK QAT PMD has by default disabled all the insecure crypto algorithms from Gen 1,2,3 and 4. +A PMD parameter is used to enable the capability. + +- qat_legacy_capa + +To use this feature the user must set the parameter on process start as a device additional parameter:: + + -a b1:01.2,qat_legacy_capa=1 Running QAT PMD with Intel IPSEC MB library for symmetric precomputes function diff a/drivers/common/qat/qat_device.h b/drivers/common/qat/qat_device.h (rejected hunks) @@ -17,13 +17,14 @@ #define QAT_DEV_NAME_MAX_LEN 64 +#define QAT_LEGACY_CAPA "qat_legacy_capa" #define QAT_IPSEC_MB_LIB "qat_ipsec_mb_lib" #define SYM_ENQ_THRESHOLD_NAME "qat_sym_enq_threshold" #define ASYM_ENQ_THRESHOLD_NAME "qat_asym_enq_threshold" #define COMP_ENQ_THRESHOLD_NAME "qat_comp_enq_threshold" #define SYM_CIPHER_CRC_ENABLE_NAME "qat_sym_cipher_crc_enable" #define QAT_CMD_SLICE_MAP "qat_cmd_slice_disable" -#define QAT_CMD_SLICE_MAP_POS 5 +#define QAT_CMD_SLICE_MAP_POS 6 #define MAX_QP_THRESHOLD_SIZE 32 /** https://lab.dpdk.org/results/dashboard/patchsets/26406/ UNH-IOL DPDK Community Lab