From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55C8D42C34 for ; Mon, 5 Jun 2023 11:02:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49AB44003C; Mon, 5 Jun 2023 11:02:49 +0200 (CEST) Received: from mail-oa1-f100.google.com (mail-oa1-f100.google.com [209.85.160.100]) by mails.dpdk.org (Postfix) with ESMTP id 04EBF4003C for ; Mon, 5 Jun 2023 11:02:47 +0200 (CEST) Received: by mail-oa1-f100.google.com with SMTP id 586e51a60fabf-19f9f11ba3dso4207187fac.2 for ; Mon, 05 Jun 2023 02:02:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1685955767; x=1688547767; h=cc:to:from:subject:message-id:date:from:to:cc:subject:date :message-id:reply-to; bh=zmB0chqrtG82F8UQhG3nRpGV1LbNlMl0UmKlK0AR9aI=; b=gescSgiAs+wI/KLViH9uxbAyxM7bgLmLmN2TwOFxfKQHTmV7ur4TkCmF5m6GSXh5UK sxLxBJRU8WsXptwbBUwdi/LytWeOrUr/kNTPWHeJXzwDeJ7nVD5uHx4x/BRZZxtX6mOw rqTcNf6q878U81ChEUvcwY+MPYgGjI+GEb9yY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685955767; x=1688547767; h=cc:to:from:subject:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zmB0chqrtG82F8UQhG3nRpGV1LbNlMl0UmKlK0AR9aI=; b=lxWIy///jAYEBOJVw5RqpD0ayUC53TtTcTX+Zatt3tLtRSGWDXf9P2NzqDdCyP+u7l E7WuKXJyv5diMoFGLqAOqrlI8EYGw0DRhz4dd+6XCyE7lak2OluZAhn/cxrXMvj1bhiq tn1WSLM/EnqSDxFnkN2TrTphEpZGgcguVGxi2VTil1bid/c5TFhCqKqrmJvS2GTbfRfk ycco9xHhc6W+vR7IejujKwkQ1xfodyNG3p7eN0KM/k57zvC0ZgKRVDkrjMHR+4vTVl/3 nSl2BTsRdl+bXjhcdfjIebDnwwlUgiGbPjV6RoQkCSGvoL5oKtA53geXyMD4zU5yOBu/ KgCQ== X-Gm-Message-State: AC+VfDzGb5WvrcndHDHSTbrqFNZb7RDys/gSR/wA/NU7Hp26ige6TyQu 4gFKhdu4KwBAqHKawRV/y+oxgfuBnJc2fm1+NzRkq+3mMkGnZOGiC9HQkg== X-Google-Smtp-Source: ACHHUZ712lt73hIgwNMEM0ZJvQuxBPi3Tw/I8rRrzvxfttiT8HC4GJaLun9i7fperH+dBrzv0utvCDpRPRQ6 X-Received: by 2002:a05:6870:3844:b0:196:2f14:b1c7 with SMTP id z4-20020a056870384400b001962f14b1c7mr7704691oal.37.1685955767404; Mon, 05 Jun 2023 02:02:47 -0700 (PDT) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [132.177.123.84]) by smtp-relay.gmail.com with ESMTPS id k22-20020a4abd96000000b00558cbd3a703sm128389oop.26.2023.06.05.02.02.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Jun 2023 02:02:47 -0700 (PDT) X-Relaying-Domain: iol.unh.edu Date: Mon, 05 Jun 2023 02:02:47 -0700 (PDT) Message-ID: <647da4b7.4a0a0220.90548.33a1SMTPIN_ADDED_MISSING@mx.google.com> Received: from [172.17.0.2] (unknown [172.18.0.34]) by postal.iol.unh.edu (Postfix) with ESMTP id D85CF605246B; Mon, 5 Jun 2023 05:02:46 -0400 (EDT) Subject: |WARNING| pw128099 [PATCH] [v2] common/cnxk: fix mbox timeout due to deadlock From: dpdklab@iol.unh.edu To: test-report@dpdk.org Cc: dpdk-test-reports@iol.unh.edu Content-Type: text/plain X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: iol-testing Test-Status: WARNING http://dpdk.org/patch/128099 _apply patch failure_ Submitter: Harman Kalra Date: Monday, June 05 2023 08:44:23 Applied on: CommitID:abaa473297cf21cb81e5348185a7694ae2f221e7 Apply patch set 128099 failed: Checking patch drivers/common/cnxk/roc_dev.c... error: while searching for: /* PF handling messages from VF */ static void roc_vf_pf_mbox_handle_msg(void *param) { uint16_t vf, max_vf, max_bits; struct dev *dev = param; error: patch failed: drivers/common/cnxk/roc_dev.c:348 error: while searching for: max_vf = max_bits * MAX_VFPF_DWORD_BITS; for (vf = 0; vf < max_vf; vf++) { if (dev->intr.bits[vf / max_bits] & BIT_ULL(vf % max_bits)) { plt_base_dbg("Process vf:%d request (pf:%d, vf:%d)", vf, dev->pf, dev->vf); /* VF initiated down messages */ vf_pf_process_msgs(dev, vf); /* VF replies to PF's UP messages */ vf_pf_process_up_msgs(dev, vf); dev->intr.bits[vf / max_bits] &= ~(BIT_ULL(vf % max_bits)); } } dev->timer_set = 0; } /* IRQ to PF from VF - PF context (interrupt thread) */ static void roc_vf_pf_mbox_irq(void *param) { struct dev *dev = param; bool alarm_set = false; uint64_t intr; int vfpf; for (vfpf = 0; vfpf < MAX_VFPF_DWORD_BITS; ++vfpf) { intr = plt_read64(dev->bar2 + RVU_PF_VFPF_MBOX_INTX(vfpf)); if (!intr) error: patch failed: drivers/common/cnxk/roc_dev.c:357 Hunk #4 succeeded at 384 (offset -12 lines). Hunk #5 succeeded at 691 (offset -34 lines). Hunk #6 succeeded at 772 (offset -34 lines). Hunk #7 succeeded at 815 (offset -34 lines). Hunk #8 succeeded at 826 (offset -34 lines). Hunk #9 succeeded at 835 (offset -34 lines). Hunk #10 succeeded at 926 (offset -34 lines). Hunk #11 succeeded at 1228 (offset -35 lines). Hunk #12 succeeded at 1329 (offset -35 lines). Hunk #13 succeeded at 1394 (offset -35 lines). Checking patch drivers/common/cnxk/roc_dev_priv.h... Checking patch drivers/common/cnxk/roc_nix.h... error: while searching for: uintptr_t meta_mempool; TAILQ_ENTRY(roc_nix) next; #define ROC_NIX_MEM_SZ (6 * 1056) uint8_t reserved[ROC_NIX_MEM_SZ] __plt_cache_aligned; } __plt_cache_aligned; error: patch failed: drivers/common/cnxk/roc_nix.h:483 Applying patch drivers/common/cnxk/roc_dev.c with 2 rejects... Hunk #1 applied cleanly. Rejected hunk #2. Rejected hunk #3. Hunk #4 applied cleanly. Hunk #5 applied cleanly. Hunk #6 applied cleanly. Hunk #7 applied cleanly. Hunk #8 applied cleanly. Hunk #9 applied cleanly. Hunk #10 applied cleanly. Hunk #11 applied cleanly. Hunk #12 applied cleanly. Hunk #13 applied cleanly. Applied patch drivers/common/cnxk/roc_dev_priv.h cleanly. Applying patch drivers/common/cnxk/roc_nix.h with 1 reject... Rejected hunk #1. hint: Use 'git am --show-current-patch' to see the failed patch diff a/drivers/common/cnxk/roc_dev.c b/drivers/common/cnxk/roc_dev.c (rejected hunks) @@ -348,7 +354,7 @@ vf_pf_process_up_msgs(struct dev *dev, uint16_t vf) /* PF handling messages from VF */ static void -roc_vf_pf_mbox_handle_msg(void *param) +roc_vf_pf_mbox_handle_msg(void *param, dev_intr_t *intr) { uint16_t vf, max_vf, max_bits; struct dev *dev = param; @@ -357,29 +363,30 @@ roc_vf_pf_mbox_handle_msg(void *param) max_vf = max_bits * MAX_VFPF_DWORD_BITS; for (vf = 0; vf < max_vf; vf++) { - if (dev->intr.bits[vf / max_bits] & BIT_ULL(vf % max_bits)) { + if (intr->bits[vf / max_bits] & BIT_ULL(vf % max_bits)) { plt_base_dbg("Process vf:%d request (pf:%d, vf:%d)", vf, dev->pf, dev->vf); /* VF initiated down messages */ vf_pf_process_msgs(dev, vf); /* VF replies to PF's UP messages */ vf_pf_process_up_msgs(dev, vf); - dev->intr.bits[vf / max_bits] &= - ~(BIT_ULL(vf % max_bits)); + intr->bits[vf / max_bits] &= ~(BIT_ULL(vf % max_bits)); } } - dev->timer_set = 0; } /* IRQ to PF from VF - PF context (interrupt thread) */ static void roc_vf_pf_mbox_irq(void *param) { + bool signal_thread = false; struct dev *dev = param; - bool alarm_set = false; + dev_intr_t intrb; uint64_t intr; - int vfpf; + int vfpf, sz; + sz = sizeof(intrb.bits[0]) * MAX_VFPF_DWORD_BITS; + memset(intrb.bits, 0, sz); for (vfpf = 0; vfpf < MAX_VFPF_DWORD_BITS; ++vfpf) { intr = plt_read64(dev->bar2 + RVU_PF_VFPF_MBOX_INTX(vfpf)); if (!intr) diff a/drivers/common/cnxk/roc_nix.h b/drivers/common/cnxk/roc_nix.h (rejected hunks) @@ -483,7 +483,7 @@ struct roc_nix { uintptr_t meta_mempool; TAILQ_ENTRY(roc_nix) next; -#define ROC_NIX_MEM_SZ (6 * 1056) +#define ROC_NIX_MEM_SZ (6 * 1070) uint8_t reserved[ROC_NIX_MEM_SZ] __plt_cache_aligned; } __plt_cache_aligned; https://lab.dpdk.org/results/dashboard/patchsets/26530/ UNH-IOL DPDK Community Lab