From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 550CC42C40 for ; Tue, 6 Jun 2023 15:13:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 50BA740697; Tue, 6 Jun 2023 15:13:44 +0200 (CEST) Received: from mail-pf1-f227.google.com (mail-pf1-f227.google.com [209.85.210.227]) by mails.dpdk.org (Postfix) with ESMTP id B78A940697 for ; Tue, 6 Jun 2023 15:13:42 +0200 (CEST) Received: by mail-pf1-f227.google.com with SMTP id d2e1a72fcca58-64d18d772bdso6781416b3a.3 for ; Tue, 06 Jun 2023 06:13:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1686057222; x=1688649222; h=cc:to:from:subject:message-id:date:from:to:cc:subject:date :message-id:reply-to; bh=9mfIfylaa6O0K26TM6K44n5+EKVD3dyXxmqKtA0d9xg=; b=HcUQ5+JdvLKotgpCTGnsP0fOte6FZWJ73ZoBM8GZn4YciM5Rl7MuPnjd8TqHIBLOrj w7rgDffQVPvAn+6+QFw9yuUxxDSFJI11RnKXNUlwjYjd5FUHVkuRODoBNaE0ZJA0y7kK dL4O4q3+Yr+LFRfuTyjsx4uNNYpdYGTDIhPL8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686057222; x=1688649222; h=cc:to:from:subject:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9mfIfylaa6O0K26TM6K44n5+EKVD3dyXxmqKtA0d9xg=; b=gLtM4JvF+KBvMHwFPOXQ3x01endOcJeNr8ItY0GJ3Q2HMQ7OlaM37CKz/JUFPXIFbe AonvUyiUBK1M61EdYPVDg5ZDEPazOoL/mSfmunZYmUbyHJa3EuEHBT2v5NQFj1hKkcKZ PIuoX1jtems1oPd3oicfeh1h1bAgu91qjn9WyiCDojjWVZKcEQEAzGX378bR9njEt4mY H+v2A8Bg1J4j/Lw+TSD2mbvAjK85PenZhVK+ohQ9T+133+hct/f/UdDFHPVGIgtOVXY+ GlnlHmH3nzUrZ3kHcG3mR4m6fefeHzOMtwmOLii9FKU82Yi4QjBbyVrvPwXXafeYPDMQ YtoA== X-Gm-Message-State: AC+VfDzfRB5thSfIPmy5O7A5Zq6UubXtXI6cIs2/NWY2lGenuGHBb/9C pNS6vdCXG8Iue7ypgLVI1UM9Dl+VDcnlqRvNe1vGyA9/jKuFLw8isVaKXg== X-Google-Smtp-Source: ACHHUZ5zdNv6K4qKv0rqopwgi/BKeHgRs+KWV15tKvgW9Txm6ZVlfGHu2BCrvoTRP2MpsapvT4r0yM5UUVIN X-Received: by 2002:a05:6a20:431a:b0:10f:9bea:5a61 with SMTP id h26-20020a056a20431a00b0010f9bea5a61mr3422961pzk.2.1686057221929; Tue, 06 Jun 2023 06:13:41 -0700 (PDT) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [132.177.123.84]) by smtp-relay.gmail.com with ESMTPS id 80-20020a621853000000b0064fcf1ea167sm1070329pfy.6.2023.06.06.06.13.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Jun 2023 06:13:41 -0700 (PDT) X-Relaying-Domain: iol.unh.edu Date: Tue, 06 Jun 2023 06:13:41 -0700 (PDT) Message-ID: <647f3105.620a0220.44e56.ea2dSMTPIN_ADDED_MISSING@mx.google.com> Received: from [172.17.0.2] (unknown [172.18.0.34]) by postal.iol.unh.edu (Postfix) with ESMTP id 2F50D605246B; Tue, 6 Jun 2023 09:13:41 -0400 (EDT) Subject: |WARNING| pw128166-128191 [PATCH] [v5, 26/26] vhost: add VDUSE device stop From: dpdklab@iol.unh.edu To: test-report@dpdk.org Cc: dpdk-test-reports@iol.unh.edu Content-Type: text/plain X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: iol-testing Test-Status: WARNING http://dpdk.org/patch/128166 _apply patch failure_ Submitter: Maxime Coquelin Date: Tuesday, June 06 2023 08:18:52 Applied on: CommitID:38689022f609a290645c7027084aee720c1fcf91 Apply patch set 128166-128191 failed: Checking patch lib/vhost/iotlb.c... Checking patch lib/vhost/iotlb.h... Checking patch lib/vhost/vhost.c... Hunk #1 succeeded at 63 (offset -4 lines). Hunk #2 succeeded at 75 (offset -4 lines). Hunk #3 succeeded at 85 (offset -4 lines). error: while searching for: vhost_free_async_mem(vq); rte_rwlock_write_unlock(&vq->access_lock); rte_free(vq->batch_copy_elems); vhost_user_iotlb_destroy(vq); rte_free(vq->log_cache); rte_free(vq); } error: patch failed: lib/vhost/vhost.c:401 Hunk #5 succeeded at 575 (offset -3 lines). Hunk #6 succeeded at 595 (offset -3 lines). error: while searching for: dev->virtqueue[i] = vq; init_vring_queue(dev, vq, i); rte_rwlock_init(&vq->access_lock); vq->avail_wrap_counter = 1; vq->used_wrap_counter = 1; vq->signalled_used_valid = false; error: patch failed: lib/vhost/vhost.c:635 Hunk #8 succeeded at 793 (offset -4 lines). Checking patch lib/vhost/vhost.h... Hunk #1 succeeded at 302 (offset -3 lines). Hunk #2 succeeded at 476 (offset -3 lines). Checking patch lib/vhost/vhost_user.c... error: while searching for: if (!vva) return RTE_VHOST_MSG_RESULT_ERR; for (i = 0; i < dev->nr_vring; i++) { struct vhost_virtqueue *vq = dev->virtqueue[i]; if (!vq) continue; vhost_user_iotlb_cache_insert(dev, vq, imsg->iova, vva, len, imsg->perm); if (is_vring_iotlb(dev, vq, imsg)) { rte_rwlock_write_lock(&vq->access_lock); translate_ring_addresses(&dev, &vq); error: patch failed: lib/vhost/vhost_user.c:2639 error: while searching for: } break; case VHOST_IOTLB_INVALIDATE: for (i = 0; i < dev->nr_vring; i++) { struct vhost_virtqueue *vq = dev->virtqueue[i]; if (!vq) continue; vhost_user_iotlb_cache_remove(dev, vq, imsg->iova, imsg->size); if (is_vring_iotlb(dev, vq, imsg)) { rte_rwlock_write_lock(&vq->access_lock); vring_invalidate(dev, vq); error: patch failed: lib/vhost/vhost_user.c:2657 Hunk #8 succeeded at 2676 (offset 2 lines). Applied patch lib/vhost/iotlb.c cleanly. Applied patch lib/vhost/iotlb.h cleanly. Applying patch lib/vhost/vhost.c with 2 rejects... Hunk #1 applied cleanly. Hunk #2 applied cleanly. Hunk #3 applied cleanly. Rejected hunk #4. Hunk #5 applied cleanly. Hunk #6 applied cleanly. Rejected hunk #7. Hunk #8 applied cleanly. Applied patch lib/vhost/vhost.h cleanly. Applying patch lib/vhost/vhost_user.c with 2 rejects... Hunk #1 applied cleanly. Hunk #2 applied cleanly. Hunk #3 applied cleanly. Hunk #4 applied cleanly. Hunk #5 applied cleanly. Rejected hunk #6. Rejected hunk #7. Hunk #8 applied cleanly. hint: Use 'git am --show-current-patch' to see the failed patch diff a/lib/vhost/vhost.c b/lib/vhost/vhost.c (rejected hunks) @@ -401,7 +401,6 @@ free_vq(struct virtio_net *dev, struct vhost_virtqueue *vq) vhost_free_async_mem(vq); rte_rwlock_write_unlock(&vq->access_lock); rte_free(vq->batch_copy_elems); - vhost_user_iotlb_destroy(vq); rte_free(vq->log_cache); rte_free(vq); } @@ -635,6 +632,7 @@ alloc_vring_queue(struct virtio_net *dev, uint32_t vring_idx) dev->virtqueue[i] = vq; init_vring_queue(dev, vq, i); rte_rwlock_init(&vq->access_lock); + rte_rwlock_init(&vq->iotlb_lock); vq->avail_wrap_counter = 1; vq->used_wrap_counter = 1; vq->signalled_used_valid = false; diff a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c (rejected hunks) @@ -2639,15 +2641,14 @@ vhost_user_iotlb_msg(struct virtio_net **pdev, if (!vva) return RTE_VHOST_MSG_RESULT_ERR; + vhost_user_iotlb_cache_insert(dev, imsg->iova, vva, len, imsg->perm); + for (i = 0; i < dev->nr_vring; i++) { struct vhost_virtqueue *vq = dev->virtqueue[i]; if (!vq) continue; - vhost_user_iotlb_cache_insert(dev, vq, imsg->iova, vva, - len, imsg->perm); - if (is_vring_iotlb(dev, vq, imsg)) { rte_rwlock_write_lock(&vq->access_lock); translate_ring_addresses(&dev, &vq); @@ -2657,15 +2658,14 @@ vhost_user_iotlb_msg(struct virtio_net **pdev, } break; case VHOST_IOTLB_INVALIDATE: + vhost_user_iotlb_cache_remove(dev, imsg->iova, imsg->size); + for (i = 0; i < dev->nr_vring; i++) { struct vhost_virtqueue *vq = dev->virtqueue[i]; if (!vq) continue; - vhost_user_iotlb_cache_remove(dev, vq, imsg->iova, - imsg->size); - if (is_vring_iotlb(dev, vq, imsg)) { rte_rwlock_write_lock(&vq->access_lock); vring_invalidate(dev, vq); Checking patch lib/vhost/iotlb.c... error: lib/vhost/iotlb.c: does not match index Checking patch lib/vhost/iotlb.h... error: lib/vhost/iotlb.h: does not match index Checking patch lib/vhost/vhost_user.c... error: lib/vhost/vhost_user.c: does not match index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/iotlb.c... error: lib/vhost/iotlb.c: does not match index Checking patch lib/vhost/iotlb.h... error: lib/vhost/iotlb.h: does not match index Checking patch lib/vhost/vhost.h... error: lib/vhost/vhost.h: does not match index Checking patch lib/vhost/vhost_user.c... error: lib/vhost/vhost_user.c: does not match index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/vhost.c... error: lib/vhost/vhost.c: does not match index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/socket.c... Hunk #1 succeeded at 221 (offset -2 lines). Checking patch lib/vhost/vhost.c... error: lib/vhost/vhost.c: does not match index Checking patch lib/vhost/vhost.h... error: lib/vhost/vhost.h: does not match index Checking patch lib/vhost/vhost_user.c... error: lib/vhost/vhost_user.c: does not match index Checking patch lib/vhost/vhost_user.h... Applied patch lib/vhost/socket.c cleanly. Applied patch lib/vhost/vhost_user.h cleanly. hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/iotlb.c... error: lib/vhost/iotlb.c: does not match index Checking patch lib/vhost/vhost.h... error: lib/vhost/vhost.h: does not match index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/vhost.c... error: lib/vhost/vhost.c: does not match index Checking patch lib/vhost/vhost.h... error: lib/vhost/vhost.h: does not match index Checking patch lib/vhost/vhost_user.c... error: lib/vhost/vhost_user.c: does not match index Checking patch lib/vhost/vhost_user.h... error: lib/vhost/vhost_user.h: does not match index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/vhost.c... error: lib/vhost/vhost.c: does not match index Checking patch lib/vhost/vhost.h... error: lib/vhost/vhost.h: does not match index Checking patch lib/vhost/vhost_user.c... error: lib/vhost/vhost_user.c: does not match index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch doc/guides/prog_guide/vhost_lib.rst... error: while searching for: Inject the offloaded interrupt received by the 'guest_notify' callback, into the vhost device's queue. Vhost-user Implementations -------------------------- error: patch failed: doc/guides/prog_guide/vhost_lib.rst:339 Checking patch doc/guides/rel_notes/release_23_07.rst... error: while searching for: rte_vhost_notify_guest(), is added to raise the interrupt outside of the fast path. Removed Items ------------- error: patch failed: doc/guides/rel_notes/release_23_07.rst:62 Checking patch lib/vhost/rte_vhost.h... Hunk #1 succeeded at 588 (offset -21 lines). Checking patch lib/vhost/socket.c... error: lib/vhost/socket.c: does not match index Checking patch lib/vhost/version.map... error: while searching for: # added in 23.07 rte_vhost_notify_guest; }; INTERNAL { error: patch failed: lib/vhost/version.map:107 Applying patch doc/guides/prog_guide/vhost_lib.rst with 1 reject... Rejected hunk #1. Applying patch doc/guides/rel_notes/release_23_07.rst with 1 reject... Rejected hunk #1. Applied patch lib/vhost/rte_vhost.h cleanly. Applying patch lib/vhost/version.map with 1 reject... Rejected hunk #1. hint: Use 'git am --show-current-patch' to see the failed patch diff a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vhost_lib.rst (rejected hunks) @@ -339,6 +339,10 @@ The following is an overview of some key Vhost API functions: Inject the offloaded interrupt received by the 'guest_notify' callback, into the vhost device's queue. +* ``rte_vhost_driver_set_max_queue_num(const char *path, uint32_t max_queue_pairs)`` + + Set the maximum number of queue pairs supported by the device. + Vhost-user Implementations -------------------------- diff a/doc/guides/rel_notes/release_23_07.rst b/doc/guides/rel_notes/release_23_07.rst (rejected hunks) @@ -62,6 +62,11 @@ New Features rte_vhost_notify_guest(), is added to raise the interrupt outside of the fast path. +* **Added Vhost API to set maximum queue pairs supported.** + + Introduced ``rte_vhost_driver_set_max_queue_num()`` to be able to limit the + maximum number of supported queue pairs, required for VDUSE support. + Removed Items ------------- diff a/lib/vhost/version.map b/lib/vhost/version.map (rejected hunks) @@ -107,6 +107,7 @@ EXPERIMENTAL { # added in 23.07 rte_vhost_notify_guest; + rte_vhost_driver_set_max_queue_num; }; INTERNAL { Checking patch lib/vhost/meson.build... Checking patch lib/vhost/vhost.h... error: lib/vhost/vhost.h: does not match index Checking patch lib/vhost/virtio_net_ctrl.c... Checking patch lib/vhost/virtio_net_ctrl.h... Applied patch lib/vhost/meson.build cleanly. Applied patch lib/vhost/virtio_net_ctrl.c cleanly. Applied patch lib/vhost/virtio_net_ctrl.h cleanly. hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/meson.build... error: lib/vhost/meson.build: does not match index Checking patch lib/vhost/socket.c... error: lib/vhost/socket.c: does not match index Checking patch lib/vhost/vduse.c... Checking patch lib/vhost/vduse.h... Checking patch lib/vhost/vhost.h... error: lib/vhost/vhost.h: does not match index Applied patch lib/vhost/vduse.c cleanly. Applied patch lib/vhost/vduse.h cleanly. hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/vduse.c... error: lib/vhost/vduse.c: does not exist in index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/vduse.c... error: lib/vhost/vduse.c: does not exist in index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/vduse.c... error: lib/vhost/vduse.c: does not exist in index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/vduse.c... error: lib/vhost/vduse.c: does not exist in index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/vduse.c... error: lib/vhost/vduse.c: does not exist in index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/vduse.c... error: lib/vhost/vduse.c: does not exist in index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/vduse.c... error: lib/vhost/vduse.c: does not exist in index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/vduse.c... error: lib/vhost/vduse.c: does not exist in index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch lib/vhost/vduse.c... error: lib/vhost/vduse.c: does not exist in index hint: Use 'git am --show-current-patch' to see the failed patch Checking patch doc/guides/rel_notes/release_23_07.rst... error: while searching for: Introduced ``rte_vhost_driver_set_max_queue_num()`` to be able to limit the maximum number of supported queue pairs, required for VDUSE support. Removed Items ------------- error: patch failed: doc/guides/rel_notes/release_23_07.rst:67 Checking patch lib/vhost/vduse.c... error: lib/vhost/vduse.c: does not exist in index Applying patch doc/guides/rel_notes/release_23_07.rst with 1 reject... Rejected hunk #1. hint: Use 'git am --show-current-patch' to see the failed patch diff a/doc/guides/rel_notes/release_23_07.rst b/doc/guides/rel_notes/release_23_07.rst (rejected hunks) @@ -67,6 +67,13 @@ New Features Introduced ``rte_vhost_driver_set_max_queue_num()`` to be able to limit the maximum number of supported queue pairs, required for VDUSE support. +* **Added VDUSE support into Vhost library.** + + VDUSE aims at implementing vDPA devices in userspace. It can be used as an + alternative to Vhost-user when using Vhost-vDPA, but also enable providing a + virtio-net netdev to the host when using Virtio-vDPA driver. A limitation in + this release is the lack of reconnection support. + Removed Items ------------- https://lab.dpdk.org/results/dashboard/patchsets/26546/ UNH-IOL DPDK Community Lab