* |WARNING| pw128198 [PATCH] [v5] crypto/qat: default to IPsec MB for computations
@ 2023-06-09 21:47 dpdklab
0 siblings, 0 replies; 3+ messages in thread
From: dpdklab @ 2023-06-09 21:47 UTC (permalink / raw)
To: test-report; +Cc: dpdk-test-reports
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/128198
_apply patch failure_
Submitter: Brian Dooley <brian.dooley@intel.com>
Date: Tuesday, June 06 2023 10:28:20
Applied on: CommitID:38689022f609a290645c7027084aee720c1fcf91
Apply patch set 128198 failed:
Checking patch doc/guides/cryptodevs/qat.rst...
error: while searching for:
-a 03:01.1,qat_sym_cipher_crc_enable=1
Running QAT PMD with Intel IPSEC MB library for symmetric precomputes function
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The QAT PMD use Openssl library for partial hash calculation in symmetirc precomputes function by
default, the following parameter is allow QAT PMD switch over to multi-buffer job API if Intel
IPSEC MB library installed on system.
- qat_ipsec_mb_lib
To use this feature the user must set the parameter on process start as a device additional parameter::
-a 03:01.1,qat_ipsec_mb_lib=1
Device and driver naming
error: patch failed: doc/guides/cryptodevs/qat.rst:317
Checking patch drivers/common/qat/meson.build...
Checking patch drivers/common/qat/qat_device.c...
Hunk #1 succeeded at 365 (offset -6 lines).
Checking patch drivers/common/qat/qat_device.h...
error: while searching for:
#define QAT_DEV_NAME_MAX_LEN 64
#define QAT_IPSEC_MB_LIB "qat_ipsec_mb_lib"
#define SYM_ENQ_THRESHOLD_NAME "qat_sym_enq_threshold"
#define ASYM_ENQ_THRESHOLD_NAME "qat_asym_enq_threshold"
#define COMP_ENQ_THRESHOLD_NAME "qat_comp_enq_threshold"
#define SYM_CIPHER_CRC_ENABLE_NAME "qat_sym_cipher_crc_enable"
#define QAT_CMD_SLICE_MAP "qat_cmd_slice_disable"
#define QAT_CMD_SLICE_MAP_POS 5
#define MAX_QP_THRESHOLD_SIZE 32
/**
error: patch failed: drivers/common/qat/qat_device.h:17
Checking patch drivers/crypto/qat/dev/qat_crypto_pmd_gens.h...
Checking patch drivers/crypto/qat/qat_sym.c...
error: while searching for:
SYM_CIPHER_CRC_ENABLE_NAME))
internals->cipher_crc_offload_enable =
qat_dev_cmd_param[i].val;
if (!strcmp(qat_dev_cmd_param[i].name, QAT_IPSEC_MB_LIB))
qat_ipsec_mb_lib = qat_dev_cmd_param[i].val;
if (!strcmp(qat_dev_cmd_param[i].name, QAT_CMD_SLICE_MAP))
slice_map = qat_dev_cmd_param[i].val;
i++;
error: patch failed: drivers/crypto/qat/qat_sym.c:283
Checking patch drivers/crypto/qat/qat_sym.h...
Hunk #1 succeeded at 163 (offset -1 lines).
Hunk #2 succeeded at 221 (offset -1 lines).
error: while searching for:
if (op->sess_type == RTE_CRYPTO_OP_SECURITY_SESSION) {
ctx = SECURITY_GET_SESS_PRIV(op->sym->session);
if (ctx == NULL || ctx->bpi_ctx == NULL)
continue;
if (ctx->qat_cmd != ICP_QAT_FW_LA_CMD_CIPHER_CRC)
error: patch failed: drivers/crypto/qat/qat_sym.h:280
error: while searching for:
} else {
rx_op->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
if (sess->bpi_ctx) {
qat_bpicipher_postprocess(sess, rx_op);
#ifdef RTE_LIB_SECURITY
if (is_docsis_sec && sess->qat_cmd !=
error: patch failed: drivers/crypto/qat/qat_sym.h:329
Checking patch drivers/crypto/qat/qat_sym_session.c...
Hunk #2 succeeded at 32 (offset -1 lines).
error: while searching for:
OSSL_PROVIDER_unload(default_lib);
}
#endif
extern int qat_ipsec_mb_lib;
#define ETH_CRC32_POLYNOMIAL 0x04c11db7
#define ETH_CRC32_INIT_VAL 0xffffffff
error: patch failed: drivers/crypto/qat/qat_sym_session.c:66
Hunk #4 succeeded at 133 (offset -12 lines).
Hunk #5 succeeded at 184 (offset -12 lines).
Hunk #6 succeeded at 278 (offset -12 lines).
Hunk #7 succeeded at 447 (offset -12 lines).
Hunk #8 succeeded at 477 (offset -12 lines).
Hunk #9 succeeded at 579 (offset -12 lines).
Hunk #10 succeeded at 601 (offset -12 lines).
Hunk #11 succeeded at 616 (offset -12 lines).
Hunk #12 succeeded at 1241 (offset -52 lines).
Hunk #13 succeeded at 1346 (offset -52 lines).
Hunk #14 succeeded at 1392 (offset -52 lines).
Hunk #15 succeeded at 1547 (offset -52 lines).
Hunk #16 succeeded at 1559 (offset -52 lines).
Hunk #17 succeeded at 1643 (offset -52 lines).
Hunk #18 succeeded at 1683 (offset -52 lines).
Hunk #19 succeeded at 1796 (offset -52 lines).
Hunk #20 succeeded at 1807 (offset -52 lines).
Hunk #21 succeeded at 2213 (offset -55 lines).
Hunk #22 succeeded at 2240 (offset -55 lines).
Hunk #23 succeeded at 2265 (offset -55 lines).
Hunk #24 succeeded at 2290 (offset -55 lines).
Hunk #25 succeeded at 2315 (offset -55 lines).
Hunk #26 succeeded at 2359 (offset -55 lines).
Hunk #27 succeeded at 2381 (offset -55 lines).
Hunk #28 succeeded at 2446 (offset -55 lines).
Hunk #29 succeeded at 2751 (offset -193 lines).
Hunk #30 succeeded at 2764 (offset -193 lines).
Hunk #31 succeeded at 2780 (offset -193 lines).
Checking patch drivers/crypto/qat/qat_sym_session.h...
Hunk #2 succeeded at 126 (offset -11 lines).
Applying patch doc/guides/cryptodevs/qat.rst with 1 reject...
Rejected hunk #1.
Applied patch drivers/common/qat/meson.build cleanly.
Applied patch drivers/common/qat/qat_device.c cleanly.
Applying patch drivers/common/qat/qat_device.h with 1 reject...
Rejected hunk #1.
Applied patch drivers/crypto/qat/dev/qat_crypto_pmd_gens.h cleanly.
Applying patch drivers/crypto/qat/qat_sym.c with 1 reject...
Hunk #1 applied cleanly.
Hunk #2 applied cleanly.
Hunk #3 applied cleanly.
Rejected hunk #4.
Applying patch drivers/crypto/qat/qat_sym.h with 2 rejects...
Hunk #1 applied cleanly.
Hunk #2 applied cleanly.
Rejected hunk #3.
Rejected hunk #4.
Applying patch drivers/crypto/qat/qat_sym_session.c with 1 reject...
Hunk #1 applied cleanly.
Hunk #2 applied cleanly.
Rejected hunk #3.
Hunk #4 applied cleanly.
Hunk #5 applied cleanly.
Hunk #6 applied cleanly.
Hunk #7 applied cleanly.
Hunk #8 applied cleanly.
Hunk #9 applied cleanly.
Hunk #10 applied cleanly.
Hunk #11 applied cleanly.
Hunk #12 applied cleanly.
Hunk #13 applied cleanly.
Hunk #14 applied cleanly.
Hunk #15 applied cleanly.
Hunk #16 applied cleanly.
Hunk #17 applied cleanly.
Hunk #18 applied cleanly.
Hunk #19 applied cleanly.
Hunk #20 applied cleanly.
Hunk #21 applied cleanly.
Hunk #22 applied cleanly.
Hunk #23 applied cleanly.
Hunk #24 applied cleanly.
Hunk #25 applied cleanly.
Hunk #26 applied cleanly.
Hunk #27 applied cleanly.
Hunk #28 applied cleanly.
Hunk #29 applied cleanly.
Hunk #30 applied cleanly.
Hunk #31 applied cleanly.
Applied patch drivers/crypto/qat/qat_sym_session.h cleanly.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst (rejected hunks)
@@ -317,18 +317,12 @@ To use this feature the user must set the devarg on process start as a device ad
-a 03:01.1,qat_sym_cipher_crc_enable=1
-Running QAT PMD with Intel IPSEC MB library for symmetric precomputes function
+Running QAT PMD with Intel IPsec MB library for symmetric precomputes function
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-The QAT PMD use Openssl library for partial hash calculation in symmetirc precomputes function by
-default, the following parameter is allow QAT PMD switch over to multi-buffer job API if Intel
-IPSEC MB library installed on system.
-
-- qat_ipsec_mb_lib
-
-To use this feature the user must set the parameter on process start as a device additional parameter::
-
- -a 03:01.1,qat_ipsec_mb_lib=1
+The QAT PMD uses Intel IPsec MB library for partial hash calculation in symmetric precomputes function by
+default, the minimum required version of IPsec MB library is v1.4. If this version of IPsec is not met it
+will fallback to use OpenSSL
Device and driver naming
diff a/drivers/common/qat/qat_device.h b/drivers/common/qat/qat_device.h (rejected hunks)
@@ -17,13 +17,12 @@
#define QAT_DEV_NAME_MAX_LEN 64
-#define QAT_IPSEC_MB_LIB "qat_ipsec_mb_lib"
#define SYM_ENQ_THRESHOLD_NAME "qat_sym_enq_threshold"
#define ASYM_ENQ_THRESHOLD_NAME "qat_asym_enq_threshold"
#define COMP_ENQ_THRESHOLD_NAME "qat_comp_enq_threshold"
#define SYM_CIPHER_CRC_ENABLE_NAME "qat_sym_cipher_crc_enable"
#define QAT_CMD_SLICE_MAP "qat_cmd_slice_disable"
-#define QAT_CMD_SLICE_MAP_POS 5
+#define QAT_CMD_SLICE_MAP_POS 4
#define MAX_QP_THRESHOLD_SIZE 32
/**
diff a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c (rejected hunks)
@@ -283,8 +286,6 @@ qat_sym_dev_create(struct qat_pci_device *qat_pci_dev,
SYM_CIPHER_CRC_ENABLE_NAME))
internals->cipher_crc_offload_enable =
qat_dev_cmd_param[i].val;
- if (!strcmp(qat_dev_cmd_param[i].name, QAT_IPSEC_MB_LIB))
- qat_ipsec_mb_lib = qat_dev_cmd_param[i].val;
if (!strcmp(qat_dev_cmd_param[i].name, QAT_CMD_SLICE_MAP))
slice_map = qat_dev_cmd_param[i].val;
i++;
diff a/drivers/crypto/qat/qat_sym.h b/drivers/crypto/qat/qat_sym.h (rejected hunks)
@@ -280,7 +299,11 @@ qat_sym_preprocess_requests(void **ops, uint16_t nb_ops)
if (op->sess_type == RTE_CRYPTO_OP_SECURITY_SESSION) {
ctx = SECURITY_GET_SESS_PRIV(op->sym->session);
+#ifdef RTE_QAT_OPENSSL
if (ctx == NULL || ctx->bpi_ctx == NULL)
+#else
+ if (ctx == NULL || ctx->mb_mgr == NULL)
+#endif
continue;
if (ctx->qat_cmd != ICP_QAT_FW_LA_CMD_CIPHER_CRC)
@@ -329,7 +352,11 @@ qat_sym_process_response(void **op, uint8_t *resp, void *op_cookie,
} else {
rx_op->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
+#ifdef RTE_QAT_OPENSSL
if (sess->bpi_ctx) {
+#else
+ if (sess->mb_mgr) {
+#endif
qat_bpicipher_postprocess(sess, rx_op);
#ifdef RTE_LIB_SECURITY
if (is_docsis_sec && sess->qat_cmd !=
diff a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c (rejected hunks)
@@ -66,8 +66,7 @@ static void ossl_legacy_provider_unload(void)
OSSL_PROVIDER_unload(default_lib);
}
#endif
-
-extern int qat_ipsec_mb_lib;
+#endif
#define ETH_CRC32_POLYNOMIAL 0x04c11db7
#define ETH_CRC32_INIT_VAL 0xffffffff
https://lab.dpdk.org/results/dashboard/patchsets/26549/
UNH-IOL DPDK Community Lab
^ permalink raw reply [flat|nested] 3+ messages in thread
* |WARNING| pw128198 [PATCH] [v5] crypto/qat: default to IPsec MB for computations
@ 2023-06-08 21:38 dpdklab
0 siblings, 0 replies; 3+ messages in thread
From: dpdklab @ 2023-06-08 21:38 UTC (permalink / raw)
To: test-report; +Cc: dpdk-test-reports
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/128198
_apply patch failure_
Submitter: Brian Dooley <brian.dooley@intel.com>
Date: Tuesday, June 06 2023 10:28:20
Applied on: CommitID:38689022f609a290645c7027084aee720c1fcf91
Apply patch set 128198 failed:
Checking patch doc/guides/cryptodevs/qat.rst...
error: while searching for:
-a 03:01.1,qat_sym_cipher_crc_enable=1
Running QAT PMD with Intel IPSEC MB library for symmetric precomputes function
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The QAT PMD use Openssl library for partial hash calculation in symmetirc precomputes function by
default, the following parameter is allow QAT PMD switch over to multi-buffer job API if Intel
IPSEC MB library installed on system.
- qat_ipsec_mb_lib
To use this feature the user must set the parameter on process start as a device additional parameter::
-a 03:01.1,qat_ipsec_mb_lib=1
Device and driver naming
error: patch failed: doc/guides/cryptodevs/qat.rst:317
Checking patch drivers/common/qat/meson.build...
Checking patch drivers/common/qat/qat_device.c...
Hunk #1 succeeded at 365 (offset -6 lines).
Checking patch drivers/common/qat/qat_device.h...
error: while searching for:
#define QAT_DEV_NAME_MAX_LEN 64
#define QAT_IPSEC_MB_LIB "qat_ipsec_mb_lib"
#define SYM_ENQ_THRESHOLD_NAME "qat_sym_enq_threshold"
#define ASYM_ENQ_THRESHOLD_NAME "qat_asym_enq_threshold"
#define COMP_ENQ_THRESHOLD_NAME "qat_comp_enq_threshold"
#define SYM_CIPHER_CRC_ENABLE_NAME "qat_sym_cipher_crc_enable"
#define QAT_CMD_SLICE_MAP "qat_cmd_slice_disable"
#define QAT_CMD_SLICE_MAP_POS 5
#define MAX_QP_THRESHOLD_SIZE 32
/**
error: patch failed: drivers/common/qat/qat_device.h:17
Checking patch drivers/crypto/qat/dev/qat_crypto_pmd_gens.h...
Checking patch drivers/crypto/qat/qat_sym.c...
error: while searching for:
SYM_CIPHER_CRC_ENABLE_NAME))
internals->cipher_crc_offload_enable =
qat_dev_cmd_param[i].val;
if (!strcmp(qat_dev_cmd_param[i].name, QAT_IPSEC_MB_LIB))
qat_ipsec_mb_lib = qat_dev_cmd_param[i].val;
if (!strcmp(qat_dev_cmd_param[i].name, QAT_CMD_SLICE_MAP))
slice_map = qat_dev_cmd_param[i].val;
i++;
error: patch failed: drivers/crypto/qat/qat_sym.c:283
Checking patch drivers/crypto/qat/qat_sym.h...
Hunk #1 succeeded at 163 (offset -1 lines).
Hunk #2 succeeded at 221 (offset -1 lines).
error: while searching for:
if (op->sess_type == RTE_CRYPTO_OP_SECURITY_SESSION) {
ctx = SECURITY_GET_SESS_PRIV(op->sym->session);
if (ctx == NULL || ctx->bpi_ctx == NULL)
continue;
if (ctx->qat_cmd != ICP_QAT_FW_LA_CMD_CIPHER_CRC)
error: patch failed: drivers/crypto/qat/qat_sym.h:280
error: while searching for:
} else {
rx_op->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
if (sess->bpi_ctx) {
qat_bpicipher_postprocess(sess, rx_op);
#ifdef RTE_LIB_SECURITY
if (is_docsis_sec && sess->qat_cmd !=
error: patch failed: drivers/crypto/qat/qat_sym.h:329
Checking patch drivers/crypto/qat/qat_sym_session.c...
Hunk #2 succeeded at 32 (offset -1 lines).
error: while searching for:
OSSL_PROVIDER_unload(default_lib);
}
#endif
extern int qat_ipsec_mb_lib;
#define ETH_CRC32_POLYNOMIAL 0x04c11db7
#define ETH_CRC32_INIT_VAL 0xffffffff
error: patch failed: drivers/crypto/qat/qat_sym_session.c:66
Hunk #4 succeeded at 133 (offset -12 lines).
Hunk #5 succeeded at 184 (offset -12 lines).
Hunk #6 succeeded at 278 (offset -12 lines).
Hunk #7 succeeded at 447 (offset -12 lines).
Hunk #8 succeeded at 477 (offset -12 lines).
Hunk #9 succeeded at 579 (offset -12 lines).
Hunk #10 succeeded at 601 (offset -12 lines).
Hunk #11 succeeded at 616 (offset -12 lines).
Hunk #12 succeeded at 1241 (offset -52 lines).
Hunk #13 succeeded at 1346 (offset -52 lines).
Hunk #14 succeeded at 1392 (offset -52 lines).
Hunk #15 succeeded at 1547 (offset -52 lines).
Hunk #16 succeeded at 1559 (offset -52 lines).
Hunk #17 succeeded at 1643 (offset -52 lines).
Hunk #18 succeeded at 1683 (offset -52 lines).
Hunk #19 succeeded at 1796 (offset -52 lines).
Hunk #20 succeeded at 1807 (offset -52 lines).
Hunk #21 succeeded at 2213 (offset -55 lines).
Hunk #22 succeeded at 2240 (offset -55 lines).
Hunk #23 succeeded at 2265 (offset -55 lines).
Hunk #24 succeeded at 2290 (offset -55 lines).
Hunk #25 succeeded at 2315 (offset -55 lines).
Hunk #26 succeeded at 2359 (offset -55 lines).
Hunk #27 succeeded at 2381 (offset -55 lines).
Hunk #28 succeeded at 2446 (offset -55 lines).
Hunk #29 succeeded at 2751 (offset -193 lines).
Hunk #30 succeeded at 2764 (offset -193 lines).
Hunk #31 succeeded at 2780 (offset -193 lines).
Checking patch drivers/crypto/qat/qat_sym_session.h...
Hunk #2 succeeded at 126 (offset -11 lines).
Applying patch doc/guides/cryptodevs/qat.rst with 1 reject...
Rejected hunk #1.
Applied patch drivers/common/qat/meson.build cleanly.
Applied patch drivers/common/qat/qat_device.c cleanly.
Applying patch drivers/common/qat/qat_device.h with 1 reject...
Rejected hunk #1.
Applied patch drivers/crypto/qat/dev/qat_crypto_pmd_gens.h cleanly.
Applying patch drivers/crypto/qat/qat_sym.c with 1 reject...
Hunk #1 applied cleanly.
Hunk #2 applied cleanly.
Hunk #3 applied cleanly.
Rejected hunk #4.
Applying patch drivers/crypto/qat/qat_sym.h with 2 rejects...
Hunk #1 applied cleanly.
Hunk #2 applied cleanly.
Rejected hunk #3.
Rejected hunk #4.
Applying patch drivers/crypto/qat/qat_sym_session.c with 1 reject...
Hunk #1 applied cleanly.
Hunk #2 applied cleanly.
Rejected hunk #3.
Hunk #4 applied cleanly.
Hunk #5 applied cleanly.
Hunk #6 applied cleanly.
Hunk #7 applied cleanly.
Hunk #8 applied cleanly.
Hunk #9 applied cleanly.
Hunk #10 applied cleanly.
Hunk #11 applied cleanly.
Hunk #12 applied cleanly.
Hunk #13 applied cleanly.
Hunk #14 applied cleanly.
Hunk #15 applied cleanly.
Hunk #16 applied cleanly.
Hunk #17 applied cleanly.
Hunk #18 applied cleanly.
Hunk #19 applied cleanly.
Hunk #20 applied cleanly.
Hunk #21 applied cleanly.
Hunk #22 applied cleanly.
Hunk #23 applied cleanly.
Hunk #24 applied cleanly.
Hunk #25 applied cleanly.
Hunk #26 applied cleanly.
Hunk #27 applied cleanly.
Hunk #28 applied cleanly.
Hunk #29 applied cleanly.
Hunk #30 applied cleanly.
Hunk #31 applied cleanly.
Applied patch drivers/crypto/qat/qat_sym_session.h cleanly.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst (rejected hunks)
@@ -317,18 +317,12 @@ To use this feature the user must set the devarg on process start as a device ad
-a 03:01.1,qat_sym_cipher_crc_enable=1
-Running QAT PMD with Intel IPSEC MB library for symmetric precomputes function
+Running QAT PMD with Intel IPsec MB library for symmetric precomputes function
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-The QAT PMD use Openssl library for partial hash calculation in symmetirc precomputes function by
-default, the following parameter is allow QAT PMD switch over to multi-buffer job API if Intel
-IPSEC MB library installed on system.
-
-- qat_ipsec_mb_lib
-
-To use this feature the user must set the parameter on process start as a device additional parameter::
-
- -a 03:01.1,qat_ipsec_mb_lib=1
+The QAT PMD uses Intel IPsec MB library for partial hash calculation in symmetric precomputes function by
+default, the minimum required version of IPsec MB library is v1.4. If this version of IPsec is not met it
+will fallback to use OpenSSL
Device and driver naming
diff a/drivers/common/qat/qat_device.h b/drivers/common/qat/qat_device.h (rejected hunks)
@@ -17,13 +17,12 @@
#define QAT_DEV_NAME_MAX_LEN 64
-#define QAT_IPSEC_MB_LIB "qat_ipsec_mb_lib"
#define SYM_ENQ_THRESHOLD_NAME "qat_sym_enq_threshold"
#define ASYM_ENQ_THRESHOLD_NAME "qat_asym_enq_threshold"
#define COMP_ENQ_THRESHOLD_NAME "qat_comp_enq_threshold"
#define SYM_CIPHER_CRC_ENABLE_NAME "qat_sym_cipher_crc_enable"
#define QAT_CMD_SLICE_MAP "qat_cmd_slice_disable"
-#define QAT_CMD_SLICE_MAP_POS 5
+#define QAT_CMD_SLICE_MAP_POS 4
#define MAX_QP_THRESHOLD_SIZE 32
/**
diff a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c (rejected hunks)
@@ -283,8 +286,6 @@ qat_sym_dev_create(struct qat_pci_device *qat_pci_dev,
SYM_CIPHER_CRC_ENABLE_NAME))
internals->cipher_crc_offload_enable =
qat_dev_cmd_param[i].val;
- if (!strcmp(qat_dev_cmd_param[i].name, QAT_IPSEC_MB_LIB))
- qat_ipsec_mb_lib = qat_dev_cmd_param[i].val;
if (!strcmp(qat_dev_cmd_param[i].name, QAT_CMD_SLICE_MAP))
slice_map = qat_dev_cmd_param[i].val;
i++;
diff a/drivers/crypto/qat/qat_sym.h b/drivers/crypto/qat/qat_sym.h (rejected hunks)
@@ -280,7 +299,11 @@ qat_sym_preprocess_requests(void **ops, uint16_t nb_ops)
if (op->sess_type == RTE_CRYPTO_OP_SECURITY_SESSION) {
ctx = SECURITY_GET_SESS_PRIV(op->sym->session);
+#ifdef RTE_QAT_OPENSSL
if (ctx == NULL || ctx->bpi_ctx == NULL)
+#else
+ if (ctx == NULL || ctx->mb_mgr == NULL)
+#endif
continue;
if (ctx->qat_cmd != ICP_QAT_FW_LA_CMD_CIPHER_CRC)
@@ -329,7 +352,11 @@ qat_sym_process_response(void **op, uint8_t *resp, void *op_cookie,
} else {
rx_op->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
+#ifdef RTE_QAT_OPENSSL
if (sess->bpi_ctx) {
+#else
+ if (sess->mb_mgr) {
+#endif
qat_bpicipher_postprocess(sess, rx_op);
#ifdef RTE_LIB_SECURITY
if (is_docsis_sec && sess->qat_cmd !=
diff a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c (rejected hunks)
@@ -66,8 +66,7 @@ static void ossl_legacy_provider_unload(void)
OSSL_PROVIDER_unload(default_lib);
}
#endif
-
-extern int qat_ipsec_mb_lib;
+#endif
#define ETH_CRC32_POLYNOMIAL 0x04c11db7
#define ETH_CRC32_INIT_VAL 0xffffffff
https://lab.dpdk.org/results/dashboard/patchsets/26549/
UNH-IOL DPDK Community Lab
^ permalink raw reply [flat|nested] 3+ messages in thread
* |WARNING| pw128198 [PATCH] [v5] crypto/qat: default to IPsec MB for computations
@ 2023-06-06 11:45 dpdklab
0 siblings, 0 replies; 3+ messages in thread
From: dpdklab @ 2023-06-06 11:45 UTC (permalink / raw)
To: test-report; +Cc: dpdk-test-reports
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/128198
_apply patch failure_
Submitter: Brian Dooley <brian.dooley@intel.com>
Date: Tuesday, June 06 2023 10:28:20
Applied on: CommitID:38689022f609a290645c7027084aee720c1fcf91
Apply patch set 128198 failed:
Checking patch doc/guides/cryptodevs/qat.rst...
error: while searching for:
-a 03:01.1,qat_sym_cipher_crc_enable=1
Running QAT PMD with Intel IPSEC MB library for symmetric precomputes function
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
The QAT PMD use Openssl library for partial hash calculation in symmetirc precomputes function by
default, the following parameter is allow QAT PMD switch over to multi-buffer job API if Intel
IPSEC MB library installed on system.
- qat_ipsec_mb_lib
To use this feature the user must set the parameter on process start as a device additional parameter::
-a 03:01.1,qat_ipsec_mb_lib=1
Device and driver naming
error: patch failed: doc/guides/cryptodevs/qat.rst:317
Checking patch drivers/common/qat/meson.build...
Checking patch drivers/common/qat/qat_device.c...
Hunk #1 succeeded at 365 (offset -6 lines).
Checking patch drivers/common/qat/qat_device.h...
error: while searching for:
#define QAT_DEV_NAME_MAX_LEN 64
#define QAT_IPSEC_MB_LIB "qat_ipsec_mb_lib"
#define SYM_ENQ_THRESHOLD_NAME "qat_sym_enq_threshold"
#define ASYM_ENQ_THRESHOLD_NAME "qat_asym_enq_threshold"
#define COMP_ENQ_THRESHOLD_NAME "qat_comp_enq_threshold"
#define SYM_CIPHER_CRC_ENABLE_NAME "qat_sym_cipher_crc_enable"
#define QAT_CMD_SLICE_MAP "qat_cmd_slice_disable"
#define QAT_CMD_SLICE_MAP_POS 5
#define MAX_QP_THRESHOLD_SIZE 32
/**
error: patch failed: drivers/common/qat/qat_device.h:17
Checking patch drivers/crypto/qat/dev/qat_crypto_pmd_gens.h...
Checking patch drivers/crypto/qat/qat_sym.c...
error: while searching for:
SYM_CIPHER_CRC_ENABLE_NAME))
internals->cipher_crc_offload_enable =
qat_dev_cmd_param[i].val;
if (!strcmp(qat_dev_cmd_param[i].name, QAT_IPSEC_MB_LIB))
qat_ipsec_mb_lib = qat_dev_cmd_param[i].val;
if (!strcmp(qat_dev_cmd_param[i].name, QAT_CMD_SLICE_MAP))
slice_map = qat_dev_cmd_param[i].val;
i++;
error: patch failed: drivers/crypto/qat/qat_sym.c:283
Checking patch drivers/crypto/qat/qat_sym.h...
Hunk #1 succeeded at 163 (offset -1 lines).
Hunk #2 succeeded at 221 (offset -1 lines).
error: while searching for:
if (op->sess_type == RTE_CRYPTO_OP_SECURITY_SESSION) {
ctx = SECURITY_GET_SESS_PRIV(op->sym->session);
if (ctx == NULL || ctx->bpi_ctx == NULL)
continue;
if (ctx->qat_cmd != ICP_QAT_FW_LA_CMD_CIPHER_CRC)
error: patch failed: drivers/crypto/qat/qat_sym.h:280
error: while searching for:
} else {
rx_op->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
if (sess->bpi_ctx) {
qat_bpicipher_postprocess(sess, rx_op);
#ifdef RTE_LIB_SECURITY
if (is_docsis_sec && sess->qat_cmd !=
error: patch failed: drivers/crypto/qat/qat_sym.h:329
Checking patch drivers/crypto/qat/qat_sym_session.c...
Hunk #2 succeeded at 32 (offset -1 lines).
error: while searching for:
OSSL_PROVIDER_unload(default_lib);
}
#endif
extern int qat_ipsec_mb_lib;
#define ETH_CRC32_POLYNOMIAL 0x04c11db7
#define ETH_CRC32_INIT_VAL 0xffffffff
error: patch failed: drivers/crypto/qat/qat_sym_session.c:66
Hunk #4 succeeded at 133 (offset -12 lines).
Hunk #5 succeeded at 184 (offset -12 lines).
Hunk #6 succeeded at 278 (offset -12 lines).
Hunk #7 succeeded at 447 (offset -12 lines).
Hunk #8 succeeded at 477 (offset -12 lines).
Hunk #9 succeeded at 579 (offset -12 lines).
Hunk #10 succeeded at 601 (offset -12 lines).
Hunk #11 succeeded at 616 (offset -12 lines).
Hunk #12 succeeded at 1241 (offset -52 lines).
Hunk #13 succeeded at 1346 (offset -52 lines).
Hunk #14 succeeded at 1392 (offset -52 lines).
Hunk #15 succeeded at 1547 (offset -52 lines).
Hunk #16 succeeded at 1559 (offset -52 lines).
Hunk #17 succeeded at 1643 (offset -52 lines).
Hunk #18 succeeded at 1683 (offset -52 lines).
Hunk #19 succeeded at 1796 (offset -52 lines).
Hunk #20 succeeded at 1807 (offset -52 lines).
Hunk #21 succeeded at 2213 (offset -55 lines).
Hunk #22 succeeded at 2240 (offset -55 lines).
Hunk #23 succeeded at 2265 (offset -55 lines).
Hunk #24 succeeded at 2290 (offset -55 lines).
Hunk #25 succeeded at 2315 (offset -55 lines).
Hunk #26 succeeded at 2359 (offset -55 lines).
Hunk #27 succeeded at 2381 (offset -55 lines).
Hunk #28 succeeded at 2446 (offset -55 lines).
Hunk #29 succeeded at 2751 (offset -193 lines).
Hunk #30 succeeded at 2764 (offset -193 lines).
Hunk #31 succeeded at 2780 (offset -193 lines).
Checking patch drivers/crypto/qat/qat_sym_session.h...
Hunk #2 succeeded at 126 (offset -11 lines).
Applying patch doc/guides/cryptodevs/qat.rst with 1 reject...
Rejected hunk #1.
Applied patch drivers/common/qat/meson.build cleanly.
Applied patch drivers/common/qat/qat_device.c cleanly.
Applying patch drivers/common/qat/qat_device.h with 1 reject...
Rejected hunk #1.
Applied patch drivers/crypto/qat/dev/qat_crypto_pmd_gens.h cleanly.
Applying patch drivers/crypto/qat/qat_sym.c with 1 reject...
Hunk #1 applied cleanly.
Hunk #2 applied cleanly.
Hunk #3 applied cleanly.
Rejected hunk #4.
Applying patch drivers/crypto/qat/qat_sym.h with 2 rejects...
Hunk #1 applied cleanly.
Hunk #2 applied cleanly.
Rejected hunk #3.
Rejected hunk #4.
Applying patch drivers/crypto/qat/qat_sym_session.c with 1 reject...
Hunk #1 applied cleanly.
Hunk #2 applied cleanly.
Rejected hunk #3.
Hunk #4 applied cleanly.
Hunk #5 applied cleanly.
Hunk #6 applied cleanly.
Hunk #7 applied cleanly.
Hunk #8 applied cleanly.
Hunk #9 applied cleanly.
Hunk #10 applied cleanly.
Hunk #11 applied cleanly.
Hunk #12 applied cleanly.
Hunk #13 applied cleanly.
Hunk #14 applied cleanly.
Hunk #15 applied cleanly.
Hunk #16 applied cleanly.
Hunk #17 applied cleanly.
Hunk #18 applied cleanly.
Hunk #19 applied cleanly.
Hunk #20 applied cleanly.
Hunk #21 applied cleanly.
Hunk #22 applied cleanly.
Hunk #23 applied cleanly.
Hunk #24 applied cleanly.
Hunk #25 applied cleanly.
Hunk #26 applied cleanly.
Hunk #27 applied cleanly.
Hunk #28 applied cleanly.
Hunk #29 applied cleanly.
Hunk #30 applied cleanly.
Hunk #31 applied cleanly.
Applied patch drivers/crypto/qat/qat_sym_session.h cleanly.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst (rejected hunks)
@@ -317,18 +317,12 @@ To use this feature the user must set the devarg on process start as a device ad
-a 03:01.1,qat_sym_cipher_crc_enable=1
-Running QAT PMD with Intel IPSEC MB library for symmetric precomputes function
+Running QAT PMD with Intel IPsec MB library for symmetric precomputes function
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-The QAT PMD use Openssl library for partial hash calculation in symmetirc precomputes function by
-default, the following parameter is allow QAT PMD switch over to multi-buffer job API if Intel
-IPSEC MB library installed on system.
-
-- qat_ipsec_mb_lib
-
-To use this feature the user must set the parameter on process start as a device additional parameter::
-
- -a 03:01.1,qat_ipsec_mb_lib=1
+The QAT PMD uses Intel IPsec MB library for partial hash calculation in symmetric precomputes function by
+default, the minimum required version of IPsec MB library is v1.4. If this version of IPsec is not met it
+will fallback to use OpenSSL
Device and driver naming
diff a/drivers/common/qat/qat_device.h b/drivers/common/qat/qat_device.h (rejected hunks)
@@ -17,13 +17,12 @@
#define QAT_DEV_NAME_MAX_LEN 64
-#define QAT_IPSEC_MB_LIB "qat_ipsec_mb_lib"
#define SYM_ENQ_THRESHOLD_NAME "qat_sym_enq_threshold"
#define ASYM_ENQ_THRESHOLD_NAME "qat_asym_enq_threshold"
#define COMP_ENQ_THRESHOLD_NAME "qat_comp_enq_threshold"
#define SYM_CIPHER_CRC_ENABLE_NAME "qat_sym_cipher_crc_enable"
#define QAT_CMD_SLICE_MAP "qat_cmd_slice_disable"
-#define QAT_CMD_SLICE_MAP_POS 5
+#define QAT_CMD_SLICE_MAP_POS 4
#define MAX_QP_THRESHOLD_SIZE 32
/**
diff a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c (rejected hunks)
@@ -283,8 +286,6 @@ qat_sym_dev_create(struct qat_pci_device *qat_pci_dev,
SYM_CIPHER_CRC_ENABLE_NAME))
internals->cipher_crc_offload_enable =
qat_dev_cmd_param[i].val;
- if (!strcmp(qat_dev_cmd_param[i].name, QAT_IPSEC_MB_LIB))
- qat_ipsec_mb_lib = qat_dev_cmd_param[i].val;
if (!strcmp(qat_dev_cmd_param[i].name, QAT_CMD_SLICE_MAP))
slice_map = qat_dev_cmd_param[i].val;
i++;
diff a/drivers/crypto/qat/qat_sym.h b/drivers/crypto/qat/qat_sym.h (rejected hunks)
@@ -280,7 +299,11 @@ qat_sym_preprocess_requests(void **ops, uint16_t nb_ops)
if (op->sess_type == RTE_CRYPTO_OP_SECURITY_SESSION) {
ctx = SECURITY_GET_SESS_PRIV(op->sym->session);
+#ifdef RTE_QAT_OPENSSL
if (ctx == NULL || ctx->bpi_ctx == NULL)
+#else
+ if (ctx == NULL || ctx->mb_mgr == NULL)
+#endif
continue;
if (ctx->qat_cmd != ICP_QAT_FW_LA_CMD_CIPHER_CRC)
@@ -329,7 +352,11 @@ qat_sym_process_response(void **op, uint8_t *resp, void *op_cookie,
} else {
rx_op->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
+#ifdef RTE_QAT_OPENSSL
if (sess->bpi_ctx) {
+#else
+ if (sess->mb_mgr) {
+#endif
qat_bpicipher_postprocess(sess, rx_op);
#ifdef RTE_LIB_SECURITY
if (is_docsis_sec && sess->qat_cmd !=
diff a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c (rejected hunks)
@@ -66,8 +66,7 @@ static void ossl_legacy_provider_unload(void)
OSSL_PROVIDER_unload(default_lib);
}
#endif
-
-extern int qat_ipsec_mb_lib;
+#endif
#define ETH_CRC32_POLYNOMIAL 0x04c11db7
#define ETH_CRC32_INIT_VAL 0xffffffff
https://lab.dpdk.org/results/dashboard/patchsets/26549/
UNH-IOL DPDK Community Lab
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-09 21:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-09 21:47 |WARNING| pw128198 [PATCH] [v5] crypto/qat: default to IPsec MB for computations dpdklab
-- strict thread matches above, loose matches on Subject: below --
2023-06-08 21:38 dpdklab
2023-06-06 11:45 dpdklab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).