automatic DPDK test reports
 help / color / mirror / Atom feed
From: dpdklab@iol.unh.edu
To: test-report@dpdk.org
Cc: dpdk-test-reports@iol.unh.edu
Subject: |WARNING| pw129931 [PATCH] [TEST] dpdk/app/test/test_mbuf.c test_refcnt_mbuf instability + fix proposal
Date: Sun, 06 Aug 2023 23:40:46 -0700 (PDT)	[thread overview]
Message-ID: <64d091ee.0d0a0220.6a9ac.5eb6SMTPIN_ADDED_MISSING@mx.google.com> (raw)

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/129931

_apply patch failure_

Submitter: Julien Hascoet <jhascoet@kalrayinc.com>
Date: Monday, August 07 2023 06:18:43 
Applied on: CommitID:9836014d4c2b1b2c29948c928fd386b2944b6bcf
Apply patch set 129931 failed:

Checking patch app/test/test_mbuf.c...
error: while searching for:
               tref += ref;
               if ((ref & 1) != 0) {
                       rte_pktmbuf_refcnt_update(m, ref);
                       while (ref-- != 0)
                               rte_ring_enqueue(refcnt_mbuf_ring, m);
               } else {
                       while (ref-- != 0) {
                               rte_pktmbuf_refcnt_update(m, 1);
                               rte_ring_enqueue(refcnt_mbuf_ring, m);
                       }
               }
               rte_pktmbuf_free(m);

error: patch failed: app/test/test_mbuf.c:1033
Applying patch app/test/test_mbuf.c with 1 reject...
Rejected hunk #1.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/app/test/test_mbuf.c b/app/test/test_mbuf.c	(rejected hunks)
@@ -1033,12 +1033,17 @@ test_refcnt_iter(unsigned int lcore, unsigned int iter,
                tref += ref;
                if ((ref & 1) != 0) {
                        rte_pktmbuf_refcnt_update(m, ref);
-                       while (ref-- != 0)
-                               rte_ring_enqueue(refcnt_mbuf_ring, m);
+                       while (ref-- != 0) {
+                               /* retry in case of failure */
+                               while (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0)
+                                       ;
+                       }
                } else {
                        while (ref-- != 0) {
                                rte_pktmbuf_refcnt_update(m, 1);
-                               rte_ring_enqueue(refcnt_mbuf_ring, m);
+                               /* retry in case of failure */
+                               while (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0)
+                                       ;
                        }
                }
                rte_pktmbuf_free(m);

https://lab.dpdk.org/results/dashboard/patchsets/27240/

UNH-IOL DPDK Community Lab

                 reply	other threads:[~2023-08-07  6:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=64d091ee.0d0a0220.6a9ac.5eb6SMTPIN_ADDED_MISSING@mx.google.com \
    --to=dpdklab@iol.unh.edu \
    --cc=dpdk-test-reports@iol.unh.edu \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).