|WARNING| pw130314-130320 [PATCH] [v2, 7/7] eal: initialize worker threads once

[dpdklab@iol.unh.edu]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/130314

_apply patch failure_

Submitter: Sinan Kaya <okaya@kernel.org>
Date: Tuesday, August 15 2023 03:13:07 
Applied on: CommitID:68150b90bda5e8f81ad1b1bad82be653b1d42a81
Apply patch set 130314-130320 failed:

Checking patch lib/eal/common/eal_common_options.c...
Hunk #1 succeeded at 1981 (offset -2 lines).
Checking patch lib/eal/linux/eal.c...
Hunk #1 succeeded at 79 (offset 1 line).
Hunk #2 succeeded at 507 (offset 1 line).
error: while searching for:
rte_eal_init(int argc, char **argv)
{
	int i, fctret, ret;
	static uint32_t run_once;
	uint32_t has_run = 0;
	const char *p;
	static char logid[PATH_MAX];

error: patch failed: lib/eal/linux/eal.c:960
Applied patch lib/eal/common/eal_common_options.c cleanly.
Applying patch lib/eal/linux/eal.c with 1 reject...
Hunk #1 applied cleanly.
Hunk #2 applied cleanly.
Rejected hunk #3.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c	(rejected hunks)
@@ -960,7 +963,6 @@ int
 rte_eal_init(int argc, char **argv)
 {
 	int i, fctret, ret;
-	static uint32_t run_once;
 	uint32_t has_run = 0;
 	const char *p;
 	static char logid[PATH_MAX];
Checking patch lib/eal/common/eal_common_memzone.c...
error: while searching for:
#include "eal_private.h"
#include "eal_memcfg.h"

static inline const struct rte_memzone *
memzone_lookup_thread_unsafe(const char *name)
{

error: patch failed: lib/eal/common/eal_common_memzone.c:22
Hunk #2 succeeded at 426 (offset 27 lines).
Hunk #3 succeeded at 447 (offset 27 lines).
Applying patch lib/eal/common/eal_common_memzone.c with 1 reject...
Rejected hunk #1.
Hunk #2 applied cleanly.
Hunk #3 applied cleanly.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/lib/eal/common/eal_common_memzone.c b/lib/eal/common/eal_common_memzone.c	(rejected hunks)
@@ -22,6 +22,8 @@
 #include "eal_private.h"
 #include "eal_memcfg.h"
 
+static bool memzone_initialized;
+
 static inline const struct rte_memzone *
 memzone_lookup_thread_unsafe(const char *name)
 {
Checking patch lib/eal/common/eal_common_memory.c...
Hunk #1 succeeded at 41 (offset 2 lines).
error: while searching for:
	if (!mcfg)
		return -1;

	/* lock mem hotplug here, to prevent races while we init */
	rte_mcfg_mem_read_lock();


error: patch failed: lib/eal/common/eal_common_memory.c:1088
error: while searching for:
	if (internal_conf->no_shconf == 0 && rte_eal_memdevice_init() < 0)
		goto fail;

	return 0;
fail:
	rte_mcfg_mem_read_unlock();

error: patch failed: lib/eal/common/eal_common_memory.c:1106
Checking patch lib/eal/common/malloc_heap.c...
Hunk #2 succeeded at 1412 (offset 4 lines).
Hunk #3 succeeded at 1454 (offset 6 lines).
Applying patch lib/eal/common/eal_common_memory.c with 2 rejects...
Hunk #1 applied cleanly.
Rejected hunk #2.
Rejected hunk #3.
Applied patch lib/eal/common/malloc_heap.c cleanly.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/lib/eal/common/eal_common_memory.c b/lib/eal/common/eal_common_memory.c	(rejected hunks)
@@ -1088,6 +1089,9 @@ rte_eal_memory_init(void)
 	if (!mcfg)
 		return -1;
 
+	if (memory_initialized)
+		return 0;
+
 	/* lock mem hotplug here, to prevent races while we init */
 	rte_mcfg_mem_read_lock();
 
@@ -1106,6 +1110,7 @@ rte_eal_memory_init(void)
 	if (internal_conf->no_shconf == 0 && rte_eal_memdevice_init() < 0)
 		goto fail;
 
+	memory_initialized = true;
 	return 0;
 fail:
 	rte_mcfg_mem_read_unlock();
Checking patch lib/eal/linux/eal.c...
error: lib/eal/linux/eal.c: does not match index
hint: Use 'git am --show-current-patch' to see the failed patch

https://lab.dpdk.org/results/dashboard/patchsets/27338/

UNH-IOL DPDK Community Lab