From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E0754253E for ; Fri, 8 Sep 2023 06:26:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A66CA40042; Fri, 8 Sep 2023 06:26:06 +0200 (CEST) Received: from mail-ot1-f97.google.com (mail-ot1-f97.google.com [209.85.210.97]) by mails.dpdk.org (Postfix) with ESMTP id DC6C740042 for ; Fri, 8 Sep 2023 06:26:04 +0200 (CEST) Received: by mail-ot1-f97.google.com with SMTP id 46e09a7af769-6bf2427b947so1204746a34.3 for ; Thu, 07 Sep 2023 21:26:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1694147164; x=1694751964; darn=dpdk.org; h=cc:to:from:subject:message-id:date:from:to:cc:subject:date :message-id:reply-to; bh=SHxdu8RFUQVl17kSW3Jj41J3RKAaSHYoK12Ig+p0+D8=; b=BWaxvDZbdLz0pQlUEPj1aoJxfm5CLnMsiHRgPt6/JLWx45hujG686Z2FQzWnaherDh P7/27dBtaV4MIl4Nsz2czBYWk8sSWE5F1iEj6Bf3J1IA9KUmW4+n99SvMd6SBK35lfMz JUo1+P6i8hiRRKfVANV1OBoDhTiNO9di5FPwU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694147164; x=1694751964; h=cc:to:from:subject:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SHxdu8RFUQVl17kSW3Jj41J3RKAaSHYoK12Ig+p0+D8=; b=VRHrTv16YZR8ljpWj0SYarziGZZ6AAWgqB7yg31HVs3jQc7F1pC99JtQ3IPhenL//h LPudFBgwX/1gpsnsoAdW/K8kVehtM+sA/KcarB/l/vG5CMOp124mEC3s4IadlJ/4VGPa 3KNYSOfvb2ggjd930yJdgvG2eqM+cHP0XCW6dj544F+hJi+WjsHVXPwA1hZ9Eg96VPoL sS1NQo4jgoRuW3Y49skuOSM9S9Vgc0wMReqlqmROURlF6p7tTFkHe1k2oY7a/DhiqcpC dmpyCiKh66hd+qujm27XiLmOU/qnIG4klu/dynPfpX/LPRfULUcPagJrMDz4j8VCaBjX kVmw== X-Gm-Message-State: AOJu0YxSwCsSbr0lj1cqGD9g2ZKBihEIyuf2MWJGeS9uHSdmZ7sb0VJN awTwa/MLziclIl9sNWP0eeNreM1H8ARCi1wjQTmNE4/aMjWLGPVb9tHBuxHObWH1SzfNzijjJw= = X-Google-Smtp-Source: AGHT+IFIGGbaD1iFtCUYJcGc+xGxEkxIuVnS5kreNHjFadv274UA7rJan6wppfPzqxRhYzLaEhlfWg4YEttA X-Received: by 2002:a05:6358:292a:b0:13f:7e5:b397 with SMTP id y42-20020a056358292a00b0013f07e5b397mr1249147rwb.7.1694147163933; Thu, 07 Sep 2023 21:26:03 -0700 (PDT) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [2606:4100:3880:1234::84]) by smtp-relay.gmail.com with ESMTPS id oa8-20020a17090b1bc800b0026f4eea69fdsm179906pjb.5.2023.09.07.21.26.03 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Sep 2023 21:26:03 -0700 (PDT) X-Relaying-Domain: iol.unh.edu Date: Thu, 07 Sep 2023 21:26:03 -0700 (PDT) Message-ID: <64faa25b.170a0220.bea4a.9cf0SMTPIN_ADDED_MISSING@mx.google.com> Received: from [172.21.0.3] (unknown [172.18.0.240]) by postal.iol.unh.edu (Postfix) with ESMTP id 1DA036052471; Fri, 8 Sep 2023 00:26:03 -0400 (EDT) Subject: |WARNING| pw131224 [PATCH] [v1] dma/cnxk: offload source buffer free From: dpdklab@iol.unh.edu To: test-report@dpdk.org Cc: dpdk-test-reports@iol.unh.edu Content-Type: text/plain X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: iol-testing Test-Status: WARNING http://dpdk.org/patch/131224 _apply patch failure_ Submitter: Amit Prakash Shukla Date: Thursday, September 07 2023 08:24:43 Applied on: CommitID:e92ba1426914db1d224dd5e9a1743657681b8814 Apply patch set 131224 failed: Checking patch drivers/dma/cnxk/cnxk_dmadev.c... error: while searching for: dev_info->nb_vchans = dpivf->num_vchans; dev_info->dev_capa = RTE_DMA_CAPA_MEM_TO_MEM | RTE_DMA_CAPA_MEM_TO_DEV | RTE_DMA_CAPA_DEV_TO_MEM | RTE_DMA_CAPA_DEV_TO_DEV | RTE_DMA_CAPA_OPS_COPY | RTE_DMA_CAPA_OPS_COPY_SG; dev_info->max_desc = DPI_MAX_DESC; dev_info->min_desc = DPI_MIN_DESC; dev_info->max_sges = DPI_MAX_POINTER; error: patch failed: drivers/dma/cnxk/cnxk_dmadev.c:16 error: while searching for: return rc; } static void cn9k_dmadev_setup_hdr(union cnxk_dpi_instr_cmd *header, const struct rte_dma_vchan_conf *conf) { header->cn9k.pt = DPI_HDR_PT_ZBW_CA; switch (conf->direction) { error: patch failed: drivers/dma/cnxk/cnxk_dmadev.c:159 error: while searching for: header->cn9k.func = conf->dst_port.pcie.pfid << 12; header->cn9k.func |= conf->dst_port.pcie.vfid; } break; case RTE_DMA_DIR_MEM_TO_MEM: header->cn9k.xtype = DPI_XTYPE_INTERNAL_ONLY; error: patch failed: drivers/dma/cnxk/cnxk_dmadev.c:184 error: while searching for: header->cn9k.fport = conf->dst_port.pcie.coreid; header->cn9k.pvfe = 0; }; } static void cn10k_dmadev_setup_hdr(union cnxk_dpi_instr_cmd *header, const struct rte_dma_vchan_conf *conf) { header->cn10k.pt = DPI_HDR_PT_ZBW_CA; switch (conf->direction) { error: patch failed: drivers/dma/cnxk/cnxk_dmadev.c:197 error: while searching for: header->cn10k.func = conf->dst_port.pcie.pfid << 12; header->cn10k.func |= conf->dst_port.pcie.vfid; } break; case RTE_DMA_DIR_MEM_TO_MEM: header->cn10k.xtype = DPI_XTYPE_INTERNAL_ONLY; error: patch failed: drivers/dma/cnxk/cnxk_dmadev.c:224 error: while searching for: header->cn10k.fport = conf->dst_port.pcie.coreid; header->cn10k.pvfe = 0; }; } static int error: patch failed: drivers/dma/cnxk/cnxk_dmadev.c:237 error: while searching for: union cnxk_dpi_instr_cmd *header; uint16_t max_desc; uint32_t size; int i; RTE_SET_USED(conf_sz); error: patch failed: drivers/dma/cnxk/cnxk_dmadev.c:248 error: while searching for: return 0; if (dpivf->is_cn10k) cn10k_dmadev_setup_hdr(header, conf); else cn9k_dmadev_setup_hdr(header, conf); /* Free up descriptor memory before allocating. */ cnxk_dmadev_vchan_free(dpivf, vchan); error: patch failed: drivers/dma/cnxk/cnxk_dmadev.c:257 Checking patch drivers/dma/cnxk/cnxk_dmadev_fp.c... error: drivers/dma/cnxk/cnxk_dmadev_fp.c: does not exist in index Applying patch drivers/dma/cnxk/cnxk_dmadev.c with 8 rejects... Rejected hunk #1. Rejected hunk #2. Rejected hunk #3. Rejected hunk #4. Rejected hunk #5. Rejected hunk #6. Rejected hunk #7. Rejected hunk #8. hint: Use 'git am --show-current-patch' to see the failed patch diff a/drivers/dma/cnxk/cnxk_dmadev.c b/drivers/dma/cnxk/cnxk_dmadev.c (rejected hunks) @@ -16,7 +16,8 @@ cnxk_dmadev_info_get(const struct rte_dma_dev *dev, struct rte_dma_info *dev_inf dev_info->nb_vchans = dpivf->num_vchans; dev_info->dev_capa = RTE_DMA_CAPA_MEM_TO_MEM | RTE_DMA_CAPA_MEM_TO_DEV | RTE_DMA_CAPA_DEV_TO_MEM | RTE_DMA_CAPA_DEV_TO_DEV | - RTE_DMA_CAPA_OPS_COPY | RTE_DMA_CAPA_OPS_COPY_SG; + RTE_DMA_CAPA_OPS_COPY | RTE_DMA_CAPA_OPS_COPY_SG | + RTE_DMA_CAPA_MEM_TO_DEV_SOURCE_BUFFER_FREE; dev_info->max_desc = DPI_MAX_DESC; dev_info->min_desc = DPI_MIN_DESC; dev_info->max_sges = DPI_MAX_POINTER; @@ -159,9 +160,26 @@ cnxk_dmadev_configure(struct rte_dma_dev *dev, const struct rte_dma_conf *conf, return rc; } -static void +static int +dmadev_src_buf_aura_get(struct rte_mempool *sb_mp, const char *mp_ops_name) +{ + struct rte_mempool_ops *ops; + + if (sb_mp == NULL) + return 0; + + ops = rte_mempool_get_ops(sb_mp->ops_index); + if (strcmp(ops->name, mp_ops_name) != 0) + return -EINVAL; + + return roc_npa_aura_handle_to_aura(sb_mp->pool_id); +} + +static int cn9k_dmadev_setup_hdr(union cnxk_dpi_instr_cmd *header, const struct rte_dma_vchan_conf *conf) { + int aura; + header->cn9k.pt = DPI_HDR_PT_ZBW_CA; switch (conf->direction) { @@ -184,6 +202,11 @@ cn9k_dmadev_setup_hdr(union cnxk_dpi_instr_cmd *header, const struct rte_dma_vch header->cn9k.func = conf->dst_port.pcie.pfid << 12; header->cn9k.func |= conf->dst_port.pcie.vfid; } + aura = dmadev_src_buf_aura_get(conf->mem_to_dev_src_buf_pool, "cn9k_mempool_ops"); + if (aura < 0) + return aura; + header->cn9k.aura = aura; + header->cn9k.ii = 1; break; case RTE_DMA_DIR_MEM_TO_MEM: header->cn9k.xtype = DPI_XTYPE_INTERNAL_ONLY; @@ -197,11 +220,15 @@ cn9k_dmadev_setup_hdr(union cnxk_dpi_instr_cmd *header, const struct rte_dma_vch header->cn9k.fport = conf->dst_port.pcie.coreid; header->cn9k.pvfe = 0; }; + + return 0; } -static void +static int cn10k_dmadev_setup_hdr(union cnxk_dpi_instr_cmd *header, const struct rte_dma_vchan_conf *conf) { + int aura; + header->cn10k.pt = DPI_HDR_PT_ZBW_CA; switch (conf->direction) { @@ -224,6 +251,10 @@ cn10k_dmadev_setup_hdr(union cnxk_dpi_instr_cmd *header, const struct rte_dma_vc header->cn10k.func = conf->dst_port.pcie.pfid << 12; header->cn10k.func |= conf->dst_port.pcie.vfid; } + aura = dmadev_src_buf_aura_get(conf->mem_to_dev_src_buf_pool, "cn10k_mempool_ops"); + if (aura < 0) + return aura; + header->cn10k.aura = aura; break; case RTE_DMA_DIR_MEM_TO_MEM: header->cn10k.xtype = DPI_XTYPE_INTERNAL_ONLY; @@ -237,6 +268,8 @@ cn10k_dmadev_setup_hdr(union cnxk_dpi_instr_cmd *header, const struct rte_dma_vc header->cn10k.fport = conf->dst_port.pcie.coreid; header->cn10k.pvfe = 0; }; + + return 0; } static int @@ -248,7 +281,7 @@ cnxk_dmadev_vchan_setup(struct rte_dma_dev *dev, uint16_t vchan, union cnxk_dpi_instr_cmd *header; uint16_t max_desc; uint32_t size; - int i; + int i, ret; RTE_SET_USED(conf_sz); @@ -257,9 +290,12 @@ cnxk_dmadev_vchan_setup(struct rte_dma_dev *dev, uint16_t vchan, return 0; if (dpivf->is_cn10k) - cn10k_dmadev_setup_hdr(header, conf); + ret = cn10k_dmadev_setup_hdr(header, conf); else - cn9k_dmadev_setup_hdr(header, conf); + ret = cn9k_dmadev_setup_hdr(header, conf); + + if (ret) + return ret; /* Free up descriptor memory before allocating. */ cnxk_dmadev_vchan_free(dpivf, vchan); https://lab.dpdk.org/results/dashboard/patchsets/27543/ UNH-IOL DPDK Community Lab