* |WARNING| pw133766 [PATCH] net/nfp: add support of dynamic config of allmulticast mode
@ 2023-11-02 15:41 dpdklab
0 siblings, 0 replies; only message in thread
From: dpdklab @ 2023-11-02 15:41 UTC (permalink / raw)
To: test-report; +Cc: dpdk-test-reports
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/133766
_apply patch failure_
Submitter: Chaoyong He <chaoyong.he@corigine.com>
Date: Thursday, November 02 2023 05:37:44
Applied on: CommitID:71f9da6691c49d0dfcf088dce5e99c488af0eb7e
Apply patch set 133766 failed:
Checking patch doc/guides/nics/features/nfp.ini...
error: while searching for:
Queue start/stop = Y
MTU update = Y
Promiscuous mode = Y
TSO = Y
RSS hash = Y
RSS key update = Y
error: patch failed: doc/guides/nics/features/nfp.ini:11
Checking patch drivers/common/nfp/nfp_common_ctrl.h...
error: while searching for:
#define NFP_NET_CFG_CTRL_WORD1 0x0098
#define NFP_NET_CFG_CTRL_PKT_TYPE (0x1 << 0)
#define NFP_NET_CFG_CTRL_IPSEC (0x1 << 1) /**< IPsec offload */
#define NFP_NET_CFG_CTRL_IPSEC_SM_LOOKUP (0x1 << 3) /**< SA short match lookup */
#define NFP_NET_CFG_CTRL_IPSEC_LM_LOOKUP (0x1 << 4) /**< SA long match lookup */
#define NFP_NET_CFG_CTRL_IN_ORDER (0x1 << 11) /**< Virtio in-order flag */
error: patch failed: drivers/common/nfp/nfp_common_ctrl.h:219
Checking patch drivers/net/nfp/nfp_ethdev.c...
error: while searching for:
.dev_close = nfp_net_close,
.promiscuous_enable = nfp_net_promisc_enable,
.promiscuous_disable = nfp_net_promisc_disable,
.link_update = nfp_net_link_update,
.stats_get = nfp_net_stats_get,
.stats_reset = nfp_net_stats_reset,
error: patch failed: drivers/net/nfp/nfp_ethdev.c:402
Checking patch drivers/net/nfp/nfp_ethdev_vf.c...
error: while searching for:
.dev_close = nfp_netvf_close,
.promiscuous_enable = nfp_net_promisc_enable,
.promiscuous_disable = nfp_net_promisc_disable,
.link_update = nfp_net_link_update,
.stats_get = nfp_net_stats_get,
.stats_reset = nfp_net_stats_reset,
error: patch failed: drivers/net/nfp/nfp_ethdev_vf.c:199
Checking patch drivers/net/nfp/nfp_net_common.c...
error: while searching for:
return 0;
}
int
nfp_net_link_update_common(struct rte_eth_dev *dev,
struct nfp_net_hw *hw,
error: patch failed: drivers/net/nfp/nfp_net_common.c:583
Checking patch drivers/net/nfp/nfp_net_common.h...
error: while searching for:
uint32_t nfp_check_offloads(struct rte_eth_dev *dev);
int nfp_net_promisc_enable(struct rte_eth_dev *dev);
int nfp_net_promisc_disable(struct rte_eth_dev *dev);
int nfp_net_link_update_common(struct rte_eth_dev *dev,
struct nfp_net_hw *hw,
struct rte_eth_link *link,
error: patch failed: drivers/net/nfp/nfp_net_common.h:174
Applying patch doc/guides/nics/features/nfp.ini with 1 reject...
Rejected hunk #1.
Applying patch drivers/common/nfp/nfp_common_ctrl.h with 1 reject...
Rejected hunk #1.
Applying patch drivers/net/nfp/nfp_ethdev.c with 1 reject...
Rejected hunk #1.
Applying patch drivers/net/nfp/nfp_ethdev_vf.c with 1 reject...
Rejected hunk #1.
Applying patch drivers/net/nfp/nfp_net_common.c with 1 reject...
Rejected hunk #1.
Applying patch drivers/net/nfp/nfp_net_common.h with 1 reject...
Rejected hunk #1.
hint: Use 'git am --show-current-patch' to see the failed patch
diff a/doc/guides/nics/features/nfp.ini b/doc/guides/nics/features/nfp.ini (rejected hunks)
@@ -11,6 +11,7 @@ Rx interrupt = Y
Queue start/stop = Y
MTU update = Y
Promiscuous mode = Y
+Allmulticast mode = Y
TSO = Y
RSS hash = Y
RSS key update = Y
diff a/drivers/common/nfp/nfp_common_ctrl.h b/drivers/common/nfp/nfp_common_ctrl.h (rejected hunks)
@@ -219,6 +219,7 @@ struct nfp_net_fw_ver {
#define NFP_NET_CFG_CTRL_WORD1 0x0098
#define NFP_NET_CFG_CTRL_PKT_TYPE (0x1 << 0)
#define NFP_NET_CFG_CTRL_IPSEC (0x1 << 1) /**< IPsec offload */
+#define NFP_NET_CFG_CTRL_MCAST_FILTER (0x1 << 2) /**< Multicast Filter */
#define NFP_NET_CFG_CTRL_IPSEC_SM_LOOKUP (0x1 << 3) /**< SA short match lookup */
#define NFP_NET_CFG_CTRL_IPSEC_LM_LOOKUP (0x1 << 4) /**< SA long match lookup */
#define NFP_NET_CFG_CTRL_IN_ORDER (0x1 << 11) /**< Virtio in-order flag */
diff a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c (rejected hunks)
@@ -402,6 +402,8 @@ static const struct eth_dev_ops nfp_net_eth_dev_ops = {
.dev_close = nfp_net_close,
.promiscuous_enable = nfp_net_promisc_enable,
.promiscuous_disable = nfp_net_promisc_disable,
+ .allmulticast_enable = nfp_net_allmulticast_enable,
+ .allmulticast_disable = nfp_net_allmulticast_disable,
.link_update = nfp_net_link_update,
.stats_get = nfp_net_stats_get,
.stats_reset = nfp_net_stats_reset,
diff a/drivers/net/nfp/nfp_ethdev_vf.c b/drivers/net/nfp/nfp_ethdev_vf.c (rejected hunks)
@@ -199,6 +199,8 @@ static const struct eth_dev_ops nfp_netvf_eth_dev_ops = {
.dev_close = nfp_netvf_close,
.promiscuous_enable = nfp_net_promisc_enable,
.promiscuous_disable = nfp_net_promisc_disable,
+ .allmulticast_enable = nfp_net_allmulticast_enable,
+ .allmulticast_disable = nfp_net_allmulticast_disable,
.link_update = nfp_net_link_update,
.stats_get = nfp_net_stats_get,
.stats_reset = nfp_net_stats_reset,
diff a/drivers/net/nfp/nfp_net_common.c b/drivers/net/nfp/nfp_net_common.c (rejected hunks)
@@ -583,6 +583,66 @@ nfp_net_promisc_disable(struct rte_eth_dev *dev)
return 0;
}
+static int
+nfp_net_set_allmulticast_mode(struct rte_eth_dev *dev,
+ bool enable)
+{
+ int ret;
+ uint32_t update;
+ struct nfp_hw *hw;
+ uint32_t cap_extend;
+ uint32_t ctrl_extend;
+ uint32_t new_ctrl_extend;
+ struct nfp_net_hw *net_hw;
+
+ net_hw = nfp_net_get_hw(dev);
+ hw = &net_hw->super;
+
+ cap_extend = hw->cap_ext;
+ if ((cap_extend & NFP_NET_CFG_CTRL_MCAST_FILTER) == 0) {
+ PMD_DRV_LOG(ERR, "Allmulticast mode not supported");
+ return -ENOTSUP;
+ }
+
+ /*
+ * Allmulticast mode enabled when NFP_NET_CFG_CTRL_MCAST_FILTER bit is 0.
+ * Allmulticast mode disabled when NFP_NET_CFG_CTRL_MCAST_FILTER bit is 1.
+ */
+ ctrl_extend = hw->ctrl_ext;
+ if (enable) {
+ if ((ctrl_extend & NFP_NET_CFG_CTRL_MCAST_FILTER) == 0)
+ return 0;
+
+ new_ctrl_extend = ctrl_extend & ~NFP_NET_CFG_CTRL_MCAST_FILTER;
+ } else {
+ if ((ctrl_extend & NFP_NET_CFG_CTRL_MCAST_FILTER) != 0)
+ return 0;
+
+ new_ctrl_extend = ctrl_extend | NFP_NET_CFG_CTRL_MCAST_FILTER;
+ }
+
+ update = NFP_NET_CFG_UPDATE_GEN;
+
+ ret = nfp_ext_reconfig(hw, new_ctrl_extend, update);
+ if (ret != 0)
+ return ret;
+
+ hw->ctrl_ext = new_ctrl_extend;
+ return 0;
+}
+
+int
+nfp_net_allmulticast_enable(struct rte_eth_dev *dev)
+{
+ return nfp_net_set_allmulticast_mode(dev, true);
+}
+
+int
+nfp_net_allmulticast_disable(struct rte_eth_dev *dev)
+{
+ return nfp_net_set_allmulticast_mode(dev, false);
+}
+
int
nfp_net_link_update_common(struct rte_eth_dev *dev,
struct nfp_net_hw *hw,
diff a/drivers/net/nfp/nfp_net_common.h b/drivers/net/nfp/nfp_net_common.h (rejected hunks)
@@ -174,6 +174,8 @@ int nfp_configure_rx_interrupt(struct rte_eth_dev *dev,
uint32_t nfp_check_offloads(struct rte_eth_dev *dev);
int nfp_net_promisc_enable(struct rte_eth_dev *dev);
int nfp_net_promisc_disable(struct rte_eth_dev *dev);
+int nfp_net_allmulticast_enable(struct rte_eth_dev *dev);
+int nfp_net_allmulticast_disable(struct rte_eth_dev *dev);
int nfp_net_link_update_common(struct rte_eth_dev *dev,
struct nfp_net_hw *hw,
struct rte_eth_link *link,
https://lab.dpdk.org/results/dashboard/patchsets/28195/
UNH-IOL DPDK Community Lab
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-11-02 15:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-02 15:41 |WARNING| pw133766 [PATCH] net/nfp: add support of dynamic config of allmulticast mode dpdklab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).