From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 006BF43279 for ; Fri, 3 Nov 2023 13:07:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EF7A140273; Fri, 3 Nov 2023 13:07:57 +0100 (CET) Received: from mail-pg1-f225.google.com (mail-pg1-f225.google.com [209.85.215.225]) by mails.dpdk.org (Postfix) with ESMTP id 3297A40273 for ; Fri, 3 Nov 2023 13:07:55 +0100 (CET) Received: by mail-pg1-f225.google.com with SMTP id 41be03b00d2f7-5bd306f86a8so1166238a12.0 for ; Fri, 03 Nov 2023 05:07:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; t=1699013274; x=1699618074; darn=dpdk.org; h=cc:to:from:subject:message-id:date:from:to:cc:subject:date :message-id:reply-to; bh=RamRxW6S2d+uAsdEfof7zut4JOHVNuArOmccQv2LV7U=; b=XnV3j6mYMMhO5x4Msz+q3QPW9jAmi1dEhnMZqBQeSL7aGj+jdtPvICkulSHT7cQv0o rLdHu/oNlrVw1FyjOezi1VKdLeoZ5HCsgGJSLpH6nPAVZdpFkwE65yM8W/3b40wn07yN WlCEMk29/ndszDiac3T9/lwFcZPzgMxNaJr34= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699013274; x=1699618074; h=cc:to:from:subject:message-id:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RamRxW6S2d+uAsdEfof7zut4JOHVNuArOmccQv2LV7U=; b=C5JJSWXnM53GcrvdEIJlSq/c14qfwORfJspjv7GyYgkH9wGKARSu1lUmWx/5goBQes R85tuQtxz0b7MEe9oJzdQGryvy5nODVOgbb/dGNRmrLlZKhU/uZOGsmkPyx5yuUEft6f 9Zhu3v+sLmTTkBiqaCVSOgMYY5E+XtkT0z51Wtd0vyhpL7U8o+G8nVq6ScNEqwKXSZyB Q6O7V1ikqo298wUlTwD1aAaFIPSeKhh2J/XwYOGC3sVDWCKAjlLlG7enDIpmH2z+n4ev yXt1LHquNYu2sHjbcxZYA16ZBYtBFMqEFcBblSZ6cAvrXZ18SWiVXUIU4aKRKnekuV1c W8Xg== X-Gm-Message-State: AOJu0YyGU5hYErGacfCv7kDaDmH1GtEZXSurqZYp+DAezwIF8iDzaTM4 P0JrCuhrQCyvpHXfn2xaEX5XMVBAIbQeVwFUL9ZqYx9NIwYs+RU2IW5OQLILJfxfIcZ6pRcQyg= = X-Google-Smtp-Source: AGHT+IEMZvAnShxmyiZDKifBbnps1dLFbNjmctuy8TWuduHWUtpaYqom8YipCcTvkIJ03FY/7hf0QFlKBGWw X-Received: by 2002:a05:6a20:c19a:b0:16b:ff2c:c42c with SMTP id bg26-20020a056a20c19a00b0016bff2cc42cmr19082562pzb.62.1699013274514; Fri, 03 Nov 2023 05:07:54 -0700 (PDT) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [2606:4100:3880:1234::84]) by smtp-relay.gmail.com with ESMTPS id g1-20020a635641000000b005b25a04cf8csm154348pgm.8.2023.11.03.05.07.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Nov 2023 05:07:54 -0700 (PDT) X-Relaying-Domain: iol.unh.edu Date: Fri, 03 Nov 2023 05:07:54 -0700 (PDT) Message-ID: <6544e29a.630a0220.54491.4427SMTPIN_ADDED_MISSING@mx.google.com> Received: from [172.21.0.2] (unknown [172.18.0.240]) by postal.iol.unh.edu (Postfix) with ESMTP id BC5A560524E8; Fri, 3 Nov 2023 08:07:53 -0400 (EDT) Subject: |WARNING| pw133833-133831 [PATCH] [v5, 3/3] net/hns3: report maximum buffer size From: dpdklab@iol.unh.edu To: test-report@dpdk.org Cc: dpdk-test-reports@iol.unh.edu Content-Type: text/plain X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: iol-testing Test-Status: WARNING http://dpdk.org/patch/133833 _apply patch failure_ Submitter: Huisong Li Date: Friday, November 03 2023 10:27:59 Applied on: CommitID:75e885b117bb6313d6de7082946e22203fff2e7e Apply patch set 133833-133831 failed: Checking patch doc/guides/rel_notes/release_23_11.rst... error: while searching for: a group's miss actions, which are the actions to be performed on packets that didn't match any of the flow rules in the group. * **Updated Amazon ena (Elastic Network Adapter) net driver.** * Upgraded ENA HAL to latest version. error: patch failed: doc/guides/rel_notes/release_23_11.rst:122 Checking patch lib/ethdev/rte_ethdev.c... error: while searching for: struct rte_eth_dev *dev; struct rte_eth_dev_info dev_info; struct rte_eth_rxconf local_conf; RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); dev = &rte_eth_devices[port_id]; error: patch failed: lib/ethdev/rte_ethdev.c:2112 error: while searching for: return ret; mbp_buf_size = rte_pktmbuf_data_room_size(mp); } else if (rx_conf != NULL && rx_conf->rx_nseg > 0) { const struct rte_eth_rxseg_split *rx_seg; uint16_t n_seg; error: patch failed: lib/ethdev/rte_ethdev.c:2158 error: while searching for: dev_info->min_mtu = RTE_ETHER_MIN_LEN - RTE_ETHER_HDR_LEN - RTE_ETHER_CRC_LEN; dev_info->max_mtu = UINT16_MAX; if (*dev->dev_ops->dev_infos_get == NULL) return -ENOTSUP; error: patch failed: lib/ethdev/rte_ethdev.c:3757 Checking patch lib/ethdev/rte_ethdev.h... error: while searching for: uint16_t min_mtu; /**< Minimum MTU allowed */ uint16_t max_mtu; /**< Maximum MTU allowed */ const uint32_t *dev_flags; /**< Device flags */ uint32_t min_rx_bufsize; /**< Minimum size of Rx buffer. */ uint32_t max_rx_pktlen; /**< Maximum configurable length of Rx pkt. */ /** Maximum configurable size of LRO aggregated packet. */ uint32_t max_lro_pkt_size; error: patch failed: lib/ethdev/rte_ethdev.h:1723 Applying patch doc/guides/rel_notes/release_23_11.rst with 1 reject... Rejected hunk #1. Applying patch lib/ethdev/rte_ethdev.c with 3 rejects... Rejected hunk #1. Rejected hunk #2. Rejected hunk #3. Applying patch lib/ethdev/rte_ethdev.h with 1 reject... Rejected hunk #1. hint: Use 'git am --show-current-patch' to see the failed patch diff a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst (rejected hunks) @@ -122,6 +122,13 @@ New Features a group's miss actions, which are the actions to be performed on packets that didn't match any of the flow rules in the group. +* **Added maximum Rx buffer size to report.** + + Introduced the ``max_rx_bufsize`` field representing the maximum Rx + buffer size per descriptor supported by HW in structure ``rte_eth_dev_info`` + to report user and to avoid wasting space of mempool. + Its value is UINT32_MAX if driver doesn't report it. + * **Updated Amazon ena (Elastic Network Adapter) net driver.** * Upgraded ENA HAL to latest version. diff a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c (rejected hunks) @@ -2112,6 +2112,7 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id, struct rte_eth_dev *dev; struct rte_eth_dev_info dev_info; struct rte_eth_rxconf local_conf; + uint32_t buf_data_size; RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); dev = &rte_eth_devices[port_id]; @@ -2158,6 +2159,12 @@ rte_eth_rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id, return ret; mbp_buf_size = rte_pktmbuf_data_room_size(mp); + buf_data_size = mbp_buf_size - RTE_PKTMBUF_HEADROOM; + if (buf_data_size > dev_info.max_rx_bufsize) + RTE_ETHDEV_LOG(DEBUG, + "For port_id=%u, the mbuf data buffer size (%u) is bigger than " + "max buffer size (%u) device can utilize, so mbuf size can be reduced.\n", + port_id, buf_data_size, dev_info.max_rx_bufsize); } else if (rx_conf != NULL && rx_conf->rx_nseg > 0) { const struct rte_eth_rxseg_split *rx_seg; uint16_t n_seg; @@ -3757,6 +3764,7 @@ rte_eth_dev_info_get(uint16_t port_id, struct rte_eth_dev_info *dev_info) dev_info->min_mtu = RTE_ETHER_MIN_LEN - RTE_ETHER_HDR_LEN - RTE_ETHER_CRC_LEN; dev_info->max_mtu = UINT16_MAX; + dev_info->max_rx_bufsize = UINT32_MAX; if (*dev->dev_ops->dev_infos_get == NULL) return -ENOTSUP; diff a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h (rejected hunks) @@ -1723,7 +1723,15 @@ struct rte_eth_dev_info { uint16_t min_mtu; /**< Minimum MTU allowed */ uint16_t max_mtu; /**< Maximum MTU allowed */ const uint32_t *dev_flags; /**< Device flags */ - uint32_t min_rx_bufsize; /**< Minimum size of Rx buffer. */ + /** Minimum Rx buffer size per descriptor supported by HW. */ + uint32_t min_rx_bufsize; + /** + * Maximum Rx buffer size per descriptor supported by HW. + * The value is not enforced, information only to application to + * optimize mbuf size. Its value is UINT32_MAX when not specified + * by the driver. + */ + uint32_t max_rx_bufsize; uint32_t max_rx_pktlen; /**< Maximum configurable length of Rx pkt. */ /** Maximum configurable size of LRO aggregated packet. */ uint32_t max_lro_pkt_size; Checking patch app/test-pmd/config.c... error: while searching for: } printf("Minimum size of RX buffer: %u\n", dev_info.min_rx_bufsize); printf("Maximum configurable length of RX packet: %u\n", dev_info.max_rx_pktlen); printf("Maximum configurable size of LRO aggregated packet: %u\n", error: patch failed: app/test-pmd/config.c:881 Applying patch app/test-pmd/config.c with 1 reject... Rejected hunk #1. hint: Use 'git am --show-current-patch' to see the failed patch diff a/app/test-pmd/config.c b/app/test-pmd/config.c (rejected hunks) @@ -881,6 +881,8 @@ port_infos_display(portid_t port_id) } printf("Minimum size of RX buffer: %u\n", dev_info.min_rx_bufsize); + if (dev_info.max_rx_bufsize != UINT32_MAX) + printf("Maximum size of RX buffer: %u\n", dev_info.max_rx_bufsize); printf("Maximum configurable length of RX packet: %u\n", dev_info.max_rx_pktlen); printf("Maximum configurable size of LRO aggregated packet: %u\n", Checking patch drivers/net/hns3/hns3_common.c... error: while searching for: info->max_tx_queues = hw->tqps_num; info->max_rx_pktlen = HNS3_MAX_FRAME_LEN; /* CRC included */ info->min_rx_bufsize = HNS3_MIN_BD_BUF_SIZE; info->max_mtu = info->max_rx_pktlen - HNS3_ETH_OVERHEAD; info->max_lro_pkt_size = HNS3_MAX_LRO_SIZE; info->rx_offload_capa = (RTE_ETH_RX_OFFLOAD_IPV4_CKSUM | error: patch failed: drivers/net/hns3/hns3_common.c:59 Applying patch drivers/net/hns3/hns3_common.c with 1 reject... Rejected hunk #1. hint: Use 'git am --show-current-patch' to see the failed patch diff a/drivers/net/hns3/hns3_common.c b/drivers/net/hns3/hns3_common.c (rejected hunks) @@ -59,6 +59,7 @@ hns3_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info) info->max_tx_queues = hw->tqps_num; info->max_rx_pktlen = HNS3_MAX_FRAME_LEN; /* CRC included */ info->min_rx_bufsize = HNS3_MIN_BD_BUF_SIZE; + info->max_rx_bufsize = HNS3_MAX_BD_BUF_SIZE; info->max_mtu = info->max_rx_pktlen - HNS3_ETH_OVERHEAD; info->max_lro_pkt_size = HNS3_MAX_LRO_SIZE; info->rx_offload_capa = (RTE_ETH_RX_OFFLOAD_IPV4_CKSUM | https://lab.dpdk.org/results/dashboard/patchsets/28219/ UNH-IOL DPDK Community Lab