* |WARNING| pw133934 [PATCH] lpm: improve performance with copious IPv4 peering routes
@ 2023-11-07 15:21 dpdklab
0 siblings, 0 replies; 3+ messages in thread
From: dpdklab @ 2023-11-07 15:21 UTC (permalink / raw)
To: test-report; +Cc: dpdk-test-reports
Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/133934
_apply patch failure_
Submitter: Warrington, Jeffrey <jwarrington@verisign.com>
Date: Tuesday, November 07 2023 12:49:13
Applied on: CommitID:2bbad8f974e00552d106c27e1d157a31179ab5ec
Apply patch set 133934 failed:
error: corrupt patch at line 11
hint: Use 'git am --show-current-patch' to see the failed patch
https://lab.dpdk.org/results/dashboard/patchsets/28267/
UNH-IOL DPDK Community Lab
^ permalink raw reply [flat|nested] 3+ messages in thread
* |WARNING| pw133934 [PATCH] lpm: improve performance with copious IPv4 peering routes
[not found] <A140CF70-E99E-4DAA-8A14-B3FB19B0A529@verisign.com>
2023-11-07 12:29 ` qemudev
@ 2023-11-07 12:49 ` checkpatch
1 sibling, 0 replies; 3+ messages in thread
From: checkpatch @ 2023-11-07 12:49 UTC (permalink / raw)
To: test-report; +Cc: Warrington, Jeffrey
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/133934
_coding style issues_
WARNING:BAD_SIGN_OFF: Non-standard signature: Co-authored-by:
#85:
Co-authored-by: Julien Charbon <jcharbon@verisign.com>
WARNING:BAD_SIGN_OFF: Non-standard signature: Co-authored-by:
#88:
Co-authored-by: Nicolas Witkowski <nitkowski@verisign.com>
WARNING:BAD_SIGN_OFF: Non-standard signature: Co-authored-by:
#90:
Co-authored-by: Rohit Gupta rogupta@verisign.com
ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Rohit Gupta rogupta@verisign.com'
#90:
Co-authored-by: Rohit Gupta rogupta@verisign.com
ERROR:BAD_SIGN_OFF: Unrecognized email address: 'Rohit Gupta rogupta@verisign.com'
#91:
Signed-off-by: Rohit Gupta rogupta@verisign.com
ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?)
#102: FILE: lib/lpm/rte_lpm.c:15:
#include <rte_string_fns.h>
ERROR:CODE_INDENT: code indent should use tabs where possible
#116: FILE: lib/lpm/rte_lpm.c:60:
+ uint32_t used_rules; /**< Used rules so far. */$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#116: FILE: lib/lpm/rte_lpm.c:60:
+ uint32_t used_rules; /**< Used rules so far. */$
ERROR:CODE_INDENT: code indent should use tabs where possible
#121: FILE: lib/lpm/rte_lpm.c:64:
+ struct rte_hash *rules_tbl; /**< LPM rules. */$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#121: FILE: lib/lpm/rte_lpm.c:64:
+ struct rte_hash *rules_tbl; /**< LPM rules. */$
ERROR:CODE_INDENT: code indent should use tabs where possible
#135: FILE: lib/lpm/rte_lpm.c:89:
+ uint32_t init_val)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#135: FILE: lib/lpm/rte_lpm.c:89:
+ uint32_t init_val)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#137: FILE: lib/lpm/rte_lpm.c:91:
+ return rte_jhash(data, sizeof(struct rte_lpm_rule_key), init_val);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#137: FILE: lib/lpm/rte_lpm.c:91:
+ return rte_jhash(data, sizeof(struct rte_lpm_rule_key), init_val);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#143: FILE: lib/lpm/rte_lpm.c:97:
+ key->ip = ip;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#143: FILE: lib/lpm/rte_lpm.c:97:
+ key->ip = ip;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#144: FILE: lib/lpm/rte_lpm.c:98:
+ key->depth = depth;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#144: FILE: lib/lpm/rte_lpm.c:98:
+ key->depth = depth;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#151: FILE: lib/lpm/rte_lpm.c:105:
+ struct __rte_lpm *i_lpm;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#151: FILE: lib/lpm/rte_lpm.c:105:
+ struct __rte_lpm *i_lpm;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#152: FILE: lib/lpm/rte_lpm.c:106:
+ uint64_t hash_val;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#152: FILE: lib/lpm/rte_lpm.c:106:
+ uint64_t hash_val;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#153: FILE: lib/lpm/rte_lpm.c:107:
+ int ret;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#153: FILE: lib/lpm/rte_lpm.c:107:
+ int ret;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#155: FILE: lib/lpm/rte_lpm.c:109:
+ i_lpm = container_of(lpm, struct __rte_lpm, lpm);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#155: FILE: lib/lpm/rte_lpm.c:109:
+ i_lpm = container_of(lpm, struct __rte_lpm, lpm);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#157: FILE: lib/lpm/rte_lpm.c:111:
+ /* lookup for a rule */$
ERROR:CODE_INDENT: code indent should use tabs where possible
#158: FILE: lib/lpm/rte_lpm.c:112:
+ ret = rte_hash_lookup_data(i_lpm->rules_tbl, (const void *) rule_key,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#158: FILE: lib/lpm/rte_lpm.c:112:
+ ret = rte_hash_lookup_data(i_lpm->rules_tbl, (const void *) rule_key,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#159: FILE: lib/lpm/rte_lpm.c:113:
+ (void **) &hash_val);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#159: FILE: lib/lpm/rte_lpm.c:113:
+ (void **) &hash_val);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#160: FILE: lib/lpm/rte_lpm.c:114:
+ if (ret >= 0) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#160: FILE: lib/lpm/rte_lpm.c:114:
+ if (ret >= 0) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (14, 30)
#160: FILE: lib/lpm/rte_lpm.c:114:
+ if (ret >= 0) {
+ *next_hop = (uint32_t) hash_val;
ERROR:CODE_INDENT: code indent should use tabs where possible
#161: FILE: lib/lpm/rte_lpm.c:115:
+ *next_hop = (uint32_t) hash_val;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#161: FILE: lib/lpm/rte_lpm.c:115:
+ *next_hop = (uint32_t) hash_val;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#162: FILE: lib/lpm/rte_lpm.c:116:
+ return 1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#162: FILE: lib/lpm/rte_lpm.c:116:
+ return 1;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#163: FILE: lib/lpm/rte_lpm.c:117:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#163: FILE: lib/lpm/rte_lpm.c:117:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#165: FILE: lib/lpm/rte_lpm.c:119:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#165: FILE: lib/lpm/rte_lpm.c:119:
+ return 0;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#176: FILE: lib/lpm/rte_lpm.c:199:
+ uint32_t mem_size, tbl8s_size;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#176: FILE: lib/lpm/rte_lpm.c:199:
+ uint32_t mem_size, tbl8s_size;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#178: FILE: lib/lpm/rte_lpm.c:201:
+ struct rte_hash *rules_tbl = NULL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#178: FILE: lib/lpm/rte_lpm.c:201:
+ struct rte_hash *rules_tbl = NULL;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#184: FILE: lib/lpm/rte_lpm.c:213:
+ snprintf(mem_name, sizeof(mem_name), "LRHv4_%s", name);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#184: FILE: lib/lpm/rte_lpm.c:213:
+ snprintf(mem_name, sizeof(mem_name), "LRHv4_%s", name);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#185: FILE: lib/lpm/rte_lpm.c:214:
+ struct rte_hash_parameters rule_hash_tbl_params = {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#185: FILE: lib/lpm/rte_lpm.c:214:
+ struct rte_hash_parameters rule_hash_tbl_params = {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#186: FILE: lib/lpm/rte_lpm.c:215:
+ .entries = config->max_rules * 1.2 + RULE_HASH_TABLE_EXTRA_SPACE,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#186: FILE: lib/lpm/rte_lpm.c:215:
+ .entries = config->max_rules * 1.2 + RULE_HASH_TABLE_EXTRA_SPACE,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#187: FILE: lib/lpm/rte_lpm.c:216:
+ .key_len = sizeof(struct rte_lpm_rule_key),$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#187: FILE: lib/lpm/rte_lpm.c:216:
+ .key_len = sizeof(struct rte_lpm_rule_key),$
ERROR:CODE_INDENT: code indent should use tabs where possible
#188: FILE: lib/lpm/rte_lpm.c:217:
+ .hash_func = rule_hash,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#188: FILE: lib/lpm/rte_lpm.c:217:
+ .hash_func = rule_hash,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#189: FILE: lib/lpm/rte_lpm.c:218:
+ .hash_func_init_val = 0,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#189: FILE: lib/lpm/rte_lpm.c:218:
+ .hash_func_init_val = 0,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#190: FILE: lib/lpm/rte_lpm.c:219:
+ .name = mem_name,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#190: FILE: lib/lpm/rte_lpm.c:219:
+ .name = mem_name,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#191: FILE: lib/lpm/rte_lpm.c:220:
+ .reserved = 0,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#191: FILE: lib/lpm/rte_lpm.c:220:
+ .reserved = 0,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#192: FILE: lib/lpm/rte_lpm.c:221:
+ .socket_id = socket_id,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#192: FILE: lib/lpm/rte_lpm.c:221:
+ .socket_id = socket_id,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#193: FILE: lib/lpm/rte_lpm.c:222:
+ .extra_flag = 0$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#193: FILE: lib/lpm/rte_lpm.c:222:
+ .extra_flag = 0$
ERROR:CODE_INDENT: code indent should use tabs where possible
#194: FILE: lib/lpm/rte_lpm.c:223:
+ };$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#194: FILE: lib/lpm/rte_lpm.c:223:
+ };$
ERROR:CODE_INDENT: code indent should use tabs where possible
#196: FILE: lib/lpm/rte_lpm.c:225:
+ rules_tbl = rte_hash_create(&rule_hash_tbl_params);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#196: FILE: lib/lpm/rte_lpm.c:225:
+ rules_tbl = rte_hash_create(&rule_hash_tbl_params);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#197: FILE: lib/lpm/rte_lpm.c:226:
+ if (rules_tbl == NULL) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#197: FILE: lib/lpm/rte_lpm.c:226:
+ if (rules_tbl == NULL) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (14, 30)
#197: FILE: lib/lpm/rte_lpm.c:226:
+ if (rules_tbl == NULL) {
+ RTE_LOG(ERR, LPM, "LPM rules hash table allocation failed: %s (%d)",
ERROR:CODE_INDENT: code indent should use tabs where possible
#198: FILE: lib/lpm/rte_lpm.c:227:
+ RTE_LOG(ERR, LPM, "LPM rules hash table allocation failed: %s (%d)",$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#198: FILE: lib/lpm/rte_lpm.c:227:
+ RTE_LOG(ERR, LPM, "LPM rules hash table allocation failed: %s (%d)",$
ERROR:CODE_INDENT: code indent should use tabs where possible
#199: FILE: lib/lpm/rte_lpm.c:228:
+ rte_strerror(rte_errno), rte_errno);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#199: FILE: lib/lpm/rte_lpm.c:228:
+ rte_strerror(rte_errno), rte_errno);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#201: FILE: lib/lpm/rte_lpm.c:230:
+ return NULL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#201: FILE: lib/lpm/rte_lpm.c:230:
+ return NULL;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#202: FILE: lib/lpm/rte_lpm.c:231:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#202: FILE: lib/lpm/rte_lpm.c:231:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#230: FILE: lib/lpm/rte_lpm.c:284:
+ i_lpm->rules_tbl = rules_tbl;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#230: FILE: lib/lpm/rte_lpm.c:284:
+ i_lpm->rules_tbl = rules_tbl;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#239: FILE: lib/lpm/rte_lpm.c:333:
+ rte_hash_free(i_lpm->rules_tbl);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#239: FILE: lib/lpm/rte_lpm.c:333:
+ rte_hash_free(i_lpm->rules_tbl);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#253: FILE: lib/lpm/rte_lpm.c:415:
+ int ret, rule_exist;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#253: FILE: lib/lpm/rte_lpm.c:415:
+ int ret, rule_exist;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#254: FILE: lib/lpm/rte_lpm.c:416:
+ struct rte_lpm_rule_key rule_key;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#254: FILE: lib/lpm/rte_lpm.c:416:
+ struct rte_lpm_rule_key rule_key;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#255: FILE: lib/lpm/rte_lpm.c:417:
+ uint32_t unused;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#255: FILE: lib/lpm/rte_lpm.c:417:
+ uint32_t unused;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#259: FILE: lib/lpm/rte_lpm.c:419:
+ /* init a rule key */$
ERROR:CODE_INDENT: code indent should use tabs where possible
#260: FILE: lib/lpm/rte_lpm.c:420:
+ rule_key_init(&rule_key, ip_masked, depth);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#260: FILE: lib/lpm/rte_lpm.c:420:
+ rule_key_init(&rule_key, ip_masked, depth);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#267: FILE: lib/lpm/rte_lpm.c:421:
+ /* Scan through rule list to see if rule already exists. */$
ERROR:CODE_INDENT: code indent should use tabs where possible
#268: FILE: lib/lpm/rte_lpm.c:422:
+ rule_exist = rule_find_with_key(lpm, &rule_key, &unused);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#268: FILE: lib/lpm/rte_lpm.c:422:
+ rule_exist = rule_find_with_key(lpm, &rule_key, &unused);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#270: FILE: lib/lpm/rte_lpm.c:423:
+ struct __rte_lpm *i_lpm = container_of(lpm, struct __rte_lpm, lpm);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#270: FILE: lib/lpm/rte_lpm.c:423:
+ struct __rte_lpm *i_lpm = container_of(lpm, struct __rte_lpm, lpm);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#273: FILE: lib/lpm/rte_lpm.c:424:
+ if (!rule_exist && i_lpm->used_rules == i_lpm->max_rules)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#273: FILE: lib/lpm/rte_lpm.c:424:
+ if (!rule_exist && i_lpm->used_rules == i_lpm->max_rules)$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (14, 30)
#273: FILE: lib/lpm/rte_lpm.c:424:
+ if (!rule_exist && i_lpm->used_rules == i_lpm->max_rules)
+ return -ENOSPC;
ERROR:CODE_INDENT: code indent should use tabs where possible
#274: FILE: lib/lpm/rte_lpm.c:425:
+ return -ENOSPC;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#274: FILE: lib/lpm/rte_lpm.c:425:
+ return -ENOSPC;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#279: FILE: lib/lpm/rte_lpm.c:426:
+ ret = rte_hash_add_key_data(i_lpm->rules_tbl, &rule_key,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#279: FILE: lib/lpm/rte_lpm.c:426:
+ ret = rte_hash_add_key_data(i_lpm->rules_tbl, &rule_key,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#280: FILE: lib/lpm/rte_lpm.c:427:
+ (void *)(uintptr_t) next_hop);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#280: FILE: lib/lpm/rte_lpm.c:427:
+ (void *)(uintptr_t) next_hop);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#321: FILE: lib/lpm/rte_lpm.c:428:
+ if (ret < 0)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#321: FILE: lib/lpm/rte_lpm.c:428:
+ if (ret < 0)$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (14, 30)
#321: FILE: lib/lpm/rte_lpm.c:428:
+ if (ret < 0)
+ return ret;
ERROR:CODE_INDENT: code indent should use tabs where possible
#322: FILE: lib/lpm/rte_lpm.c:429:
+ return ret;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#322: FILE: lib/lpm/rte_lpm.c:429:
+ return ret;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#325: FILE: lib/lpm/rte_lpm.c:431:
+ if (!rule_exist) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#325: FILE: lib/lpm/rte_lpm.c:431:
+ if (!rule_exist) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (14, 30)
#325: FILE: lib/lpm/rte_lpm.c:431:
+ if (!rule_exist) {
+ i_lpm->rule_info[depth - 1].used_rules++;
ERROR:CODE_INDENT: code indent should use tabs where possible
#326: FILE: lib/lpm/rte_lpm.c:432:
+ i_lpm->rule_info[depth - 1].used_rules++;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#326: FILE: lib/lpm/rte_lpm.c:432:
+ i_lpm->rule_info[depth - 1].used_rules++;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#327: FILE: lib/lpm/rte_lpm.c:433:
+ i_lpm->used_rules++;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#327: FILE: lib/lpm/rte_lpm.c:433:
+ i_lpm->used_rules++;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#328: FILE: lib/lpm/rte_lpm.c:434:
+ return 1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#328: FILE: lib/lpm/rte_lpm.c:434:
+ return 1;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#329: FILE: lib/lpm/rte_lpm.c:435:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#329: FILE: lib/lpm/rte_lpm.c:435:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#331: FILE: lib/lpm/rte_lpm.c:436:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#331: FILE: lib/lpm/rte_lpm.c:436:
+ return 0;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#343: FILE: lib/lpm/rte_lpm.c:443:
+ int ret;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#343: FILE: lib/lpm/rte_lpm.c:443:
+ int ret;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#344: FILE: lib/lpm/rte_lpm.c:444:
+ struct rte_lpm_rule_key rule_key;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#344: FILE: lib/lpm/rte_lpm.c:444:
+ struct rte_lpm_rule_key rule_key;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#349: FILE: lib/lpm/rte_lpm.c:446:
+ rule_key_init(&rule_key, ip, depth);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#349: FILE: lib/lpm/rte_lpm.c:446:
+ rule_key_init(&rule_key, ip, depth);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#357: FILE: lib/lpm/rte_lpm.c:447:
+ /* delete the rule */$
ERROR:CODE_INDENT: code indent should use tabs where possible
#358: FILE: lib/lpm/rte_lpm.c:448:
+ ret = rte_hash_del_key(i_lpm->rules_tbl, (void *) &rule_key);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#358: FILE: lib/lpm/rte_lpm.c:448:
+ ret = rte_hash_del_key(i_lpm->rules_tbl, (void *) &rule_key);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#360: FILE: lib/lpm/rte_lpm.c:450:
+ if (ret >= 0) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#360: FILE: lib/lpm/rte_lpm.c:450:
+ if (ret >= 0) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (14, 30)
#360: FILE: lib/lpm/rte_lpm.c:450:
+ if (ret >= 0) {
+ i_lpm->rule_info[depth - 1].used_rules--;
ERROR:CODE_INDENT: code indent should use tabs where possible
#361: FILE: lib/lpm/rte_lpm.c:451:
+ i_lpm->rule_info[depth - 1].used_rules--;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#361: FILE: lib/lpm/rte_lpm.c:451:
+ i_lpm->rule_info[depth - 1].used_rules--;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#362: FILE: lib/lpm/rte_lpm.c:452:
+ i_lpm->used_rules--;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#362: FILE: lib/lpm/rte_lpm.c:452:
+ i_lpm->used_rules--;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#365: FILE: lib/lpm/rte_lpm.c:454:
+ return ret;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#365: FILE: lib/lpm/rte_lpm.c:454:
+ return ret;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#381: FILE: lib/lpm/rte_lpm.c:480:
+ struct rte_lpm_rule_key rule_key;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#381: FILE: lib/lpm/rte_lpm.c:480:
+ struct rte_lpm_rule_key rule_key;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#388: FILE: lib/lpm/rte_lpm.c:481:
+ /* init a rule key */$
ERROR:CODE_INDENT: code indent should use tabs where possible
#389: FILE: lib/lpm/rte_lpm.c:482:
+ rule_key_init(&rule_key, ip_masked, depth);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#389: FILE: lib/lpm/rte_lpm.c:482:
+ rule_key_init(&rule_key, ip_masked, depth);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#392: FILE: lib/lpm/rte_lpm.c:483:
+ return rule_find_with_key(lpm, &rule_key, next_hop);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#392: FILE: lib/lpm/rte_lpm.c:483:
+ return rule_find_with_key(lpm, &rule_key, next_hop);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#400: FILE: lib/lpm/rte_lpm.c:801:
+ int32_t status = 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#400: FILE: lib/lpm/rte_lpm.c:801:
+ int32_t status = 0;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#413: FILE: lib/lpm/rte_lpm.c:814:
+ status = rule_add(lpm, ip_masked, depth, next_hop);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#413: FILE: lib/lpm/rte_lpm.c:814:
+ status = rule_add(lpm, ip_masked, depth, next_hop);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#417: FILE: lib/lpm/rte_lpm.c:816:
+ if (status < 0) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#417: FILE: lib/lpm/rte_lpm.c:816:
+ if (status < 0) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (14, 30)
#417: FILE: lib/lpm/rte_lpm.c:816:
+ if (status < 0) {
+ return status;
ERROR:CODE_INDENT: code indent should use tabs where possible
#418: FILE: lib/lpm/rte_lpm.c:817:
+ return status;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#418: FILE: lib/lpm/rte_lpm.c:817:
+ return status;$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (30, 46)
#424: FILE: lib/lpm/rte_lpm.c:831:
if (status < 0) {
+ rule_delete(i_lpm, ip_masked, depth);
ERROR:CODE_INDENT: code indent should use tabs where possible
#426: FILE: lib/lpm/rte_lpm.c:832:
+ rule_delete(i_lpm, ip_masked, depth);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#426: FILE: lib/lpm/rte_lpm.c:832:
+ rule_delete(i_lpm, ip_masked, depth);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#446: FILE: lib/lpm/rte_lpm.c:857:
+ if (rule_find(lpm, ip_masked, depth, next_hop))$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#446: FILE: lib/lpm/rte_lpm.c:857:
+ if (rule_find(lpm, ip_masked, depth, next_hop))$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (14, 30)
#446: FILE: lib/lpm/rte_lpm.c:857:
+ if (rule_find(lpm, ip_masked, depth, next_hop))
return 1;
ERROR:CODE_INDENT: code indent should use tabs where possible
#456: FILE: lib/lpm/rte_lpm.c:863:
+ uint32_t *subrule_prev_hop, uint8_t *subrule_prev_depth)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#456: FILE: lib/lpm/rte_lpm.c:863:
+ uint32_t *subrule_prev_hop, uint8_t *subrule_prev_depth)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#460: FILE: lib/lpm/rte_lpm.c:865:
+ uint32_t prev_hop;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#460: FILE: lib/lpm/rte_lpm.c:865:
+ uint32_t prev_hop;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#462: FILE: lib/lpm/rte_lpm.c:867:
+ int found;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#462: FILE: lib/lpm/rte_lpm.c:867:
+ int found;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#466: FILE: lib/lpm/rte_lpm.c:870:
+ found = rule_find(lpm, ip_masked, prev_depth, &prev_hop);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#466: FILE: lib/lpm/rte_lpm.c:870:
+ found = rule_find(lpm, ip_masked, prev_depth, &prev_hop);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#470: FILE: lib/lpm/rte_lpm.c:871:
+ if (found) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#470: FILE: lib/lpm/rte_lpm.c:871:
+ if (found) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (30, 46)
#470: FILE: lib/lpm/rte_lpm.c:871:
+ if (found) {
+ *subrule_prev_hop = prev_hop;
ERROR:CODE_INDENT: code indent should use tabs where possible
#471: FILE: lib/lpm/rte_lpm.c:872:
+ *subrule_prev_hop = prev_hop;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#471: FILE: lib/lpm/rte_lpm.c:872:
+ *subrule_prev_hop = prev_hop;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#472: FILE: lib/lpm/rte_lpm.c:873:
+ *subrule_prev_depth = prev_depth;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#472: FILE: lib/lpm/rte_lpm.c:873:
+ *subrule_prev_depth = prev_depth;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#473: FILE: lib/lpm/rte_lpm.c:874:
+ return 1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#473: FILE: lib/lpm/rte_lpm.c:874:
+ return 1;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#477: FILE: lib/lpm/rte_lpm.c:877:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#477: FILE: lib/lpm/rte_lpm.c:877:
+ return 0;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#482: FILE: lib/lpm/rte_lpm.c:879:
+ uint8_t depth, int found, uint32_t sub_rule_hop, uint8_t sub_rule_depth)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#482: FILE: lib/lpm/rte_lpm.c:879:
+ uint8_t depth, int found, uint32_t sub_rule_hop, uint8_t sub_rule_depth)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#491: FILE: lib/lpm/rte_lpm.c:906:
+ if (!found) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#491: FILE: lib/lpm/rte_lpm.c:906:
+ if (!found) {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#499: FILE: lib/lpm/rte_lpm.c:942:
+ .next_hop = sub_rule_hop,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#499: FILE: lib/lpm/rte_lpm.c:942:
+ .next_hop = sub_rule_hop,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#509: FILE: lib/lpm/rte_lpm.c:953:
+ .next_hop = sub_rule_hop,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#509: FILE: lib/lpm/rte_lpm.c:953:
+ .next_hop = sub_rule_hop,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#516: FILE: lib/lpm/rte_lpm.c:1043:
+ uint8_t depth, int found, uint32_t sub_rule_hop, uint8_t sub_rule_depth)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#516: FILE: lib/lpm/rte_lpm.c:1043:
+ uint8_t depth, int found, uint32_t sub_rule_hop, uint8_t sub_rule_depth)$
ERROR:CODE_INDENT: code indent should use tabs where possible
#524: FILE: lib/lpm/rte_lpm.c:1063:
+ if (!found) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#524: FILE: lib/lpm/rte_lpm.c:1063:
+ if (!found) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (14, 0)
#524: FILE: lib/lpm/rte_lpm.c:1063:
+ if (!found) {
[...]
@@ -1086,7 +1076,7 @@ delete_depth_big(struct __rte_lpm *i_lpm, uint32_t ip_masked,
ERROR:CODE_INDENT: code indent should use tabs where possible
#533: FILE: lib/lpm/rte_lpm.c:1079:
+ .next_hop = sub_rule_hop,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#533: FILE: lib/lpm/rte_lpm.c:1079:
+ .next_hop = sub_rule_hop,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#541: FILE: lib/lpm/rte_lpm.c:1132:
+ int32_t found;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#541: FILE: lib/lpm/rte_lpm.c:1132:
+ int32_t found;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#544: FILE: lib/lpm/rte_lpm.c:1135:
+ uint32_t sub_rule_hop;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#544: FILE: lib/lpm/rte_lpm.c:1135:
+ uint32_t sub_rule_hop;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#566: FILE: lib/lpm/rte_lpm.c:1151:
+ if (rule_delete(i_lpm, ip_masked, depth) < 0)$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#566: FILE: lib/lpm/rte_lpm.c:1151:
+ if (rule_delete(i_lpm, ip_masked, depth) < 0)$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (14, 30)
#566: FILE: lib/lpm/rte_lpm.c:1151:
+ if (rule_delete(i_lpm, ip_masked, depth) < 0)
+ return -EINVAL;
ERROR:CODE_INDENT: code indent should use tabs where possible
#567: FILE: lib/lpm/rte_lpm.c:1152:
+ return -EINVAL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#567: FILE: lib/lpm/rte_lpm.c:1152:
+ return -EINVAL;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#575: FILE: lib/lpm/rte_lpm.c:1161:
+ found = find_previous_rule(lpm, ip, depth, &sub_rule_hop, &sub_rule_depth);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#575: FILE: lib/lpm/rte_lpm.c:1161:
+ found = find_previous_rule(lpm, ip, depth, &sub_rule_hop, &sub_rule_depth);$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (14, 30)
#580: FILE: lib/lpm/rte_lpm.c:1166:
if (depth <= MAX_DEPTH_TBL24) {
+ return delete_depth_small(i_lpm, ip_masked, depth, found,
ERROR:CODE_INDENT: code indent should use tabs where possible
#586: FILE: lib/lpm/rte_lpm.c:1167:
+ return delete_depth_small(i_lpm, ip_masked, depth, found,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#586: FILE: lib/lpm/rte_lpm.c:1167:
+ return delete_depth_small(i_lpm, ip_masked, depth, found,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#587: FILE: lib/lpm/rte_lpm.c:1168:
+ sub_rule_hop, sub_rule_depth);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#587: FILE: lib/lpm/rte_lpm.c:1168:
+ sub_rule_hop, sub_rule_depth);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#588: FILE: lib/lpm/rte_lpm.c:1169:
+ } else {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#588: FILE: lib/lpm/rte_lpm.c:1169:
+ } else {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (14, 30)
#588: FILE: lib/lpm/rte_lpm.c:1169:
+ } else {
+ return delete_depth_big(i_lpm, ip_masked, depth, found,
ERROR:CODE_INDENT: code indent should use tabs where possible
#589: FILE: lib/lpm/rte_lpm.c:1170:
+ return delete_depth_big(i_lpm, ip_masked, depth, found,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#589: FILE: lib/lpm/rte_lpm.c:1170:
+ return delete_depth_big(i_lpm, ip_masked, depth, found,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#590: FILE: lib/lpm/rte_lpm.c:1171:
+ sub_rule_hop, sub_rule_depth);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#590: FILE: lib/lpm/rte_lpm.c:1171:
+ sub_rule_hop, sub_rule_depth);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#597: FILE: lib/lpm/rte_lpm.c:1187:
+ i_lpm->used_rules = 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#597: FILE: lib/lpm/rte_lpm.c:1187:
+ i_lpm->used_rules = 0;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#604: FILE: lib/lpm/rte_lpm.c:1196:
+ rte_hash_reset(i_lpm->rules_tbl);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#604: FILE: lib/lpm/rte_lpm.c:1196:
+ rte_hash_reset(i_lpm->rules_tbl);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#614: FILE: lib/lpm/rte_lpm.h:111:
+ uint32_t ip; /**< Rule IP address. */$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#614: FILE: lib/lpm/rte_lpm.h:111:
+ uint32_t ip; /**< Rule IP address. */$
ERROR:CODE_INDENT: code indent should use tabs where possible
#615: FILE: lib/lpm/rte_lpm.h:112:
+ uint32_t depth; /**< Rule depth. */$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#615: FILE: lib/lpm/rte_lpm.h:112:
+ uint32_t depth; /**< Rule depth. */$
WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name mismatch: 'From: "Warrington, Jeffrey" <jwarrington@verisign.com>' != 'Signed-off-by: Jeff Warrington <jwarrington@verisign.com>'
total: 111 errors, 121 warnings, 493 lines checked
^ permalink raw reply [flat|nested] 3+ messages in thread
* |WARNING| pw133934 [PATCH] lpm: improve performance with copious IPv4 peering routes
[not found] <A140CF70-E99E-4DAA-8A14-B3FB19B0A529@verisign.com>
@ 2023-11-07 12:29 ` qemudev
2023-11-07 12:49 ` checkpatch
1 sibling, 0 replies; 3+ messages in thread
From: qemudev @ 2023-11-07 12:29 UTC (permalink / raw)
To: test-report; +Cc: Warrington, Jeffrey, zhoumin
Test-Label: loongarch-compilation
Test-Status: WARNING
http://dpdk.org/patch/133934
_apply patch failure_
Submitter: Warrington, Jeffrey <jwarrington@verisign.com>
Date: Tue, 7 Nov 2023 12:49:13 +0000
DPDK git baseline: Repo:dpdk
Branch: main
CommitID: 2bbad8f974e00552d106c27e1d157a31179ab5ec
Apply patch set 133934 failed:
error: corrupt patch at line 103
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-07 15:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-07 15:21 |WARNING| pw133934 [PATCH] lpm: improve performance with copious IPv4 peering routes dpdklab
[not found] <A140CF70-E99E-4DAA-8A14-B3FB19B0A529@verisign.com>
2023-11-07 12:29 ` qemudev
2023-11-07 12:49 ` checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).