|WARNING| pw138770 [RFC PATCH v3] net/iavf: support rte flow with mask for FDIR

|WARNING| pw138770 [RFC PATCH v3] net/iavf: support rte flow with mask for FDIR

[qemudev]

Test-Label: loongarch-compilation
Test-Status: WARNING
http://dpdk.org/patch/138770

_apply patch failure_

Submitter: Ian Stokes <ian.stokes@intel.com>
Date: Mon, 25 Mar 2024 17:01:41 +0000
DPDK git baseline: Repo:dpdk-next-net
  Branch: main
  CommitID: 3ce30fc646084443eb06eb808c73e3312edc90d1

Apply patch set 138770 failed:

Checking patch drivers/common/iavf/virtchnl.h...
error: while searching for:
};

#define VIRTCHNL_MAX_NUM_PROTO_HDRS	32
#define PROTO_HDR_SHIFT			5
#define PROTO_HDR_FIELD_START(proto_hdr_type) \
					(proto_hdr_type << PROTO_HDR_SHIFT)

error: patch failed: drivers/common/iavf/virtchnl.h:1482
error: drivers/common/iavf/virtchnl.h: patch does not apply
Checking patch drivers/net/iavf/iavf_ethdev.c...
Hunk #1 succeeded at 535 (offset 35 lines).
Hunk #2 succeeded at 565 (offset 35 lines).
Checking patch drivers/net/iavf/iavf_fdir.c...
error: while searching for:
	const struct rte_flow_item_ecpri *ecpri_spec, *ecpri_mask;
	const struct rte_flow_item_gre *gre_spec, *gre_mask;
	const struct rte_flow_item *item = pattern;
	struct virtchnl_proto_hdr *hdr, *hdr1 = NULL;
	struct rte_ecpri_common_hdr ecpri_common;
	uint64_t input_set = IAVF_INSET_NONE;

error: patch failed: drivers/net/iavf/iavf_fdir.c:695
error: drivers/net/iavf/iavf_fdir.c: patch does not apply
Checking patch drivers/net/iavf/iavf_hash.c...
error: while searching for:
/* proto_hdrs template */
struct virtchnl_proto_hdrs outer_ipv4_tmplt = {
	TUNNEL_LEVEL_OUTER, 4,
	{proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan, proto_hdr_ipv4}
};

struct virtchnl_proto_hdrs outer_ipv4_udp_tmplt = {
	TUNNEL_LEVEL_OUTER, 5,
	{proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan,
	 proto_hdr_ipv4_with_prot,
	 proto_hdr_udp}
};

struct virtchnl_proto_hdrs outer_ipv4_tcp_tmplt = {
	TUNNEL_LEVEL_OUTER, 5,
	{proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan,
	 proto_hdr_ipv4_with_prot,
	 proto_hdr_tcp}
};

struct virtchnl_proto_hdrs outer_ipv4_sctp_tmplt = {
	TUNNEL_LEVEL_OUTER, 5,
	{proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan, proto_hdr_ipv4,
	 proto_hdr_sctp}
};

struct virtchnl_proto_hdrs outer_ipv6_tmplt = {
	TUNNEL_LEVEL_OUTER, 4,
	{proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan, proto_hdr_ipv6}
};

struct virtchnl_proto_hdrs outer_ipv6_frag_tmplt = {
	TUNNEL_LEVEL_OUTER, 5,
	{proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan,
	 proto_hdr_ipv6, proto_hdr_ipv6_frag}
};

struct virtchnl_proto_hdrs outer_ipv6_udp_tmplt = {
	TUNNEL_LEVEL_OUTER, 5,
	{proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan,
	 proto_hdr_ipv6_with_prot,
	 proto_hdr_udp}
};

struct virtchnl_proto_hdrs outer_ipv6_tcp_tmplt = {
	TUNNEL_LEVEL_OUTER, 5,
	{proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan,
	 proto_hdr_ipv6_with_prot,
	 proto_hdr_tcp}
};

struct virtchnl_proto_hdrs outer_ipv6_sctp_tmplt = {
	TUNNEL_LEVEL_OUTER, 5,
	{proto_hdr_eth, proto_hdr_svlan, proto_hdr_cvlan, proto_hdr_ipv6,
	 proto_hdr_sctp}
};

struct virtchnl_proto_hdrs inner_ipv4_tmplt = {
	TUNNEL_LEVEL_INNER, 1, {proto_hdr_ipv4}
};

struct virtchnl_proto_hdrs inner_ipv4_udp_tmplt = {
	TUNNEL_LEVEL_INNER, 2, {proto_hdr_ipv4_with_prot, proto_hdr_udp}
};

struct virtchnl_proto_hdrs inner_ipv4_tcp_tmplt = {
	TUNNEL_LEVEL_INNER, 2, {proto_hdr_ipv4_with_prot, proto_hdr_tcp}
};

struct virtchnl_proto_hdrs second_inner_ipv4_tmplt = {
	2, 1, {proto_hdr_ipv4}
};

struct virtchnl_proto_hdrs second_inner_ipv4_udp_tmplt = {
	2, 2, {proto_hdr_ipv4_with_prot, proto_hdr_udp}
};

struct virtchnl_proto_hdrs second_inner_ipv4_tcp_tmplt = {
	2, 2, {proto_hdr_ipv4_with_prot, proto_hdr_tcp}
};

struct virtchnl_proto_hdrs second_inner_ipv6_tmplt = {
	2, 1, {proto_hdr_ipv6}
};

struct virtchnl_proto_hdrs second_inner_ipv6_udp_tmplt = {
	2, 2, {proto_hdr_ipv6_with_prot, proto_hdr_udp}
};

struct virtchnl_proto_hdrs second_inner_ipv6_tcp_tmplt = {
	2, 2, {proto_hdr_ipv6_with_prot, proto_hdr_tcp}
};

struct virtchnl_proto_hdrs inner_ipv4_sctp_tmplt = {
	TUNNEL_LEVEL_INNER, 2, {proto_hdr_ipv4, proto_hdr_sctp}
};

struct virtchnl_proto_hdrs inner_ipv6_tmplt = {
	TUNNEL_LEVEL_INNER, 1, {proto_hdr_ipv6}
};

struct virtchnl_proto_hdrs inner_ipv6_udp_tmplt = {
	TUNNEL_LEVEL_INNER, 2, {proto_hdr_ipv6_with_prot, proto_hdr_udp}
};

struct virtchnl_proto_hdrs inner_ipv6_tcp_tmplt = {
	TUNNEL_LEVEL_INNER, 2, {proto_hdr_ipv6_with_prot, proto_hdr_tcp}
};

struct virtchnl_proto_hdrs inner_ipv6_sctp_tmplt = {
	TUNNEL_LEVEL_INNER, 2, {proto_hdr_ipv6, proto_hdr_sctp}
};

struct virtchnl_proto_hdrs ipv4_esp_tmplt = {
	TUNNEL_LEVEL_OUTER, 2, {proto_hdr_ipv4, proto_hdr_esp}
};

struct virtchnl_proto_hdrs ipv4_udp_esp_tmplt = {
	TUNNEL_LEVEL_OUTER, 3,
	{proto_hdr_ipv4, proto_hdr_udp, proto_hdr_esp}
};

struct virtchnl_proto_hdrs ipv4_ah_tmplt = {
	TUNNEL_LEVEL_OUTER, 2, {proto_hdr_ipv4, proto_hdr_ah}
};

struct virtchnl_proto_hdrs ipv6_esp_tmplt = {
	TUNNEL_LEVEL_OUTER, 2, {proto_hdr_ipv6, proto_hdr_esp}
};

struct virtchnl_proto_hdrs ipv6_udp_esp_tmplt = {
	TUNNEL_LEVEL_OUTER, 3,
	{proto_hdr_ipv6, proto_hdr_udp, proto_hdr_esp}
};

struct virtchnl_proto_hdrs ipv6_ah_tmplt = {
	TUNNEL_LEVEL_OUTER, 2, {proto_hdr_ipv6, proto_hdr_ah}
};

struct virtchnl_proto_hdrs ipv4_l2tpv3_tmplt = {
	TUNNEL_LEVEL_OUTER, 2, {proto_hdr_ipv4, proto_hdr_l2tpv3}
};

struct virtchnl_proto_hdrs ipv6_l2tpv3_tmplt = {
	TUNNEL_LEVEL_OUTER, 2, {proto_hdr_ipv6, proto_hdr_l2tpv3}
};

struct virtchnl_proto_hdrs ipv4_pfcp_tmplt = {
	TUNNEL_LEVEL_OUTER, 2, {proto_hdr_ipv4, proto_hdr_pfcp}
};

struct virtchnl_proto_hdrs i
error: patch failed: drivers/net/iavf/iavf_hash.c:178
error: drivers/net/iavf/iavf_hash.c: patch does not apply
Checking patch drivers/net/ice/ice_ethdev.c...
Hunk #1 succeeded at 3410 (offset 213 lines).
Hunk #2 succeeded at 3471 (offset 213 lines).
Checking patch lib/ethdev/rte_ethdev.h...
error: while searching for:
#define RTE_ETHDEV_DEBUG_TX
#endif

#include <rte_compat.h>
#include <rte_log.h>
#include <rte_interrupts.h>

error: patch failed: lib/ethdev/rte_ethdev.h:160
error: lib/ethdev/rte_ethdev.h: patch does not apply

|WARNING| pw138770 [RFC PATCH v3] net/iavf: support rte flow with mask for FDIR

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/138770

_coding style issues_

Must be a reply to the first patch (--in-reply-to).


WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#282: FILE: drivers/net/iavf/iavf_fdir.c:770:
+					} else if (!rte_is_zero_ether_addr(&eth_mask->hdr.src_addr)) {

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#290: FILE: drivers/net/iavf/iavf_fdir.c:778:
+						if (eth_mask->type != RTE_BE16(0xffff)) {

WARNING:DEEP_INDENTATION: Too many leading tabs - consider code refactoring
#298: FILE: drivers/net/iavf/iavf_fdir.c:786:
+						if (ether_type == RTE_ETHER_TYPE_IPV4 ||

total: 0 errors, 3 warnings, 859 lines checked

|WARNING| pw138770 [PATCH] [RFC, v3] net/iavf: support rte flow with mask for FDIR

[dpdklab]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/138770

_apply patch failure_

Submitter: Ian Stokes <ian.stokes@intel.com>
Date: Monday, March 25 2024 17:01:41 
Applied on: CommitID:0b82b5139fefe6eb5ec1a0b489fd193e8a99ab73
Apply patch set 138770 failed:

Cloning the DPDK mirror at: https://github.com/DPDK/dpdk.git (Attempt 1 of 3)
Trying to checkout branch: origin/main
Checked out to main (0b82b5139fefe6eb5ec1a0b489fd193e8a99ab73)
Done: main commit 0b82b5139fefe6eb5ec1a0b489fd193e8a99ab73
Trying to checkout branch: origin/next-net-for-main
Checked out to next-net-for-main (3ce30fc646084443eb06eb808c73e3312edc90d1)
Applying patch...

Failed to apply patch:
Applying: net/iavf: support rte flow with mask for FDIR
error: sha1 information is lacking or useless (drivers/net/iavf/iavf_ethdev.c).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch' to see the failed patch
Patch failed at 0001 net/iavf: support rte flow with mask for FDIR
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".


Trying to checkout branch: origin/main
Checked out to main (0b82b5139fefe6eb5ec1a0b489fd193e8a99ab73)
Applying patch...

Failed to apply patch:
Applying: net/iavf: support rte flow with mask for FDIR
error: sha1 information is lacking or useless (drivers/net/iavf/iavf_ethdev.c).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch' to see the failed patch
Patch failed at 0001 net/iavf: support rte flow with mask for FDIR
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".


https://lab.dpdk.org/results/dashboard/patchsets/29652/

UNH-IOL DPDK Community Lab