Test-Label: intel-Testing
Test-Status: SUCCESS 
_Testing PASS 

DPDK git repo: dpdk-next-net

commit 964ccaf2fe229ef31f57574176f966af7fcefae4
Author: Huisong Li <lihuisong@huawei.com>
Date:   Fri May 19 17:31:55 2023 +0800

    ethdev: fix one address occupies two entries in MAC addrs
    
    The dev->data->mac_addrs[0] will be changed to a new MAC address when
    applications modify the default MAC address by .mac_addr_set(). However,
    if the new default one has been added as a non-default MAC address by
    .mac_addr_add(), the .mac_addr_set() didn't check this address.
    As a result, this MAC address occupies two entries in the list. Like:
    add(MAC1)
    add(MAC2)
    add(MAC3)
    add(MAC4)
    set_default(MAC3)
    default=MAC3, the rest of the list=MAC1, MAC2, MAC3, MAC4
    Note: MAC3 occupies two entries.
    
    But .mac_addr_set() cannot remove it implicitly in case of MAC address
    shrinking in the list.
    So this patch adds a check on whether the new default address was
    already in the list and if so requires the user to remove it first.
    
    In addition, this patch documents the position of the default MAC
    address and address unique in the list.
    
    Fixes: 854d8ad4ef68 ("ethdev: add default mac address modifier")
    Cc: stable@dpdk.org
    
    Signed-off-by: Huisong Li <lihuisong@huawei.com>
    Acked-by: Chengwen Feng <fengchengwen@huawei.com>
    Acked-by: Thomas Monjalon <thomas@monjalon.net>
    Reviewed-by: Ferruh Yigit <ferruh.yigit@amd.com>

Testing Summary : 18 Case Done, 18 Successful, 0 Failures

Testbed #1: 9 Case Done, 9 Successful, 0 Failures 
	* Test result details:
	  +-------------+---------------------------+-------+
	  | suite       | case                      | status|
	  +-------------+---------------------------+-------+
	  | asan_smoke  | test_rxtx_with_ASan_enable| passed|
	  | pf_smoke    | test_pf_jumbo_frames      | passed|
	  | pf_smoke    | test_pf_rss               | passed|
	  | pf_smoke    | test_pf_tx_rx_queue       | passed|
	  | vf_smoke    | test_vf_jumbo_frames      | passed|
	  | vf_smoke    | test_vf_rss               | passed|
	  | vf_smoke    | test_vf_tx_rx_queue       | passed|
	  | virtio_smoke| test_virtio_loopback      | passed|
	  | virtio_smoke| test_virtio_pvp           | passed|
	  +-------------+---------------------------+-------+
	* Environment:
	  OS : Ubuntu 22.04.2 LTS       
	  Kernel : 5.15.0-60-generic         
	  GCC : 11.3.0-1ubuntu1~22.04        
	  NIC : Ethernet Controller E810-C for SFP         
	  Target : x86_64-native-linuxapp-gcc      

Testbed #2: 9 Case Done, 9 Successful, 0 Failures 
	* Test result details:
	  +-------------+---------------------------+-------+
	  | suite       | case                      | status|
	  +-------------+---------------------------+-------+
	  | asan_smoke  | test_rxtx_with_ASan_enable| passed|
	  | pf_smoke    | test_pf_jumbo_frames      | passed|
	  | pf_smoke    | test_pf_rss               | passed|
	  | pf_smoke    | test_pf_tx_rx_queue       | passed|
	  | vf_smoke    | test_vf_rss               | passed|
	  | vf_smoke    | test_vf_tx_rx_queue       | passed|
	  | vf_smoke    | test_vf_jumbo_frames      | n/a   |
	  | virtio_smoke| test_virtio_loopback      | passed|
	  | virtio_smoke| test_virtio_pvp           | passed|
	  +-------------+---------------------------+-------+
	* Environment:
	  OS : Ubuntu 22.04.2 LTS       
	  Kernel : 5.15.0-60-generic         
	  GCC : 11.3.0-1ubuntu1~22.04        
	  NIC : Ethernet Controller XL710 for 40GbE QSFP+         
	  Target : x86_64-native-linuxapp-gcc      

TestPlan:
	   pf_smoke: http://git.dpdk.org/tools/dts/tree/test_plans/pf_smoke_test_plan.rst
	   vf_smoke: http://git.dpdk.org/tools/dts/tree/test_plans/vf_smoke_test_plan.rst
	   asan_smoke: http://git.dpdk.org/tools/dts/tree/test_plans/asan_smoke_test_plan.rst

TestSuite:
	   pf_smoke: http://git.dpdk.org/tools/dts/tree/tests/TestSuite_pf_smoke.py
	   vf_smoke: http://git.dpdk.org/tools/dts/tree/tests/TestSuite_vf_smoke.py
	   virtio_smoke: http://git.dpdk.org/tools/dts/tree/tests/TestSuite_virtio_smoke.py
	   asan_smoke: http://git.dpdk.org/tools/dts/tree/tests/TestSuite_asan_smoke.py


DPDK STV team