[dpdk-test-report] [PatchWork]|ERROR| pw12834-12868 mempool: rework comments and style

[dpdk-test-report] [PatchWork]|ERROR| pw12834-12868 mempool: rework comments and style

[sys_stv]

[-- Attachment #1: Type: text/plain, Size: 2947 bytes --]


Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 12834-12868
http://www.dpdk.org/dev/patchwork/patch/12868/
Submitter: Olivier Matz <olivier.matz@6wind.com>
Date: Wed, 18 May 2016 13:04:22 +0200
DPDK git baseline: 213af31e0960e5086bce280364b2eb0d9c6cd261

Check patch error:
12841: 
ERROR: do not use assignment in if condition
#293: FILE: lib/librte_mempool/rte_mempool.c:396:
+	if ((n = rte_mempool_obj_mem_iter(vaddr, elt_num, total_elt_sz, 1,

total: 1 errors, 0 warnings, 348 lines checked

/home/patchWorkOrg/patches/dpdk-dev-v3-09-35-mempool-use-the-list-to-iterate-the-elements.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

12835: 
ERROR: do not use assignment in if condition
#85: FILE: lib/librte_mempool/rte_mempool.c:343:
+	if ((n = pg_sz / total_elt_sz) > 0) {

ERROR: do not use assignment in if condition
#108: FILE: lib/librte_mempool/rte_mempool.c:379:
+	if ((n = rte_mempool_obj_iter(vaddr, elt_num, total_elt_sz, 1,

total: 2 errors, 0 warnings, 117 lines checked

/home/patchWorkOrg/patches/dpdk-dev-v3-02-35-mempool-rename-element-size-variables.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

12836: 
WARNING: quoted string split across lines
#67: FILE: lib/librte_mempool/rte_mempool.c:734:
+			rte_panic("MEMPOOL: object is owned by another "
+				  "mempool
");

WARNING: line over 80 characters
#76: FILE: lib/librte_mempool/rte_mempool.c:743:
+					"obj=%p, mempool=%p, cookie=%" PRIx64 "
",

WARNING: line over 80 characters
#85: FILE: lib/librte_mempool/rte_mempool.c:752:
+					"obj=%p, mempool=%p, cookie=%" PRIx64 "
",

WARNING: line over 80 characters
#95: FILE: lib/librte_mempool/rte_mempool.c:762:
+					"obj=%p, mempool=%p, cookie=%" PRIx64 "
",

WARNING: line over 80 characters
#97: FILE: lib/librte_mempool/rte_mempool.c:764:
+				rte_panic("MEMPOOL: bad header cookie (audit)
");

ERROR: space required before the open parenthesis '('
#127: FILE: lib/librte_mempool/rte_mempool.c:829:
+#define mempool_audit_cookies(mp) do {} while(0)

total: 1 errors, 5 warnings, 200 lines checked

/home/patchWorkOrg/patches/dpdk-dev-v3-03-35-mempool-uninline-function-to-check-cookies.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.


Compilation:
OS: fedora
Nic: niantic
GCC: gcc_x86-64, 4.8.3
ICC:16.0.2
i686-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-combined: compile pass
i686-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-debug: compile pass
x86_64-native-linuxapp-gcc-shared: compile pass
x86_64-native-linuxapp-clang: compile pass



DPDK STV team