Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 13905-13907
http://www.dpdk.org/dev/patchwork/patch/13907/
Submitter: WeiJie Zhuang <zhuangwj@gmail.com>
Date: Thu, 16 Jun 2016 19:27:01 +0800
DPDK git baseline: d76c19309a0b789d0f43e911db11c3ba3095819d

Check patch error:
13905: 
WARNING: line over 80 characters
#618: FILE: examples/ip_pipeline/config_parse.c:1930:
+									   "MEMPOOL", 1);

WARNING: line over 80 characters
#631: FILE: examples/ip_pipeline/config_parse.c:1943:
+											ent->value);

WARNING: line over 80 characters
#640: FILE: examples/ip_pipeline/config_parse.c:1952:
+											ent->value);

ERROR: Macros with complex values should be enclosed in parenthesis
#1169: FILE: lib/librte_port/rte_port_kni.c:47:
+#define RTE_PORT_KNI_READER_STATS_PKTS_IN_ADD(port, val) +	port->stats.n_pkts_in += val

ERROR: Macros with complex values should be enclosed in parenthesis
#1171: FILE: lib/librte_port/rte_port_kni.c:49:
+#define RTE_PORT_KNI_READER_STATS_PKTS_DROP_ADD(port, val) +	port->stats.n_pkts_drop += val

ERROR: Macros with complex values should be enclosed in parenthesis
#1259: FILE: lib/librte_port/rte_port_kni.c:137:
+#define RTE_PORT_KNI_WRITER_STATS_PKTS_IN_ADD(port, val) +	port->stats.n_pkts_in += val

ERROR: Macros with complex values should be enclosed in parenthesis
#1261: FILE: lib/librte_port/rte_port_kni.c:139:
+#define RTE_PORT_KNI_WRITER_STATS_PKTS_DROP_ADD(port, val) +	port->stats.n_pkts_drop += val

total: 4 errors, 3 warnings, 1392 lines checked

/home/patchWorkOrg/patches/dpdk-dev-v3-1-3-port-add-kni-interface-support.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.

13906: 
ERROR: Macros with complex values should be enclosed in parenthesis
#199: FILE: lib/librte_port/rte_port_kni.c:313:
+#define RTE_PORT_KNI_WRITER_NODROP_STATS_PKTS_IN_ADD(port, val) +	port->stats.n_pkts_in += val

ERROR: Macros with complex values should be enclosed in parenthesis
#201: FILE: lib/librte_port/rte_port_kni.c:315:
+#define RTE_PORT_KNI_WRITER_NODROP_STATS_PKTS_DROP_ADD(port, val) +	port->stats.n_pkts_drop += val

WARNING: line over 80 characters
#288: FILE: lib/librte_port/rte_port_kni.c:402:
+	RTE_PORT_KNI_WRITER_NODROP_STATS_PKTS_DROP_ADD(p, p->tx_buf_count - 
+nb_tx);

WARNING: space prohibited before semicolon
#289: FILE: lib/librte_port/rte_port_kni.c:403:
+	for ( ; nb_tx < p->tx_buf_count; nb_tx++)

WARNING: space prohibited before semicolon
#345: FILE: lib/librte_port/rte_port_kni.c:459:
+		for ( ; pkts_mask; ) {

total: 2 errors, 3 warnings, 385 lines checked

/home/patchWorkOrg/patches/dpdk-dev-v3-2-3-port-add-kni-nodrop-writer.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.


Compilation:
OS: fedora
Nic: niantic
GCC: gcc_x86-64, 4.8.3
ICC:16.0.2
i686-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-combined: compile pass
i686-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-debug: compile pass
x86_64-native-linuxapp-gcc-shared: compile pass
x86_64-native-linuxapp-clang: compile pass



DPDK STV team