From: sys_stv@intel.com
To: nhorman@tuxdriver.com, test-report@dpdk.org
Subject: [dpdk-test-report] [PatchWork]|ERROR| pw12793-12796 pmdinfo: Add buildtools and pmdinfo utility
Date: 18 May 2016 02:30:27 -0700 [thread overview]
Message-ID: <9c8bee$sshfn6@fmsmga001.fm.intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 11201 bytes --]
Test-Label: Intel Niantic on Fedora
Test-Status: ERROR
Patchwork ID: 12793-12796
http://www.dpdk.org/dev/patchwork/patch/12796/
Submitter: Neil Horman <nhorman@tuxdriver.com>
Date: Mon, 16 May 2016 16:41:24 -0400
DPDK git baseline: b4e0f64ff271ccc78f6275b6bd49194e86fd4f4b
Check patch error:
12793:
ERROR: trailing whitespace
#109: FILE: buildtools/Makefile:34:
+DIRS-y += pmdinfo $
ERROR: trailing whitespace
#172: FILE: buildtools/pmdinfo/pmdinfo.c:1:
+/* Postprocess pmd object files to export hw support $
WARNING: space prohibited before semicolon
#235: FILE: buildtools/pmdinfo/pmdinfo.c:64:
+for (; *pos < size ; (*pos)++) {
ERROR: trailing whitespace
#269: FILE: buildtools/pmdinfo/pmdinfo.c:98:
+static Elf_Sym *find_sym_in_symtab(struct elf_info *info, $
ERROR: space required before the open parenthesis '('
#278: FILE: buildtools/pmdinfo/pmdinfo.c:107:
+for(; idx < info->symtab_stop; idx++) {
WARNING: line over 80 characters
#332: FILE: buildtools/pmdinfo/pmdinfo.c:161:
+fprintf(stderr, "section header offset=%lu in file '%s' is bigger than "
WARNING: quoted string split across lines
#333: FILE: buildtools/pmdinfo/pmdinfo.c:162:
+fprintf(stderr, "section header offset=%lu in file '%s' is bigger than "
+ "filesize=%lu
", (unsigned long)hdr->e_shoff,
ERROR: else should follow close brace '}'
#345: FILE: buildtools/pmdinfo/pmdinfo.c:174:
+}
+else {
WARNING: braces {} are not necessary for any arm of this statement
#348: FILE: buildtools/pmdinfo/pmdinfo.c:177:
+if (hdr->e_shstrndx == SHN_XINDEX) {
[...]
+else {
[...]
ERROR: else should follow close brace '}'
#351: FILE: buildtools/pmdinfo/pmdinfo.c:180:
+}
+else {
WARNING: line over 80 characters
#375: FILE: buildtools/pmdinfo/pmdinfo.c:204:
+fprintf(stderr, "%s is truncated. sechdrs[i].sh_offset=%lu > "
WARNING: quoted string split across lines
#376: FILE: buildtools/pmdinfo/pmdinfo.c:205:
+fprintf(stderr, "%s is truncated. sechdrs[i].sh_offset=%lu > "
+ "sizeof(*hrd)=%zu
", filename,
WARNING: line over 80 characters
#384: FILE: buildtools/pmdinfo/pmdinfo.c:213:
+fprintf(stderr, "%s has NOBITS .modinfo
", filename);
WARNING: line over 80 characters
#433: FILE: buildtools/pmdinfo/pmdinfo.c:262:
+fprintf(stderr, "%s: SYMTAB_SHNDX has bad sh_link: %u!=%u
",
ERROR: code indent should use tabs where possible
#494: FILE: buildtools/pmdinfo/pmdinfo.c:323:
+ ^I * If this returns NULL, then this is a PMD_VDEV, because$
WARNING: please, no space before tabs
#494: FILE: buildtools/pmdinfo/pmdinfo.c:323:
+ ^I * If this returns NULL, then this is a PMD_VDEV, because$
ERROR: code indent should use tabs where possible
#495: FILE: buildtools/pmdinfo/pmdinfo.c:324:
+ ^I * it has no pci table reference$
WARNING: please, no space before tabs
#495: FILE: buildtools/pmdinfo/pmdinfo.c:324:
+ ^I * it has no pci table reference$
ERROR: code indent should use tabs where possible
#496: FILE: buildtools/pmdinfo/pmdinfo.c:325:
+ ^I */$
WARNING: please, no space before tabs
#496: FILE: buildtools/pmdinfo/pmdinfo.c:325:
+ ^I */$
WARNING: line over 80 characters
#508: FILE: buildtools/pmdinfo/pmdinfo.c:337:
+drv->pci_tbl = (struct rte_pci_id *)get_sym_value(info,
+drv->pci_tbl_sym);
ERROR: trailing whitespace
#514: FILE: buildtools/pmdinfo/pmdinfo.c:343:
+^I$
WARNING: line over 80 characters
#532: FILE: buildtools/pmdinfo/pmdinfo.c:361:
+fprintf(stderr, "Failed to complete pmd entry
");
WARNING: line over 80 characters
#558: FILE: buildtools/pmdinfo/pmdinfo.c:387:
+fprintf(ofd, "const char %s_pmd_info[] __attribute__((used)) =
+"PMD_INFO_STRING= {",
ERROR: space required after that ',' (ctx:VxV)
#560: FILE: buildtools/pmdinfo/pmdinfo.c:389:
+fprintf(ofd,"\"name\" : \"%s\", ", drv->name);
^
WARNING: line over 80 characters
#561: FILE: buildtools/pmdinfo/pmdinfo.c:390:
+fprintf(ofd,"\"type\" : \"%s\", ", drv->pci_tbl ? "PMD_PDEV"
+: "PMD_VDEV");
ERROR: space required after that ',' (ctx:VxV)
#561: FILE: buildtools/pmdinfo/pmdinfo.c:390:
+fprintf(ofd,"\"type\" : \"%s\", ", drv->pci_tbl ? "PMD_PDEV"
+: "PMD_VDEV");
^
ERROR: trailing whitespace
#562: FILE: buildtools/pmdinfo/pmdinfo.c:391:
+ $
WARNING: please, no spaces at the start of a line
#562: FILE: buildtools/pmdinfo/pmdinfo.c:391:
+ $
WARNING: line over 80 characters
#590: FILE: buildtools/pmdinfo/pmdinfo.c:419:
+fprintf(stderr, "usage: pmdinfo <object file> <c output file>
");
WARNING: line over 80 characters
#601: FILE: buildtools/pmdinfo/pmdinfo.c:430:
+fprintf(stderr, "Hmm, Appears to be a driver but no drivers
+registered
");
ERROR: trailing whitespace
#631: FILE: buildtools/pmdinfo/pmdinfo.h:19:
+#if 0 $
WARNING: do not add new typedefs
#664: FILE: buildtools/pmdinfo/pmdinfo.h:52:
+typedef struct
ERROR: open brace '{' following struct go on the same line
#665: FILE: buildtools/pmdinfo/pmdinfo.h:53:
+typedef struct
+{
WARNING: do not add new typedefs
#673: FILE: buildtools/pmdinfo/pmdinfo.h:61:
+typedef union
ERROR: open brace '{' following union go on the same line
#674: FILE: buildtools/pmdinfo/pmdinfo.h:62:
+typedef union
+{
WARNING: please, no spaces at the start of a line
#680: FILE: buildtools/pmdinfo/pmdinfo.h:68:
+ ((__extension__ (_Elf64_Mips_R_Info_union)(i)).r_info_fields.r_sym)$
WARNING: please, no spaces at the start of a line
#683: FILE: buildtools/pmdinfo/pmdinfo.h:71:
+ ((__extension__
+ (_Elf64_Mips_R_Info_union)(i)).r_info_fields.r_type1)$
ERROR: trailing whitespace
#685: FILE: buildtools/pmdinfo/pmdinfo.h:73:
+#if 0 $
ERROR: "(foo*)" should be "(foo *)"
#691: FILE: buildtools/pmdinfo/pmdinfo.h:79:
+((unsigned char*)dest)[i] = ((unsigned char*)src)[size - i-1];
ERROR: "(foo*)" should be "(foo *)"
#691: FILE: buildtools/pmdinfo/pmdinfo.h:79:
+((unsigned char*)dest)[i] = ((unsigned char*)src)[size - i-1];
WARNING: __printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check)))
#716: FILE: buildtools/pmdinfo/pmdinfo.h:104:
+void __attribute__((format(printf, 2, 3)))
ERROR: "foo* bar" should be "foo *bar"
#817: FILE: buildtools/pmdinfo/pmdinfo.h:205:
+char* get_next_line(unsigned long *pos, void *file, unsigned long
+size);
total: 20 errors, 23 warnings, 893 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
scripts/cleanfile
/home/patchWorkOrg/patches/dpdk-dev-1-4-pmdinfo-Add-buildtools-and-pmdinfo-utility.patch has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
12794:
WARNING: line over 80 characters
#347: FILE: drivers/net/szedata2/rte_eth_szedata2.c:1604:
+PMD_REGISTER_DRIVER_PDEV(rte_szedata2_driver, rte_szedata2_pci_id_table
+,rte_szedata2_pmd);
ERROR: space required after that ',' (ctx:WxV)
#347: FILE: drivers/net/szedata2/rte_eth_szedata2.c:1604:
+PMD_REGISTER_DRIVER_PDEV(rte_szedata2_driver, rte_szedata2_pci_id_table
+,rte_szedata2_pmd);
^
ERROR: space required after that ',' (ctx:VxV)
#377: FILE: drivers/net/vmxnet3/vmxnet3_ethdev.c:957:
+PMD_REGISTER_DRIVER_PDEV(rte_vmxnet3_driver,
+pci_id_vmxnet3_map,vmxnet3);
^
ERROR: Macros with complex values should be enclosed in parenthesis
#405: FILE: lib/librte_eal/common/include/rte_dev.h:181:
+#define DRIVER_EXPORT_NAME_ARRAY(n, idx) n##idx[] __attribute__((used))
WARNING: line over 80 characters
#407: FILE: lib/librte_eal/common/include/rte_dev.h:183:
+#define DRIVER_EXPORT_PDEV(d, n, idx) static const char
+DRIVER_EXPORT_NAME_ARRAY(this_pmd_driver, idx) = RTE_STR(d);
WARNING: storage class should be at the beginning of the declaration
#407: FILE: lib/librte_eal/common/include/rte_dev.h:183:
+#define DRIVER_EXPORT_PDEV(d, n, idx) static const char
+DRIVER_EXPORT_NAME_ARRAY(this_pmd_driver, idx) = RTE_STR(d);
WARNING: line over 80 characters
#410: FILE: lib/librte_eal/common/include/rte_dev.h:186:
+#define DRIVER_EXPORT_VDEV(d, idx) static const char
+DRIVER_EXPORT_NAME_ARRAY(this_pmd_name, idx) = RTE_STR(d)
WARNING: storage class should be at the beginning of the declaration
#410: FILE: lib/librte_eal/common/include/rte_dev.h:186:
+#define DRIVER_EXPORT_VDEV(d, idx) static const char
+DRIVER_EXPORT_NAME_ARRAY(this_pmd_name, idx) = RTE_STR(d)
ERROR: code indent should use tabs where possible
#418: FILE: lib/librte_eal/common/include/rte_dev.h:192:
+ rte_eal_driver_register(&d);\$
WARNING: please, no spaces at the start of a line
#418: FILE: lib/librte_eal/common/include/rte_dev.h:192:
+ rte_eal_driver_register(&d);\$
ERROR: space required after that close brace '}'
#419: FILE: lib/librte_eal/common/include/rte_dev.h:193:
+}
ERROR: Macros with complex values should be enclosed in parenthesis
#421: FILE: lib/librte_eal/common/include/rte_dev.h:195:
+#define PMD_REGISTER_DRIVER_PDEV(d, t, n) +PMD_REGISTER_DRIVER(d) +DRIVER_EXPORT_PDEV(t, n, __COUNTER__)
ERROR: Macros with complex values should be enclosed in parenthesis
#425: FILE: lib/librte_eal/common/include/rte_dev.h:199:
+#define PMD_REGISTER_DRIVER_VDEV(d, n) +PMD_REGISTER_DRIVER(d) +DRIVER_EXPORT_VDEV(n, __COUNTER__)
total: 7 errors, 6 warnings, 208 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
scripts/cleanfile
/home/patchWorkOrg/patches/dpdk-dev-2-4-drivers-Update-driver-registration-macro-usage.patch has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
12796:
ERROR: trailing whitespace
#201: FILE: tools/pmd_hw_support.py:161:
+ $
ERROR: trailing whitespace
#202: FILE: tools/pmd_hw_support.py:162:
+ readelf.display_pmd_info_strings(".rodata") $
ERROR: trailing whitespace
#204: FILE: tools/pmd_hw_support.py:164:
+ $
total: 3 errors, 0 warnings, 174 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
scripts/cleanfile
/home/patchWorkOrg/patches/dpdk-dev-4-4-pmd_hw_support.py-Add-tool-to-query-binaries-for-hw-support-information.patch has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
Compilation:
OS: fedora
Nic: niantic
GCC: gcc_x86-64, 4.8.3
ICC:16.0.2
i686-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-combined: compile pass
i686-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-debug: compile pass
x86_64-native-linuxapp-gcc-shared: compile pass
x86_64-native-linuxapp-clang: compile pass
DPDK STV team
reply other threads:[~2016-05-18 9:30 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='9c8bee$sshfn6@fmsmga001.fm.intel.com' \
--to=sys_stv@intel.com \
--cc=nhorman@tuxdriver.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).