From: sys_stv@intel.com
To: nhorman@tuxdriver.com, test-report@dpdk.org
Subject: [dpdk-test-report] [PatchWork]|ERROR| pw12920-12924 pmdinfogen: Add buildtools and pmdinfogen utility
Date: 22 May 2016 20:15:32 -0700 [thread overview]
Message-ID: <9c8bee$svbp5f@fmsmga001.fm.intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 11845 bytes --]
Test-Label: Intel Niantic on Fedora
Test-Status: ERROR
Patchwork ID: 12920-12924
http://www.dpdk.org/dev/patchwork/patch/12924/
Submitter: Neil Horman <nhorman@tuxdriver.com>
Date: Fri, 20 May 2016 13:24:42 -0400
DPDK git baseline: 587d684d70f9d7f74e77a886c58103b40409caea
Check patch error:
12920:
ERROR: trailing whitespace
#173: FILE: buildtools/pmdinfogen/pmdinfogen.c:1:
+/* Postprocess pmd object files to export hw support $
ERROR: trailing whitespace
#241: FILE: buildtools/pmdinfogen/pmdinfogen.c:69:
+static Elf_Sym *find_sym_in_symtab(struct elf_info *info, $
ERROR: space required before the open parenthesis '('
#250: FILE: buildtools/pmdinfogen/pmdinfogen.c:78:
+for(; idx < info->symtab_stop; idx++) {
WARNING: line over 80 characters
#304: FILE: buildtools/pmdinfogen/pmdinfogen.c:132:
+fprintf(stderr, "section header offset=%lu in file '%s' is bigger than "
WARNING: quoted string split across lines
#305: FILE: buildtools/pmdinfogen/pmdinfogen.c:133:
+fprintf(stderr, "section header offset=%lu in file '%s' is bigger than "
+ "filesize=%lu
", (unsigned long)hdr->e_shoff,
ERROR: else should follow close brace '}'
#317: FILE: buildtools/pmdinfogen/pmdinfogen.c:145:
+}
+else {
WARNING: braces {} are not necessary for any arm of this statement
#320: FILE: buildtools/pmdinfogen/pmdinfogen.c:148:
+if (hdr->e_shstrndx == SHN_XINDEX) {
[...]
+else {
[...]
ERROR: else should follow close brace '}'
#323: FILE: buildtools/pmdinfogen/pmdinfogen.c:151:
+}
+else {
WARNING: line over 80 characters
#346: FILE: buildtools/pmdinfogen/pmdinfogen.c:174:
+fprintf(stderr, "%s is truncated. sechdrs[i].sh_offset=%lu > "
WARNING: quoted string split across lines
#347: FILE: buildtools/pmdinfogen/pmdinfogen.c:175:
+fprintf(stderr, "%s is truncated. sechdrs[i].sh_offset=%lu > "
+ "sizeof(*hrd)=%zu
", filename,
WARNING: line over 80 characters
#388: FILE: buildtools/pmdinfogen/pmdinfogen.c:216:
+fprintf(stderr, "%s: SYMTAB_SHNDX has bad sh_link: %u!=%u
",
ERROR: "foo* bar" should be "foo *bar"
#434: FILE: buildtools/pmdinfogen/pmdinfogen.c:262:
+const char* suffix;
ERROR: "foo* bar" should be "foo *bar"
#435: FILE: buildtools/pmdinfogen/pmdinfogen.c:263:
+const char* json_id;
ERROR: trailing whitespace
#448: FILE: buildtools/pmdinfogen/pmdinfogen.c:276:
+^I$
ERROR: spaces required around that '=' (ctx:VxV)
#452: FILE: buildtools/pmdinfogen/pmdinfogen.c:280:
+for (i=0; i<PMD_OPT_MAX; i++) {
^
ERROR: spaces required around that '<' (ctx:VxV)
#452: FILE: buildtools/pmdinfogen/pmdinfogen.c:280:
+for (i=0; i<PMD_OPT_MAX; i++) {
^
ERROR: code indent should use tabs where possible
#468: FILE: buildtools/pmdinfogen/pmdinfogen.c:296:
+ ^I * If this returns NULL, then this is a PMD_VDEV, because$
WARNING: please, no space before tabs
#468: FILE: buildtools/pmdinfogen/pmdinfogen.c:296:
+ ^I * If this returns NULL, then this is a PMD_VDEV, because$
ERROR: code indent should use tabs where possible
#469: FILE: buildtools/pmdinfogen/pmdinfogen.c:297:
+ ^I * it has no pci table reference$
WARNING: please, no space before tabs
#469: FILE: buildtools/pmdinfogen/pmdinfogen.c:297:
+ ^I * it has no pci table reference$
ERROR: code indent should use tabs where possible
#470: FILE: buildtools/pmdinfogen/pmdinfogen.c:298:
+ ^I */$
WARNING: please, no space before tabs
#470: FILE: buildtools/pmdinfogen/pmdinfogen.c:298:
+ ^I */$
ERROR: trailing whitespace
#487: FILE: buildtools/pmdinfogen/pmdinfogen.c:315:
+^I$
WARNING: line over 80 characters
#505: FILE: buildtools/pmdinfogen/pmdinfogen.c:333:
+fprintf(stderr, "Failed to complete pmd entry
");
WARNING: line over 80 characters
#531: FILE: buildtools/pmdinfogen/pmdinfogen.c:359:
+fprintf(ofd, "const char %s_pmd_info[] __attribute__((used)) =
+"PMD_INFO_STRING= {",
ERROR: space required after that ',' (ctx:VxV)
#533: FILE: buildtools/pmdinfogen/pmdinfogen.c:361:
+fprintf(ofd,"\"name\" : \"%s\", ", drv->name);
^
WARNING: line over 80 characters
#534: FILE: buildtools/pmdinfogen/pmdinfogen.c:362:
+fprintf(ofd,"\"type\" : \"%s\", ", drv->pci_tbl ? "PMD_PDEV"
+: "PMD_VDEV");
ERROR: space required after that ',' (ctx:VxV)
#534: FILE: buildtools/pmdinfogen/pmdinfogen.c:362:
+fprintf(ofd,"\"type\" : \"%s\", ", drv->pci_tbl ? "PMD_PDEV"
+: "PMD_VDEV");
^
ERROR: spaces required around that '=' (ctx:VxV)
#536: FILE: buildtools/pmdinfogen/pmdinfogen.c:364:
+for(idx=0; idx<PMD_OPT_MAX; idx++) {
^
ERROR: spaces required around that '<' (ctx:VxV)
#536: FILE: buildtools/pmdinfogen/pmdinfogen.c:364:
+for(idx=0; idx<PMD_OPT_MAX; idx++) {
^
ERROR: space required before the open parenthesis '('
#536: FILE: buildtools/pmdinfogen/pmdinfogen.c:364:
+for(idx=0; idx<PMD_OPT_MAX; idx++) {
WARNING: line over 80 characters
#538: FILE: buildtools/pmdinfogen/pmdinfogen.c:366:
+fprintf(ofd,"\"%s\" : \"%s\", ", opt_tags[idx].json_id,
ERROR: space required after that ',' (ctx:VxV)
#538: FILE: buildtools/pmdinfogen/pmdinfogen.c:366:
+fprintf(ofd,"\"%s\" : \"%s\", ", opt_tags[idx].json_id,
^
WARNING: line over 80 characters
#569: FILE: buildtools/pmdinfogen/pmdinfogen.c:397:
+fprintf(stderr, "usage: pmdinfo <object file> <c output file>
");
WARNING: line over 80 characters
#580: FILE: buildtools/pmdinfogen/pmdinfogen.c:408:
+fprintf(stderr, "Hmm, Appears to be a driver but no drivers
+registered
");
ERROR: "foo* bar" should be "foo *bar"
#645: FILE: buildtools/pmdinfogen/pmdinfogen.h:54:
+const char* opt_vals[PMD_OPT_MAX];
total: 21 errors, 15 warnings, 744 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
scripts/cleanfile
/home/patchWorkOrg/patches/dpdk-dev-PATCHv3-1-5-pmdinfogen-Add-buildtools-and-pmdinfogen-utility.patch has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
12921:
WARNING: Avoid line continuations in quoted strings
#104: FILE: drivers/crypto/aesni_gcm/aesni_gcm_pmd.c:525:
+DRIVER_REGISTER_PARAM_STRING(aesni_gcm, "max_nb_queue_pairs=<int>
WARNING: Avoid line continuations in quoted strings
#116: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c:720:
+DRIVER_REGISTER_PARAM_STRING(aesni_gcm, "max_nb_queue_pairs=<int>
WARNING: Avoid line continuations in quoted strings
#128: FILE: drivers/crypto/null/null_crypto_pmd.c:279:
+DRIVER_REGISTER_PARAM_STRING(aesni_gcm, "max_nb_queue_pairs=<int>
WARNING: Avoid line continuations in quoted strings
#152: FILE: drivers/crypto/snow3g/rte_snow3g_pmd.c:552:
+DRIVER_REGISTER_PARAM_STRING(aesni_gcm, "max_nb_queue_pairs=<int>
WARNING: Avoid line continuations in quoted strings
#164: FILE: drivers/net/af_packet/rte_eth_af_packet.c:882:
+DRIVER_REGISTER_PARAM_STRING(eth_af_packet, "iface=<string>
WARNING: Avoid line continuations in quoted strings
#191: FILE: drivers/net/bonding/rte_eth_bond_pmd.c:2516:
+DRIVER_REGISTER_PARAM_STRING(bonding, "slave=<ifc> primary=<ifc>
+mode=[0-4]
WARNING: Avoid line continuations in quoted strings
#379: FILE: drivers/net/pcap/rte_eth_pcap.c:1094:
+DRIVER_REGISTER_PARAM_STRING(pcap, "rx_pcap=<string> tx_pcap=<string>
ERROR: Macros with complex values should be enclosed in parenthesis
#478: FILE: lib/librte_eal/common/include/rte_dev.h:181:
+#define DRIVER_EXPORT_NAME_ARRAY(n, idx) n##idx[] __attribute__((used))
ERROR: trailing whitespace
#482: FILE: lib/librte_eal/common/include/rte_dev.h:185:
+ $
WARNING: please, no spaces at the start of a line
#482: FILE: lib/librte_eal/common/include/rte_dev.h:185:
+ $
ERROR: code indent should use tabs where possible
#490: FILE: lib/librte_eal/common/include/rte_dev.h:191:
+ rte_eal_driver_register(&d);\$
WARNING: please, no spaces at the start of a line
#490: FILE: lib/librte_eal/common/include/rte_dev.h:191:
+ rte_eal_driver_register(&d);\$
ERROR: space required after that close brace '}'
#491: FILE: lib/librte_eal/common/include/rte_dev.h:192:
+}
WARNING: line over 80 characters
#497: FILE: lib/librte_eal/common/include/rte_dev.h:198:
+static const char DRV_EXP_TAG(n, pci_tbl_export)[]
+__attribute__((used)) = RTE_STR(t)
WARNING: line over 80 characters
#500: FILE: lib/librte_eal/common/include/rte_dev.h:201:
+static const char DRV_EXP_TAG(n, param_string_export)[]
+__attribute__((used)) = s
total: 4 errors, 11 warnings, 260 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
scripts/cleanfile
/home/patchWorkOrg/patches/dpdk-dev-PATCHv3-2-5-drivers-Update-driver-registration-macro-usage.patch has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
12922:
ERROR: trailing whitespace
#47: FILE: lib/librte_eal/common/eal_common_options.c:119:
+ * Stringified version of solib path used by pmdinfo.py $
WARNING: Avoid unnecessary line continuations
#51: FILE: lib/librte_eal/common/eal_common_options.c:123:
+static const char dpdk_solib_path[] __attribute__((used)) =
total: 1 errors, 1 warnings, 15 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
scripts/cleanfile
/home/patchWorkOrg/patches/dpdk-dev-PATCHv3-3-5-eal-Add-an-export-symbol-to-expose-the-autoload-path-to-external-tools.patch has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
12924:
ERROR: trailing whitespace
#152: FILE: tools/pmdinfo.py:96:
+ return Device("%s Unknown Device" % devid) $
ERROR: trailing whitespace
#195: FILE: tools/pmdinfo.py:139:
+ $
ERROR: trailing whitespace
#255: FILE: tools/pmdinfo.py:199:
+ except: $
ERROR: trailing whitespace
#351: FILE: tools/pmdinfo.py:295:
+ $
ERROR: trailing whitespace
#528: FILE: tools/pmdinfo.py:472:
+ print("Discovered Autoload HW Support:") $
ERROR: trailing whitespace
#529: FILE: tools/pmdinfo.py:473:
+ scan_autoload_path(autoload_path) $
ERROR: trailing whitespace
#531: FILE: tools/pmdinfo.py:475:
+ $
ERROR: trailing whitespace
#532: FILE: tools/pmdinfo.py:476:
+ $
ERROR: trailing whitespace
#565: FILE: tools/pmdinfo.py:509:
+ if options.tblout: $
ERROR: trailing whitespace
#589: FILE: tools/pmdinfo.py:533:
+ readelf.display_pmd_info_strings(".rodata") $
ERROR: trailing whitespace
#591: FILE: tools/pmdinfo.py:535:
+ $
total: 11 errors, 0 warnings, 545 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
scripts/cleanfile
/home/patchWorkOrg/patches/dpdk-dev-PATCHv3-5-5-pmdinfo.py-Add-tool-to-query-binaries-for-hw-and-other-support-information.patch has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
Compilation:
OS: fedora
Nic: niantic
GCC: gcc_x86-64, 4.8.3
ICC:16.0.2
i686-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-combined: compile pass
i686-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-debug: compile pass
x86_64-native-linuxapp-gcc-shared: compile pass
x86_64-native-linuxapp-clang: compile pass
DPDK STV team
reply other threads:[~2016-05-23 3:15 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='9c8bee$svbp5f@fmsmga001.fm.intel.com' \
--to=sys_stv@intel.com \
--cc=nhorman@tuxdriver.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).